USB: rename usb_buffer_alloc() and usb_buffer_free() users

For more clearance what the functions actually do,

  usb_buffer_alloc() is renamed to usb_alloc_coherent()
  usb_buffer_free()  is renamed to usb_free_coherent()

They should only be used in code which really needs DMA coherency.

All call sites have been changed accordingly, except for staging
drivers.

Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Pedro Ribeiro <pedrib@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

5 files changed, 34 insertions, 38 deletions

diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index d800b598ae3d..25a5c7eea948 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -516,8 +516,8 @@ static void ems_usb_write_bulk_callback(struct urb *urb)
         netdev = dev->netdev;
 
         /* free up our allocated buffer */
-        usb_buffer_free(urb->dev, urb->transfer_buffer_length,
-                        urb->transfer_buffer, urb->transfer_dma);
+        usb_free_coherent(urb->dev, urb->transfer_buffer_length,
+                          urb->transfer_buffer, urb->transfer_dma);
 
         atomic_dec(&dev->active_tx_urbs);
 
@@ -614,8 +614,8 @@ static int ems_usb_start(struct ems_usb *dev)
                         return -ENOMEM;
                 }
 
-                buf = usb_buffer_alloc(dev->udev, RX_BUFFER_SIZE, GFP_KERNEL,
-                                       &urb->transfer_dma);
+                buf = usb_alloc_coherent(dev->udev, RX_BUFFER_SIZE, GFP_KERNEL,
+                                         &urb->transfer_dma);
                 if (!buf) {
                         dev_err(netdev->dev.parent,
                                 "No memory left for USB buffer\n");
@@ -635,8 +635,8 @@ static int ems_usb_start(struct ems_usb *dev)
                                 netif_device_detach(dev->netdev);
 
                         usb_unanchor_urb(urb);
-                        usb_buffer_free(dev->udev, RX_BUFFER_SIZE, buf,
-                                        urb->transfer_dma);
+                        usb_free_coherent(dev->udev, RX_BUFFER_SIZE, buf,
+                                          urb->transfer_dma);
                         break;
                 }
 
@@ -777,7 +777,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
                 goto nomem;
         }
 
-        buf = usb_buffer_alloc(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma);
+        buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma);
         if (!buf) {
                 dev_err(netdev->dev.parent, "No memory left for USB buffer\n");
                 usb_free_urb(urb);
@@ -820,7 +820,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
          */
         if (!context) {
                 usb_unanchor_urb(urb);
-                usb_buffer_free(dev->udev, size, buf, urb->transfer_dma);
+                usb_free_coherent(dev->udev, size, buf, urb->transfer_dma);
 
                 dev_warn(netdev->dev.parent, "couldn't find free context\n");
 
@@ -845,7 +845,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
                 can_free_echo_skb(netdev, context->echo_index);
 
                 usb_unanchor_urb(urb);
-                usb_buffer_free(dev->udev, size, buf, urb->transfer_dma);
+                usb_free_coherent(dev->udev, size, buf, urb->transfer_dma);
                 dev_kfree_skb(skb);
 
                 atomic_dec(&dev->active_tx_urbs);
diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c
index 418825d26f90..197c352c47fb 100644
--- a/drivers/net/usb/ipheth.c
+++ b/drivers/net/usb/ipheth.c
@@ -128,17 +128,13 @@ static int ipheth_alloc_urbs(struct ipheth_device *iphone)
         if (rx_urb == NULL)
                 goto free_tx_urb;
 
-        tx_buf = usb_buffer_alloc(iphone->udev,
-                                  IPHETH_BUF_SIZE,
-                                  GFP_KERNEL,
-                                  &tx_urb->transfer_dma);
+        tx_buf = usb_alloc_coherent(iphone->udev, IPHETH_BUF_SIZE,
+                                    GFP_KERNEL, &tx_urb->transfer_dma);
         if (tx_buf == NULL)
                 goto free_rx_urb;
 
-        rx_buf = usb_buffer_alloc(iphone->udev,
-                                  IPHETH_BUF_SIZE,
-                                  GFP_KERNEL,
-                                  &rx_urb->transfer_dma);
+        rx_buf = usb_alloc_coherent(iphone->udev, IPHETH_BUF_SIZE,
+                                    GFP_KERNEL, &rx_urb->transfer_dma);
         if (rx_buf == NULL)
                 goto free_tx_buf;
 
@@ -150,8 +146,8 @@ static int ipheth_alloc_urbs(struct ipheth_device *iphone)
         return 0;
 
 free_tx_buf:
-        usb_buffer_free(iphone->udev, IPHETH_BUF_SIZE, tx_buf,
-                        tx_urb->transfer_dma);
+        usb_free_coherent(iphone->udev, IPHETH_BUF_SIZE, tx_buf,
+                          tx_urb->transfer_dma);
 free_rx_urb:
         usb_free_urb(rx_urb);
 free_tx_urb:
@@ -162,10 +158,10 @@ error_nomem:
 
 static void ipheth_free_urbs(struct ipheth_device *iphone)
 {
-        usb_buffer_free(iphone->udev, IPHETH_BUF_SIZE, iphone->rx_buf,
-                        iphone->rx_urb->transfer_dma);
-        usb_buffer_free(iphone->udev, IPHETH_BUF_SIZE, iphone->tx_buf,
-                        iphone->tx_urb->transfer_dma);
+        usb_free_coherent(iphone->udev, IPHETH_BUF_SIZE, iphone->rx_buf,
+                          iphone->rx_urb->transfer_dma);
+        usb_free_coherent(iphone->udev, IPHETH_BUF_SIZE, iphone->tx_buf,
+                          iphone->tx_urb->transfer_dma);
         usb_free_urb(iphone->rx_urb);
         usb_free_urb(iphone->tx_urb);
 }
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index c4c334d9770f..a3eb7be51d53 100644
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -1156,13 +1156,13 @@ err_fw:
         if (!kaweth->irq_urb)
                 goto err_tx_and_rx;
 
-        kaweth->intbuffer = usb_buffer_alloc(   kaweth->dev,
+        kaweth->intbuffer = usb_alloc_coherent( kaweth->dev,
                                                 INTBUFFERSIZE,
                                                 GFP_KERNEL,
                                                 &kaweth->intbufferhandle);
         if (!kaweth->intbuffer)
                 goto err_tx_and_rx_and_irq;
-        kaweth->rx_buf = usb_buffer_alloc(      kaweth->dev,
+        kaweth->rx_buf = usb_alloc_coherent(    kaweth->dev,
                                                 KAWETH_BUF_SIZE,
                                                 GFP_KERNEL,
                                                 &kaweth->rxbufferhandle);
@@ -1203,9 +1203,9 @@ err_fw:
 
 err_intfdata:
         usb_set_intfdata(intf, NULL);
-        usb_buffer_free(kaweth->dev, KAWETH_BUF_SIZE, (void *)kaweth->rx_buf, kaweth->rxbufferhandle);
+        usb_free_coherent(kaweth->dev, KAWETH_BUF_SIZE, (void *)kaweth->rx_buf, kaweth->rxbufferhandle);
 err_all_but_rxbuf:
-        usb_buffer_free(kaweth->dev, INTBUFFERSIZE, (void *)kaweth->intbuffer, kaweth->intbufferhandle);
+        usb_free_coherent(kaweth->dev, INTBUFFERSIZE, (void *)kaweth->intbuffer, kaweth->intbufferhandle);
 err_tx_and_rx_and_irq:
         usb_free_urb(kaweth->irq_urb);
 err_tx_and_rx:
@@ -1242,8 +1242,8 @@ static void kaweth_disconnect(struct usb_interface *intf)
         usb_free_urb(kaweth->tx_urb);
         usb_free_urb(kaweth->irq_urb);
 
-        usb_buffer_free(kaweth->dev, KAWETH_BUF_SIZE, (void *)kaweth->rx_buf, kaweth->rxbufferhandle);
-        usb_buffer_free(kaweth->dev, INTBUFFERSIZE, (void *)kaweth->intbuffer, kaweth->intbufferhandle);
+        usb_free_coherent(kaweth->dev, KAWETH_BUF_SIZE, (void *)kaweth->rx_buf, kaweth->rxbufferhandle);
+        usb_free_coherent(kaweth->dev, INTBUFFERSIZE, (void *)kaweth->intbuffer, kaweth->intbufferhandle);
 
         free_netdev(netdev);
 }
diff --git a/drivers/net/wireless/ath/ar9170/usb.c b/drivers/net/wireless/ath/ar9170/usb.c
index e1c2fcaa8bed..a1f5444f7ccd 100644
--- a/drivers/net/wireless/ath/ar9170/usb.c
+++ b/drivers/net/wireless/ath/ar9170/usb.c
@@ -202,7 +202,7 @@ resubmit:
         return;
 
 free:
-        usb_buffer_free(aru->udev, 64, urb->transfer_buffer, urb->transfer_dma);
+        usb_free_coherent(aru->udev, 64, urb->transfer_buffer, urb->transfer_dma);
 }
 
 static void ar9170_usb_rx_completed(struct urb *urb)
@@ -283,7 +283,7 @@ static int ar9170_usb_alloc_rx_irq_urb(struct ar9170_usb *aru)
         if (!urb)
                 goto out;
 
-        ibuf = usb_buffer_alloc(aru->udev, 64, GFP_KERNEL, &urb->transfer_dma);
+        ibuf = usb_alloc_coherent(aru->udev, 64, GFP_KERNEL, &urb->transfer_dma);
         if (!ibuf)
                 goto out;
 
@@ -296,8 +296,8 @@ static int ar9170_usb_alloc_rx_irq_urb(struct ar9170_usb *aru)
         err = usb_submit_urb(urb, GFP_KERNEL);
         if (err) {
                 usb_unanchor_urb(urb);
-                usb_buffer_free(aru->udev, 64, urb->transfer_buffer,
-                                urb->transfer_dma);
+                usb_free_coherent(aru->udev, 64, urb->transfer_buffer,
+                                  urb->transfer_dma);
         }
 
 out:
diff --git a/drivers/net/wireless/zd1211rw/zd_usb.c b/drivers/net/wireless/zd1211rw/zd_usb.c
index d91ad1a612af..c257940b71b6 100644
--- a/drivers/net/wireless/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zd1211rw/zd_usb.c
@@ -664,15 +664,15 @@ static struct urb *alloc_rx_urb(struct zd_usb *usb)
         urb = usb_alloc_urb(0, GFP_KERNEL);
         if (!urb)
                 return NULL;
-        buffer = usb_buffer_alloc(udev, USB_MAX_RX_SIZE, GFP_KERNEL,
-                                  &urb->transfer_dma);
+        buffer = usb_alloc_coherent(udev, USB_MAX_RX_SIZE, GFP_KERNEL,
+                                    &urb->transfer_dma);
         if (!buffer) {
                 usb_free_urb(urb);
                 return NULL;
         }
 
         usb_fill_bulk_urb(urb, udev, usb_rcvbulkpipe(udev, EP_DATA_IN),
-                          buffer, USB_MAX_RX_SIZE,
+                          buffer, USB_MAX_RX_SIZE,
                           rx_urb_complete, usb);
         urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
 
@@ -683,8 +683,8 @@ static void free_rx_urb(struct urb *urb)
 {
         if (!urb)
                 return;
-        usb_buffer_free(urb->dev, urb->transfer_buffer_length,
-                        urb->transfer_buffer, urb->transfer_dma);
+        usb_free_coherent(urb->dev, urb->transfer_buffer_length,
+                          urb->transfer_buffer, urb->transfer_dma);
         usb_free_urb(urb);
 }