Merge tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux

Pull fixes for cpumask and modules from Rusty Russell:
 "** NOW WITH TESTING! **

  Two fixes which got lost in my recent distraction.  One is a weird
  cpumask function which needed to be rewritten, the other is a module
  bug which is cc:stable"

* tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux:
  cpumask_set_cpu_local_first => cpumask_local_spread, lament
  module: Call module notifier on failure after complete_formation()

3 files changed, 9 insertions, 13 deletions

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index a6dcbf850c1f..6f9ffb9026cd 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -2358,11 +2358,11 @@ static int be_evt_queues_create(struct be_adapter *adapter)
                                     adapter->cfg_num_qs);
 
         for_all_evt_queues(adapter, eqo, i) {
+                int numa_node = dev_to_node(&adapter->pdev->dev);
                 if (!zalloc_cpumask_var(&eqo->affinity_mask, GFP_KERNEL))
                         return -ENOMEM;
-                cpumask_set_cpu_local_first(i, dev_to_node(&adapter->pdev->dev),
-                                            eqo->affinity_mask);
-
+                cpumask_set_cpu(cpumask_local_spread(i, numa_node),
+                                eqo->affinity_mask);
                 netif_napi_add(adapter->netdev, &eqo->napi, be_poll,
                                BE_NAPI_WEIGHT);
                 napi_hash_add(&eqo->napi);
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 32f5ec737472..cf467a9f6cc7 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1501,17 +1501,13 @@ static int mlx4_en_init_affinity_hint(struct mlx4_en_priv *priv, int ring_idx)
 {
         struct mlx4_en_rx_ring *ring = priv->rx_ring[ring_idx];
         int numa_node = priv->mdev->dev->numa_node;
-        int ret = 0;
 
         if (!zalloc_cpumask_var(&ring->affinity_mask, GFP_KERNEL))
                 return -ENOMEM;
 
-        ret = cpumask_set_cpu_local_first(ring_idx, numa_node,
-                                          ring->affinity_mask);
-        if (ret)
-                free_cpumask_var(ring->affinity_mask);
-
-        return ret;
+        cpumask_set_cpu(cpumask_local_spread(ring_idx, numa_node),
+                        ring->affinity_mask);
+        return 0;
 }
 
 static void mlx4_en_free_affinity_hint(struct mlx4_en_priv *priv, int ring_idx)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index f7bf312fb443..7bed3a88579f 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -144,9 +144,9 @@ int mlx4_en_create_tx_ring(struct mlx4_en_priv *priv,
         ring->queue_index = queue_index;
 
         if (queue_index < priv->num_tx_rings_p_up)
-                cpumask_set_cpu_local_first(queue_index,
-                                            priv->mdev->dev->numa_node,
-                                            &ring->affinity_mask);
+                cpumask_set_cpu(cpumask_local_spread(queue_index,
+                                                     priv->mdev->dev->numa_node),
+                                &ring->affinity_mask);
 
         *pring = ring;
         return 0;