diff options
author | Matt Carlson <mcarlson@broadcom.com> | 2010-09-15 04:59:53 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-15 17:16:10 -0400 |
commit | 41a8a7ee4a78216962f3afcea5968c04d0ab3b08 (patch) | |
tree | 9caf37cafecfabdce77b3af8c200bb1723201565 /drivers/net | |
parent | 21a4591794c82c1a73f9d45d6400f878648261e3 (diff) |
tg3: Fix read DMA FIFO overruns on recent devices
Earlier versions of tg3 devices had a problem where the read DMA FIFO
could be overrun in certain edge conditions. The fix was to limit the
number of rx BDs the hardware would fetch at a time. For later devices
(5761, 5784 and later ASIC revs), there is a hardware fix that must be
enabled to fix the same problem. This patch adds that hardware fix.
There is a gap in the ASIC revision lineage where neither fix is
applied. This is intentional as these ASIC revisions are not afflicted
by the bug.
Reviewed-by: Benjamin Li <benli@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/tg3.c | 10 | ||||
-rw-r--r-- | drivers/net/tg3.h | 6 |
2 files changed, 15 insertions, 1 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 9f6ffffc8376..c3a430cfbe00 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -8015,6 +8015,16 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy) | |||
8015 | GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780) | 8015 | GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780) |
8016 | rdmac_mode |= RDMAC_MODE_IPV6_LSO_EN; | 8016 | rdmac_mode |= RDMAC_MODE_IPV6_LSO_EN; |
8017 | 8017 | ||
8018 | if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5761 || | ||
8019 | GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784 || | ||
8020 | GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5785 || | ||
8021 | GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780 || | ||
8022 | (tp->tg3_flags3 & TG3_FLG3_5717_PLUS)) { | ||
8023 | val = tr32(TG3_RDMA_RSRVCTRL_REG); | ||
8024 | tw32(TG3_RDMA_RSRVCTRL_REG, | ||
8025 | val | TG3_RDMA_RSRVCTRL_FIFO_OFLW_FIX); | ||
8026 | } | ||
8027 | |||
8018 | /* Receive/send statistics. */ | 8028 | /* Receive/send statistics. */ |
8019 | if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) { | 8029 | if (tp->tg3_flags2 & TG3_FLG2_5750_PLUS) { |
8020 | val = tr32(RCVLPC_STATS_ENABLE); | 8030 | val = tr32(RCVLPC_STATS_ENABLE); |
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h index 4937bd190964..783cd77b6165 100644 --- a/drivers/net/tg3.h +++ b/drivers/net/tg3.h | |||
@@ -1302,7 +1302,11 @@ | |||
1302 | #define RDMAC_STATUS_FIFOURUN 0x00000080 | 1302 | #define RDMAC_STATUS_FIFOURUN 0x00000080 |
1303 | #define RDMAC_STATUS_FIFOOREAD 0x00000100 | 1303 | #define RDMAC_STATUS_FIFOOREAD 0x00000100 |
1304 | #define RDMAC_STATUS_LNGREAD 0x00000200 | 1304 | #define RDMAC_STATUS_LNGREAD 0x00000200 |
1305 | /* 0x4808 --> 0x4c00 unused */ | 1305 | /* 0x4808 --> 0x4900 unused */ |
1306 | |||
1307 | #define TG3_RDMA_RSRVCTRL_REG 0x00004900 | ||
1308 | #define TG3_RDMA_RSRVCTRL_FIFO_OFLW_FIX 0x00000004 | ||
1309 | /* 0x4904 --> 0x4c00 unused */ | ||
1306 | 1310 | ||
1307 | /* Write DMA control registers */ | 1311 | /* Write DMA control registers */ |
1308 | #define WDMAC_MODE 0x00004c00 | 1312 | #define WDMAC_MODE 0x00004c00 |