aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2012-09-04 17:06:55 -0400
committerDavid S. Miller <davem@davemloft.net>2012-09-05 17:49:27 -0400
commit7933aa5c75b880aad6fc26f2df1e3ee6c14f166d (patch)
treeb71ea61dc582e5f4784bfe43501dbd23afbeaf02 /drivers/net
parent2c9693222952b08c224093a1263cb5aee02d10ff (diff)
bnx2x: use list_move_tail instead of list_del/list_add_tail
Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 62f754bd0dfe..5a5fbf57c4b4 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -229,8 +229,7 @@ static inline int bnx2x_exe_queue_step(struct bnx2x *bp,
229 */ 229 */
230 list_add_tail(&spacer.link, &o->pending_comp); 230 list_add_tail(&spacer.link, &o->pending_comp);
231 mb(); 231 mb();
232 list_del(&elem->link); 232 list_move_tail(&elem->link, &o->pending_comp);
233 list_add_tail(&elem->link, &o->pending_comp);
234 list_del(&spacer.link); 233 list_del(&spacer.link);
235 } else 234 } else
236 break; 235 break;