diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 06:39:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-03 23:02:11 -0400 |
commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/yellowfin.c | |
parent | aae5e7c30fc660c50dfecbdd745799b05af90f01 (diff) |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/yellowfin.c')
-rw-r--r-- | drivers/net/yellowfin.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/yellowfin.c b/drivers/net/yellowfin.c index 4987040c414b..40ad0dee0406 100644 --- a/drivers/net/yellowfin.c +++ b/drivers/net/yellowfin.c | |||
@@ -1365,8 +1365,6 @@ static int netdev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) | |||
1365 | return 0; | 1365 | return 0; |
1366 | 1366 | ||
1367 | case SIOCSMIIREG: /* Write MII PHY register. */ | 1367 | case SIOCSMIIREG: /* Write MII PHY register. */ |
1368 | if (!capable(CAP_NET_ADMIN)) | ||
1369 | return -EPERM; | ||
1370 | if (data->phy_id == np->phys[0]) { | 1368 | if (data->phy_id == np->phys[0]) { |
1371 | u16 value = data->val_in; | 1369 | u16 value = data->val_in; |
1372 | switch (data->reg_num) { | 1370 | switch (data->reg_num) { |