diff options
author | Ivo van Doorn <ivdoorn@gmail.com> | 2008-04-03 18:01:43 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-04-08 16:44:42 -0400 |
commit | 133adf08266740cd886d544aa9fe80b9873cf699 (patch) | |
tree | c84359c4de1d8ad33caeac67de58dd817e5dfc31 /drivers/net/wireless | |
parent | 253898c4170c7f426d1bc32860fee04f27de3ade (diff) |
rt2x00: Use lib->config_filter() during scheduled packet filter config
Now rt2x00lib handles the initial configure_filter() command, we can
directly call lib->config_filter() in scheduled context since the
called function will no longer check if anything has changed (which is
now handled in rt2x00lib as well).
This fixes a endless loop with USB drivers where the config_filter
command was scheduled time and time again without sending any command
to the device.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless')
-rw-r--r-- | drivers/net/wireless/rt2x00/rt2x00dev.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c index 50ea7bd0c922..0361524d193c 100644 --- a/drivers/net/wireless/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c | |||
@@ -404,18 +404,8 @@ static void rt2x00lib_packetfilter_scheduled(struct work_struct *work) | |||
404 | { | 404 | { |
405 | struct rt2x00_dev *rt2x00dev = | 405 | struct rt2x00_dev *rt2x00dev = |
406 | container_of(work, struct rt2x00_dev, filter_work); | 406 | container_of(work, struct rt2x00_dev, filter_work); |
407 | unsigned int filter = rt2x00dev->packet_filter; | ||
408 | 407 | ||
409 | /* | 408 | rt2x00dev->ops->lib->config_filter(rt2x00dev, rt2x00dev->packet_filter); |
410 | * Since we had stored the filter inside rt2x00dev->packet_filter, | ||
411 | * we should now clear that field. Otherwise the driver will | ||
412 | * assume nothing has changed (*total_flags will be compared | ||
413 | * to rt2x00dev->packet_filter to determine if any action is required). | ||
414 | */ | ||
415 | rt2x00dev->packet_filter = 0; | ||
416 | |||
417 | rt2x00dev->ops->hw->configure_filter(rt2x00dev->hw, | ||
418 | filter, &filter, 0, NULL); | ||
419 | } | 409 | } |
420 | 410 | ||
421 | static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac, | 411 | static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac, |