net: convert remaining non-symbolic return values in ndo_start_xmit() functions

This patch converts the remaining occurences of raw return values to their
symbolic counterparts in ndo_start_xmit() functions that were missed by the
previous automatic conversion.

Additionally code that assumed the symbolic value of NETDEV_TX_OK to be zero
is changed to explicitly use NETDEV_TX_OK.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

6 files changed, 28 insertions, 29 deletions

diff --git a/drivers/net/wireless/hostap/hostap_80211_tx.c b/drivers/net/wireless/hostap/hostap_80211_tx.c
index d313b005114e..1fe1bbabb907 100644
--- a/drivers/net/wireless/hostap/hostap_80211_tx.c
+++ b/drivers/net/wireless/hostap/hostap_80211_tx.c
@@ -75,7 +75,7 @@ int hostap_data_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 printk(KERN_DEBUG "%s: hostap_data_start_xmit: short skb "
                        "(len=%d)\n", dev->name, skb->len);
                 kfree_skb(skb);
-                return 0;
+                return NETDEV_TX_OK;
         }
 
         if (local->ddev != dev) {
@@ -89,14 +89,14 @@ int hostap_data_start_xmit(struct sk_buff *skb, struct net_device *dev)
                         printk(KERN_DEBUG "%s: prism2_tx: trying to use "
                                "AP device with Ethernet net dev\n", dev->name);
                         kfree_skb(skb);
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
         } else {
                 if (local->iw_mode == IW_MODE_REPEAT) {
                         printk(KERN_DEBUG "%s: prism2_tx: trying to use "
                                "non-WDS link in Repeater mode\n", dev->name);
                         kfree_skb(skb);
-                        return 0;
+                        return NETDEV_TX_OK;
                 } else if (local->iw_mode == IW_MODE_INFRA &&
                            (local->wds_type & HOSTAP_WDS_AP_CLIENT) &&
                            memcmp(skb->data + ETH_ALEN, dev->dev_addr,
@@ -210,13 +210,13 @@ int hostap_data_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 skb = skb_unshare(skb, GFP_ATOMIC);
                 if (skb == NULL) {
                         iface->stats.tx_dropped++;
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
                 if (pskb_expand_head(skb, need_headroom, need_tailroom,
                                      GFP_ATOMIC)) {
                         kfree_skb(skb);
                         iface->stats.tx_dropped++;
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
         } else if (skb_headroom(skb) < need_headroom) {
                 struct sk_buff *tmp = skb;
@@ -224,13 +224,13 @@ int hostap_data_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 kfree_skb(tmp);
                 if (skb == NULL) {
                         iface->stats.tx_dropped++;
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
         } else {
                 skb = skb_unshare(skb, GFP_ATOMIC);
                 if (skb == NULL) {
                         iface->stats.tx_dropped++;
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
         }
 
@@ -256,7 +256,7 @@ int hostap_data_start_xmit(struct sk_buff *skb, struct net_device *dev)
         /* Send IEEE 802.11 encapsulated frame using the master radio device */
         skb->dev = local->dev;
         dev_queue_xmit(skb);
-        return 0;
+        return NETDEV_TX_OK;
 }
 
 
@@ -276,7 +276,7 @@ int hostap_mgmt_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 printk(KERN_DEBUG "%s: hostap_mgmt_start_xmit: short skb "
                        "(len=%d)\n", dev->name, skb->len);
                 kfree_skb(skb);
-                return 0;
+                return NETDEV_TX_OK;
         }
 
         iface->stats.tx_packets++;
@@ -301,7 +301,7 @@ int hostap_mgmt_start_xmit(struct sk_buff *skb, struct net_device *dev)
         /* Send IEEE 802.11 encapsulated frame using the master radio device */
         skb->dev = local->dev;
         dev_queue_xmit(skb);
-        return 0;
+        return NETDEV_TX_OK;
 }
 
 
@@ -396,7 +396,7 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 printk(KERN_DEBUG "%s: invalid skb->cb magic (0x%08x, "
                        "expected 0x%08x)\n",
                        dev->name, meta->magic, HOSTAP_SKB_TX_DATA_MAGIC);
-                ret = 0;
+                ret = NETDEV_TX_OK;
                 iface->stats.tx_dropped++;
                 goto fail;
         }
@@ -414,7 +414,7 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
         if (skb->len < 24) {
                 printk(KERN_DEBUG "%s: hostap_master_start_xmit: short skb "
                        "(len=%d)\n", dev->name, skb->len);
-                ret = 0;
+                ret = NETDEV_TX_OK;
                 iface->stats.tx_dropped++;
                 goto fail;
         }
@@ -441,13 +441,13 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
                                dev->name, meta->ethertype);
                         hostap_dump_tx_80211(dev->name, skb);
 
-                        ret = 0; /* drop packet */
+                        ret = NETDEV_TX_OK; /* drop packet */
                         iface->stats.tx_dropped++;
                         goto fail;
                 }
                 break;
         case AP_TX_DROP:
-                ret = 0; /* drop packet */
+                ret = NETDEV_TX_OK; /* drop packet */
                 iface->stats.tx_dropped++;
                 goto fail;
         case AP_TX_RETRY:
@@ -455,7 +455,7 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
         case AP_TX_BUFFERED:
                 /* do not free skb here, it will be freed when the
                  * buffered frame is sent/timed out */
-                ret = 0;
+                ret = NETDEV_TX_OK;
                 goto tx_exit;
         }
 
@@ -501,7 +501,7 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
                                "frame (drop_unencrypted=1)\n", dev->name);
                 }
                 iface->stats.tx_dropped++;
-                ret = 0;
+                ret = NETDEV_TX_OK;
                 goto fail;
         }
 
@@ -510,7 +510,7 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
                 if (skb == NULL) {
                         printk(KERN_DEBUG "%s: TX - encryption failed\n",
                                dev->name);
-                        ret = 0;
+                        ret = NETDEV_TX_OK;
                         goto fail;
                 }
                 meta = (struct hostap_skb_tx_data *) skb->cb;
@@ -519,23 +519,23 @@ int hostap_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
                                "expected 0x%08x) after hostap_tx_encrypt\n",
                                dev->name, meta->magic,
                                HOSTAP_SKB_TX_DATA_MAGIC);
-                        ret = 0;
+                        ret = NETDEV_TX_OK;
                         iface->stats.tx_dropped++;
                         goto fail;
                 }
         }
 
         if (local->func->tx == NULL || local->func->tx(skb, dev)) {
-                ret = 0;
+                ret = NETDEV_TX_OK;
                 iface->stats.tx_dropped++;
         } else {
-                ret = 0;
+                ret = NETDEV_TX_OK;
                 iface->stats.tx_packets++;
                 iface->stats.tx_bytes += skb->len;
         }
 
  fail:
-        if (!ret && skb)
+        if (ret == NETDEV_TX_OK && skb)
                 dev_kfree_skb(skb);
  tx_exit:
         if (tx.sta_ptr)
diff --git a/drivers/net/wireless/ipw2x00/libipw_tx.c b/drivers/net/wireless/ipw2x00/libipw_tx.c
index da2ad5437ce5..2e8f84fb29fa 100644
--- a/drivers/net/wireless/ipw2x00/libipw_tx.c
+++ b/drivers/net/wireless/ipw2x00/libipw_tx.c
@@ -527,13 +527,13 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
                 if (ret == 0) {
                         dev->stats.tx_packets++;
                         dev->stats.tx_bytes += txb->payload_size;
-                        return 0;
+                        return NETDEV_TX_OK;
                 }
 
                 ieee80211_txb_free(txb);
         }
 
-        return 0;
+        return NETDEV_TX_OK;
 
       failed:
         spin_unlock_irqrestore(&ieee->lock, flags);
diff --git a/drivers/net/wireless/prism54/islpci_eth.c b/drivers/net/wireless/prism54/islpci_eth.c
index 8f6210993448..c255d9c6a5f1 100644
--- a/drivers/net/wireless/prism54/islpci_eth.c
+++ b/drivers/net/wireless/prism54/islpci_eth.c
@@ -234,7 +234,7 @@ islpci_eth_transmit(struct sk_buff *skb, struct net_device *ndev)
         /* unlock the driver code */
         spin_unlock_irqrestore(&priv->slock, flags);
 
-        return 0;
+        return NETDEV_TX_OK;
 
       drop_free:
         ndev->stats.tx_dropped++;
diff --git a/drivers/net/wireless/wavelan.c b/drivers/net/wireless/wavelan.c
index ab7fc5c0c8b4..5cb5329a20d1 100644
--- a/drivers/net/wireless/wavelan.c
+++ b/drivers/net/wireless/wavelan.c
@@ -2891,7 +2891,7 @@ static int wavelan_packet_xmit(struct sk_buff *skb, struct net_device * dev)
 #ifdef DEBUG_TX_TRACE
         printk(KERN_DEBUG "%s: <-wavelan_packet_xmit()\n", dev->name);
 #endif
-        return 0;
+        return NETDEV_TX_OK;
 }
 
 /*********************** HARDWARE CONFIGURATION ***********************/
diff --git a/drivers/net/wireless/wavelan_cs.c b/drivers/net/wireless/wavelan_cs.c
index 6af706408ac0..9dd241adc379 100644
--- a/drivers/net/wireless/wavelan_cs.c
+++ b/drivers/net/wireless/wavelan_cs.c
@@ -3113,7 +3113,7 @@ wavelan_packet_xmit(struct sk_buff *	skb,
          * able to detect collisions, therefore in theory we don't really
          * need to pad. Jean II */
         if (skb_padto(skb, ETH_ZLEN))
-                return 0;
+                return NETDEV_TX_OK;
 
   wv_packet_write(dev, skb->data, skb->len);
 
@@ -3122,7 +3122,7 @@ wavelan_packet_xmit(struct sk_buff *	skb,
 #ifdef DEBUG_TX_TRACE
   printk(KERN_DEBUG "%s: <-wavelan_packet_xmit()\n", dev->name);
 #endif
-  return(0);
+  return NETDEV_TX_OK;
 }
 
 /********************** HARDWARE CONFIGURATION **********************/
diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c
index e3e96bb2c246..a83a5621ec44 100644
--- a/drivers/net/wireless/wl3501_cs.c
+++ b/drivers/net/wireless/wl3501_cs.c
@@ -1348,7 +1348,6 @@ static int wl3501_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
         if (rc) {
                 ++dev->stats.tx_dropped;
                 netif_stop_queue(dev);
-                rc = NETDEV_TX_OK;
         } else {
                 ++dev->stats.tx_packets;
                 dev->stats.tx_bytes += skb->len;
@@ -1358,7 +1357,7 @@ static int wl3501_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
                         netif_stop_queue(dev);
         }
         spin_unlock_irqrestore(&this->lock, flags);
-        return rc;
+        return NETDEV_TX_OK;
 }
 
 static int wl3501_open(struct net_device *dev)