aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless
diff options
context:
space:
mode:
authorReinette Chatre <reinette.chatre@intel.com>2009-02-13 14:51:19 -0500
committerJohn W. Linville <linville@tuxdriver.com>2009-02-27 14:52:35 -0500
commit80bc53931bdf8284c5a95ba96d86ab6c2473a5f8 (patch)
treef5aa14d81145763e9044ac8e1154c536201ac90d /drivers/net/wireless
parentd21050c7bedaf4ee94c3b1b1ab7129a849bbf620 (diff)
iwlwifi: Fix and rework Kconfig file
Fixes: - iwlwifi is an optional driver and should thus not default to 'y'. - 3945 now depends on IWLCORE. Rework: - There is not a case when IWLCORE should not be selected. At the same time the driver does not use IWLWIFI or IWLCORE. We can just merge the usage of these two. With IWLWIFI being the driver name we proceed to use just it and replace instances of IWLCORE with it. The module name does not change and is still iwlcore. - Both IWLAGN and IWL3945 are selecting FW_LOADER, we can thus just move this up to one select when IWLWIFI is selected. - IWL5000 now supports Intel Wireless Wifi 100, 6000, and 6050 series. - Now that 3945 depends on IWLWIFI we can also indicate its dependency on MAC80211_LEDS and LEDS_CLASS at this level. - IWLAGN_LEDS is not used by driver - remove it. - IWLAGN_SPECTRUM_MEASUREMENT actually depends on IWLWIFI as it forms part of iwlcore module. Move this config up in Kconfig to reflect that and also change name to IWLWIFI_SPECTRUM_MEASUREMENT. - CONFIG_IWLWIFI_RFKILL is used by iwlagn as well as iwl3945, add text to description that indicates this. - CONFIG_IWL3945_RFKILL does not exist - remove usage from driver. - Add "iwlagn" to end of description of IWLAGN to help people understand what iwlagn means in rest of Kconfig text. - Add "iwl3945" to end of description of IWL3945 to help people understand what iwlagn means in rest of Kconfig text. - Change IWLWIFI_DEBUGFS description to indicate that only iwlagn supports it (for now). Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reported-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless')
-rw-r--r--drivers/net/wireless/iwlwifi/Kconfig56
-rw-r--r--drivers/net/wireless/iwlwifi/Makefile4
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn.c2
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-core.h2
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-dev.h4
5 files changed, 26 insertions, 42 deletions
diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index 7b3bad1796c7..6cc5a54d35c5 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -1,27 +1,31 @@
1config IWLWIFI 1config IWLWIFI
2 bool "Intel Wireless Wifi" 2 tristate "Intel Wireless Wifi"
3 depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL 3 depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL
4 default y
5
6config IWLCORE
7 tristate "Intel Wireless Wifi Core"
8 depends on IWLWIFI
9 select LIB80211 4 select LIB80211
5 select FW_LOADER
10 select MAC80211_LEDS if IWLWIFI_LEDS 6 select MAC80211_LEDS if IWLWIFI_LEDS
11 select LEDS_CLASS if IWLWIFI_LEDS 7 select LEDS_CLASS if IWLWIFI_LEDS
12 select RFKILL if IWLWIFI_RFKILL 8 select RFKILL if IWLWIFI_RFKILL
9 select MAC80211_LEDS if IWL3945_LEDS
10 select LEDS_CLASS if IWL3945_LEDS
13 11
14config IWLWIFI_LEDS 12config IWLWIFI_LEDS
15 bool "Enable LED support in iwlagn driver" 13 bool "Enable LED support in iwlagn driver"
16 depends on IWLCORE 14 depends on IWLWIFI
17 15
18config IWLWIFI_RFKILL 16config IWLWIFI_RFKILL
19 bool "Enable RF kill support in iwlagn driver" 17 bool "Enable RF kill support in iwlagn and iwl3945 drivers"
20 depends on IWLCORE 18 depends on IWLWIFI
19
20config IWLWIFI_SPECTRUM_MEASUREMENT
21 bool "Enable Spectrum Measurement in iwlagn driver"
22 depends on IWLWIFI
23 ---help---
24 This option will enable spectrum measurement for the iwlagn driver.
21 25
22config IWLWIFI_DEBUG 26config IWLWIFI_DEBUG
23 bool "Enable full debugging output in iwlagn and iwl3945 drivers" 27 bool "Enable full debugging output in iwlagn and iwl3945 drivers"
24 depends on IWLCORE 28 depends on IWLWIFI
25 ---help--- 29 ---help---
26 This option will enable debug tracing output for the iwlwifi drivers 30 This option will enable debug tracing output for the iwlwifi drivers
27 31
@@ -45,16 +49,14 @@ config IWLWIFI_DEBUG
45 any problems you may encounter. 49 any problems you may encounter.
46 50
47config IWLWIFI_DEBUGFS 51config IWLWIFI_DEBUGFS
48 bool "Iwlwifi debugfs support" 52 bool "iwlagn debugfs support"
49 depends on IWLCORE && IWLWIFI_DEBUG && MAC80211_DEBUGFS 53 depends on IWLWIFI && IWLWIFI_DEBUG && MAC80211_DEBUGFS
50 ---help--- 54 ---help---
51 Enable creation of debugfs files for the iwlwifi drivers. 55 Enable creation of debugfs files for the iwlwifi drivers.
52 56
53config IWLAGN 57config IWLAGN
54 tristate "Intel Wireless WiFi Next Gen AGN" 58 tristate "Intel Wireless WiFi Next Gen AGN (iwlagn)"
55 depends on IWLWIFI 59 depends on IWLWIFI
56 select FW_LOADER
57 select IWLCORE
58 ---help--- 60 ---help---
59 Select to build the driver supporting the: 61 Select to build the driver supporting the:
60 62
@@ -77,19 +79,6 @@ config IWLAGN
77 say M here and read <file:Documentation/kbuild/modules.txt>. The 79 say M here and read <file:Documentation/kbuild/modules.txt>. The
78 module will be called iwlagn.ko. 80 module will be called iwlagn.ko.
79 81
80config IWLAGN_SPECTRUM_MEASUREMENT
81 bool "Enable Spectrum Measurement in iwlagn driver"
82 depends on IWLAGN
83 ---help---
84 This option will enable spectrum measurement for the iwlagn driver.
85
86config IWLAGN_LEDS
87 bool "Enable LEDS features in iwlagn driver"
88 depends on IWLAGN
89 select IWLWIFI_LEDS
90 ---help---
91 This option enables LEDS for the iwlagn drivers
92
93 82
94config IWL4965 83config IWL4965
95 bool "Intel Wireless WiFi 4965AGN" 84 bool "Intel Wireless WiFi 4965AGN"
@@ -98,19 +87,14 @@ config IWL4965
98 This option enables support for Intel Wireless WiFi Link 4965AGN 87 This option enables support for Intel Wireless WiFi Link 4965AGN
99 88
100config IWL5000 89config IWL5000
101 bool "Intel Wireless WiFi 5000AGN" 90 bool "Intel Wireless WiFi 5000AGN; Intel WiFi Link 100, 6000, and 6050 Series"
102 depends on IWLAGN 91 depends on IWLAGN
103 ---help--- 92 ---help---
104 This option enables support for Intel Wireless WiFi Link 5000AGN Family 93 This option enables support for Intel Wireless WiFi Link 5000AGN Family
105 94
106config IWL3945 95config IWL3945
107 tristate "Intel PRO/Wireless 3945ABG/BG Network Connection" 96 tristate "Intel PRO/Wireless 3945ABG/BG Network Connection (iwl3945)"
108 depends on IWLWIFI 97 depends on IWLWIFI
109 select FW_LOADER
110 select LIB80211
111 select MAC80211_LEDS if IWL3945_LEDS
112 select LEDS_CLASS if IWL3945_LEDS
113 select RFKILL if IWLWIFI_RFKILL
114 ---help--- 98 ---help---
115 Select to build the driver supporting the: 99 Select to build the driver supporting the:
116 100
@@ -134,7 +118,7 @@ config IWL3945
134 module will be called iwl3945.ko. 118 module will be called iwl3945.ko.
135 119
136config IWL3945_SPECTRUM_MEASUREMENT 120config IWL3945_SPECTRUM_MEASUREMENT
137 bool "Enable Spectrum Measurement in iwl3945 drivers" 121 bool "Enable Spectrum Measurement in iwl3945 driver"
138 depends on IWL3945 122 depends on IWL3945
139 ---help--- 123 ---help---
140 This option will enable spectrum measurement for the iwl3945 driver. 124 This option will enable spectrum measurement for the iwl3945 driver.
diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile
index ddc8b31b2608..48af523ceab7 100644
--- a/drivers/net/wireless/iwlwifi/Makefile
+++ b/drivers/net/wireless/iwlwifi/Makefile
@@ -1,11 +1,11 @@
1obj-$(CONFIG_IWLCORE) += iwlcore.o 1obj-$(CONFIG_IWLWIFI) += iwlcore.o
2iwlcore-objs := iwl-core.o iwl-eeprom.o iwl-hcmd.o iwl-power.o 2iwlcore-objs := iwl-core.o iwl-eeprom.o iwl-hcmd.o iwl-power.o
3iwlcore-objs += iwl-rx.o iwl-tx.o iwl-sta.o iwl-calib.o 3iwlcore-objs += iwl-rx.o iwl-tx.o iwl-sta.o iwl-calib.o
4iwlcore-objs += iwl-scan.o 4iwlcore-objs += iwl-scan.o
5iwlcore-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-debugfs.o 5iwlcore-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-debugfs.o
6iwlcore-$(CONFIG_IWLWIFI_LEDS) += iwl-led.o 6iwlcore-$(CONFIG_IWLWIFI_LEDS) += iwl-led.o
7iwlcore-$(CONFIG_IWLWIFI_RFKILL) += iwl-rfkill.o 7iwlcore-$(CONFIG_IWLWIFI_RFKILL) += iwl-rfkill.o
8iwlcore-$(CONFIG_IWLAGN_SPECTRUM_MEASUREMENT) += iwl-spectrum.o 8iwlcore-$(CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT) += iwl-spectrum.o
9 9
10obj-$(CONFIG_IWLAGN) += iwlagn.o 10obj-$(CONFIG_IWLAGN) += iwlagn.o
11iwlagn-objs := iwl-agn.o iwl-agn-rs.o 11iwlagn-objs := iwl-agn.o iwl-agn-rs.o
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 6e4dba1ed0e0..50f8c7f47061 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -72,7 +72,7 @@
72#define VD 72#define VD
73#endif 73#endif
74 74
75#ifdef CONFIG_IWLAGN_SPECTRUM_MEASUREMENT 75#ifdef CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT
76#define VS "s" 76#define VS "s"
77#else 77#else
78#define VS 78#define VS
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.h b/drivers/net/wireless/iwlwifi/iwl-core.h
index 9d464ec99dd5..10ee20c8b53d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.h
+++ b/drivers/net/wireless/iwlwifi/iwl-core.h
@@ -379,7 +379,7 @@ void iwl_calib_free_results(struct iwl_priv *priv);
379/******************************************************************************* 379/*******************************************************************************
380 * Spectrum Measureemtns in iwl-spectrum.c 380 * Spectrum Measureemtns in iwl-spectrum.c
381 ******************************************************************************/ 381 ******************************************************************************/
382#ifdef CONFIG_IWLAGN_SPECTRUM_MEASUREMENT 382#ifdef CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT
383void iwl_setup_spectrum_handlers(struct iwl_priv *priv); 383void iwl_setup_spectrum_handlers(struct iwl_priv *priv);
384#else 384#else
385static inline void iwl_setup_spectrum_handlers(struct iwl_priv *priv) {} 385static inline void iwl_setup_spectrum_handlers(struct iwl_priv *priv) {}
diff --git a/drivers/net/wireless/iwlwifi/iwl-dev.h b/drivers/net/wireless/iwlwifi/iwl-dev.h
index afde713c806f..b3e23abb9117 100644
--- a/drivers/net/wireless/iwlwifi/iwl-dev.h
+++ b/drivers/net/wireless/iwlwifi/iwl-dev.h
@@ -841,7 +841,7 @@ struct iwl_priv {
841 841
842 struct ieee80211_supported_band bands[IEEE80211_NUM_BANDS]; 842 struct ieee80211_supported_band bands[IEEE80211_NUM_BANDS];
843 843
844#if defined(CONFIG_IWLAGN_SPECTRUM_MEASUREMENT) || defined(CONFIG_IWL3945_SPECTRUM_MEASUREMENT) 844#if defined(CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT) || defined(CONFIG_IWL3945_SPECTRUM_MEASUREMENT)
845 /* spectrum measurement report caching */ 845 /* spectrum measurement report caching */
846 struct iwl_spectrum_notification measure_report; 846 struct iwl_spectrum_notification measure_report;
847 u8 measurement_status; 847 u8 measurement_status;
@@ -922,7 +922,7 @@ struct iwl_priv {
922 * 4965's initialize alive response contains some calibration data. */ 922 * 4965's initialize alive response contains some calibration data. */
923 struct iwl_init_alive_resp card_alive_init; 923 struct iwl_init_alive_resp card_alive_init;
924 struct iwl_alive_resp card_alive; 924 struct iwl_alive_resp card_alive;
925#if defined(CONFIG_IWLWIFI_RFKILL) || defined(CONFIG_IWL3945_RFKILL) 925#if defined(CONFIG_IWLWIFI_RFKILL)
926 struct rfkill *rfkill; 926 struct rfkill *rfkill;
927#endif 927#endif
928 928