diff options
author | Ulrich Kunitz <kune@deine-taler.de> | 2007-02-18 15:28:23 -0500 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-04-28 11:00:54 -0400 |
commit | 35c3404efa7407811b706453f83d39b2539dcbd0 (patch) | |
tree | db3d0e9b9211fc1aa1694db024c0994b28e92ecb /drivers/net/wireless/zd1211rw | |
parent | 375dd24428cfe900f4ed95d301fe604f8e0d459b (diff) |
[PATCH] zd1211rw: changed GFP_NOFS to GFP_KERNEL
Michael Buesch commented that GFP_NOFS should not be used in a
network driver.
Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
Signed-off-by: Daniel Drake <dsd@gentoo.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/zd1211rw')
-rw-r--r-- | drivers/net/wireless/zd1211rw/zd_chip.c | 4 | ||||
-rw-r--r-- | drivers/net/wireless/zd1211rw/zd_usb.c | 20 |
2 files changed, 12 insertions, 12 deletions
diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c index 87ee3ee020fe..680a1781a74c 100644 --- a/drivers/net/wireless/zd1211rw/zd_chip.c +++ b/drivers/net/wireless/zd1211rw/zd_chip.c | |||
@@ -114,7 +114,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr | |||
114 | /* Allocate a single memory block for values and addresses. */ | 114 | /* Allocate a single memory block for values and addresses. */ |
115 | count16 = 2*count; | 115 | count16 = 2*count; |
116 | a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), | 116 | a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), |
117 | GFP_NOFS); | 117 | GFP_KERNEL); |
118 | if (!a16) { | 118 | if (!a16) { |
119 | dev_dbg_f(zd_chip_dev(chip), | 119 | dev_dbg_f(zd_chip_dev(chip), |
120 | "error ENOMEM in allocation of a16\n"); | 120 | "error ENOMEM in allocation of a16\n"); |
@@ -163,7 +163,7 @@ int _zd_iowrite32v_locked(struct zd_chip *chip, const struct zd_ioreq32 *ioreqs, | |||
163 | 163 | ||
164 | /* Allocate a single memory block for values and addresses. */ | 164 | /* Allocate a single memory block for values and addresses. */ |
165 | count16 = 2*count; | 165 | count16 = 2*count; |
166 | ioreqs16 = kmalloc(count16 * sizeof(struct zd_ioreq16), GFP_NOFS); | 166 | ioreqs16 = kmalloc(count16 * sizeof(struct zd_ioreq16), GFP_KERNEL); |
167 | if (!ioreqs16) { | 167 | if (!ioreqs16) { |
168 | r = -ENOMEM; | 168 | r = -ENOMEM; |
169 | dev_dbg_f(zd_chip_dev(chip), | 169 | dev_dbg_f(zd_chip_dev(chip), |
diff --git a/drivers/net/wireless/zd1211rw/zd_usb.c b/drivers/net/wireless/zd1211rw/zd_usb.c index edaaad2f648b..30703b3632ed 100644 --- a/drivers/net/wireless/zd1211rw/zd_usb.c +++ b/drivers/net/wireless/zd1211rw/zd_usb.c | |||
@@ -413,7 +413,7 @@ int zd_usb_enable_int(struct zd_usb *usb) | |||
413 | 413 | ||
414 | dev_dbg_f(zd_usb_dev(usb), "\n"); | 414 | dev_dbg_f(zd_usb_dev(usb), "\n"); |
415 | 415 | ||
416 | urb = usb_alloc_urb(0, GFP_NOFS); | 416 | urb = usb_alloc_urb(0, GFP_KERNEL); |
417 | if (!urb) { | 417 | if (!urb) { |
418 | r = -ENOMEM; | 418 | r = -ENOMEM; |
419 | goto out; | 419 | goto out; |
@@ -431,7 +431,7 @@ int zd_usb_enable_int(struct zd_usb *usb) | |||
431 | 431 | ||
432 | /* TODO: make it a DMA buffer */ | 432 | /* TODO: make it a DMA buffer */ |
433 | r = -ENOMEM; | 433 | r = -ENOMEM; |
434 | transfer_buffer = kmalloc(USB_MAX_EP_INT_BUFFER, GFP_NOFS); | 434 | transfer_buffer = kmalloc(USB_MAX_EP_INT_BUFFER, GFP_KERNEL); |
435 | if (!transfer_buffer) { | 435 | if (!transfer_buffer) { |
436 | dev_dbg_f(zd_usb_dev(usb), | 436 | dev_dbg_f(zd_usb_dev(usb), |
437 | "couldn't allocate transfer_buffer\n"); | 437 | "couldn't allocate transfer_buffer\n"); |
@@ -445,7 +445,7 @@ int zd_usb_enable_int(struct zd_usb *usb) | |||
445 | intr->interval); | 445 | intr->interval); |
446 | 446 | ||
447 | dev_dbg_f(zd_usb_dev(usb), "submit urb %p\n", intr->urb); | 447 | dev_dbg_f(zd_usb_dev(usb), "submit urb %p\n", intr->urb); |
448 | r = usb_submit_urb(urb, GFP_NOFS); | 448 | r = usb_submit_urb(urb, GFP_KERNEL); |
449 | if (r) { | 449 | if (r) { |
450 | dev_dbg_f(zd_usb_dev(usb), | 450 | dev_dbg_f(zd_usb_dev(usb), |
451 | "Couldn't submit urb. Error number %d\n", r); | 451 | "Couldn't submit urb. Error number %d\n", r); |
@@ -594,10 +594,10 @@ static struct urb *alloc_urb(struct zd_usb *usb) | |||
594 | struct urb *urb; | 594 | struct urb *urb; |
595 | void *buffer; | 595 | void *buffer; |
596 | 596 | ||
597 | urb = usb_alloc_urb(0, GFP_NOFS); | 597 | urb = usb_alloc_urb(0, GFP_KERNEL); |
598 | if (!urb) | 598 | if (!urb) |
599 | return NULL; | 599 | return NULL; |
600 | buffer = usb_buffer_alloc(udev, USB_MAX_RX_SIZE, GFP_NOFS, | 600 | buffer = usb_buffer_alloc(udev, USB_MAX_RX_SIZE, GFP_KERNEL, |
601 | &urb->transfer_dma); | 601 | &urb->transfer_dma); |
602 | if (!buffer) { | 602 | if (!buffer) { |
603 | usb_free_urb(urb); | 603 | usb_free_urb(urb); |
@@ -630,7 +630,7 @@ int zd_usb_enable_rx(struct zd_usb *usb) | |||
630 | dev_dbg_f(zd_usb_dev(usb), "\n"); | 630 | dev_dbg_f(zd_usb_dev(usb), "\n"); |
631 | 631 | ||
632 | r = -ENOMEM; | 632 | r = -ENOMEM; |
633 | urbs = kcalloc(URBS_COUNT, sizeof(struct urb *), GFP_NOFS); | 633 | urbs = kcalloc(URBS_COUNT, sizeof(struct urb *), GFP_KERNEL); |
634 | if (!urbs) | 634 | if (!urbs) |
635 | goto error; | 635 | goto error; |
636 | for (i = 0; i < URBS_COUNT; i++) { | 636 | for (i = 0; i < URBS_COUNT; i++) { |
@@ -651,7 +651,7 @@ int zd_usb_enable_rx(struct zd_usb *usb) | |||
651 | spin_unlock_irq(&rx->lock); | 651 | spin_unlock_irq(&rx->lock); |
652 | 652 | ||
653 | for (i = 0; i < URBS_COUNT; i++) { | 653 | for (i = 0; i < URBS_COUNT; i++) { |
654 | r = usb_submit_urb(urbs[i], GFP_NOFS); | 654 | r = usb_submit_urb(urbs[i], GFP_KERNEL); |
655 | if (r) | 655 | if (r) |
656 | goto error_submit; | 656 | goto error_submit; |
657 | } | 657 | } |
@@ -1157,7 +1157,7 @@ int zd_usb_ioread16v(struct zd_usb *usb, u16 *values, | |||
1157 | } | 1157 | } |
1158 | 1158 | ||
1159 | req_len = sizeof(struct usb_req_read_regs) + count * sizeof(__le16); | 1159 | req_len = sizeof(struct usb_req_read_regs) + count * sizeof(__le16); |
1160 | req = kmalloc(req_len, GFP_NOFS); | 1160 | req = kmalloc(req_len, GFP_KERNEL); |
1161 | if (!req) | 1161 | if (!req) |
1162 | return -ENOMEM; | 1162 | return -ENOMEM; |
1163 | req->id = cpu_to_le16(USB_REQ_READ_REGS); | 1163 | req->id = cpu_to_le16(USB_REQ_READ_REGS); |
@@ -1220,7 +1220,7 @@ int zd_usb_iowrite16v(struct zd_usb *usb, const struct zd_ioreq16 *ioreqs, | |||
1220 | 1220 | ||
1221 | req_len = sizeof(struct usb_req_write_regs) + | 1221 | req_len = sizeof(struct usb_req_write_regs) + |
1222 | count * sizeof(struct reg_data); | 1222 | count * sizeof(struct reg_data); |
1223 | req = kmalloc(req_len, GFP_NOFS); | 1223 | req = kmalloc(req_len, GFP_KERNEL); |
1224 | if (!req) | 1224 | if (!req) |
1225 | return -ENOMEM; | 1225 | return -ENOMEM; |
1226 | 1226 | ||
@@ -1300,7 +1300,7 @@ int zd_usb_rfwrite(struct zd_usb *usb, u32 value, u8 bits) | |||
1300 | bit_value_template &= ~(RF_IF_LE|RF_CLK|RF_DATA); | 1300 | bit_value_template &= ~(RF_IF_LE|RF_CLK|RF_DATA); |
1301 | 1301 | ||
1302 | req_len = sizeof(struct usb_req_rfwrite) + bits * sizeof(__le16); | 1302 | req_len = sizeof(struct usb_req_rfwrite) + bits * sizeof(__le16); |
1303 | req = kmalloc(req_len, GFP_NOFS); | 1303 | req = kmalloc(req_len, GFP_KERNEL); |
1304 | if (!req) | 1304 | if (!req) |
1305 | return -ENOMEM; | 1305 | return -ENOMEM; |
1306 | 1306 | ||