diff options
author | Juuso Oikarinen <juuso.oikarinen@nokia.com> | 2009-10-13 05:47:47 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-10-27 16:48:10 -0400 |
commit | c6d5d06e455b9965e300ae40c34fa2337e1aad0f (patch) | |
tree | 41feacb0d9f22d6f3928aaa1d46541b025adc6b3 /drivers/net/wireless/wl12xx | |
parent | 11f70f9715f0d8f99eac42d69689e8df15283fea (diff) |
wl1271: Remove busy-word checking
Remove busy-word checking to work around an SPI bug. To reduce the
chance of chipset-busy scenarios, increment the number of fixed busy
words.
Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/wl12xx')
-rw-r--r-- | drivers/net/wireless/wl12xx/wl1271.h | 6 | ||||
-rw-r--r-- | drivers/net/wireless/wl12xx/wl1271_spi.c | 6 |
2 files changed, 7 insertions, 5 deletions
diff --git a/drivers/net/wireless/wl12xx/wl1271.h b/drivers/net/wireless/wl12xx/wl1271.h index 648223f67b54..e0ebb1fb2ada 100644 --- a/drivers/net/wireless/wl12xx/wl1271.h +++ b/drivers/net/wireless/wl12xx/wl1271.h | |||
@@ -115,9 +115,11 @@ enum { | |||
115 | /* | 115 | /* |
116 | * FIXME: for the wl1271, a busy word count of 1 here will result in a more | 116 | * FIXME: for the wl1271, a busy word count of 1 here will result in a more |
117 | * optimal SPI interface. There is some SPI bug however, causing RXS time outs | 117 | * optimal SPI interface. There is some SPI bug however, causing RXS time outs |
118 | * with this mode occasionally on boot, so lets have two for now. | 118 | * with this mode occasionally on boot, so lets have three for now. A value of |
119 | * three should make sure, that the chipset will always be ready, though this | ||
120 | * will impact throughput and latencies slightly. | ||
119 | */ | 121 | */ |
120 | #define WL1271_BUSY_WORD_CNT 2 | 122 | #define WL1271_BUSY_WORD_CNT 3 |
121 | #define WL1271_BUSY_WORD_LEN (WL1271_BUSY_WORD_CNT * sizeof(u32)) | 123 | #define WL1271_BUSY_WORD_LEN (WL1271_BUSY_WORD_CNT * sizeof(u32)) |
122 | 124 | ||
123 | #define WL1271_ELP_HW_STATE_ASLEEP 0 | 125 | #define WL1271_ELP_HW_STATE_ASLEEP 0 |
diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c index 4800fdfd2373..3c5aa584574b 100644 --- a/drivers/net/wireless/wl12xx/wl1271_spi.c +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c | |||
@@ -294,9 +294,9 @@ void wl1271_spi_raw_read(struct wl1271 *wl, int addr, void *buf, | |||
294 | 294 | ||
295 | spi_sync(wl->spi, &m); | 295 | spi_sync(wl->spi, &m); |
296 | 296 | ||
297 | /* Check busy words */ | 297 | /* FIXME: Check busy words, removed due to SPI bug */ |
298 | if (!(busy_buf[WL1271_BUSY_WORD_CNT - 1] & 0x1)) | 298 | /* if (!(busy_buf[WL1271_BUSY_WORD_CNT - 1] & 0x1)) |
299 | wl1271_spi_read_busy(wl, buf, len); | 299 | wl1271_spi_read_busy(wl, buf, len); */ |
300 | 300 | ||
301 | wl1271_dump(DEBUG_SPI, "spi_read cmd -> ", cmd, sizeof(*cmd)); | 301 | wl1271_dump(DEBUG_SPI, "spi_read cmd -> ", cmd, sizeof(*cmd)); |
302 | wl1271_dump(DEBUG_SPI, "spi_read buf <- ", buf, len); | 302 | wl1271_dump(DEBUG_SPI, "spi_read buf <- ", buf, len); |