diff options
author | Luciano Coelho <luciano.coelho@nokia.com> | 2009-10-15 03:33:27 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-10-27 16:48:19 -0400 |
commit | 938e30c9301fbd7c3677d01ad01c7eb4ad78b998 (patch) | |
tree | e343b4904f32580a76edfc1e5537d9b1a4695f77 /drivers/net/wireless/wl12xx | |
parent | 7a38079e0da19447ab1c41e42094b311c6e945e4 (diff) |
wl1271: fix sparse warnings about undeclared functions
The following sparse warnings were fixed:
drivers/net/wireless/wl12xx/wl1271_spi.c:199:6: warning: symbol 'wl1271_spi_read_busy' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:84:5: warning: symbol 'wl1271_cmd_cal_channel_tune' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:107:5: warning: symbol 'wl1271_cmd_cal_update_ref_point' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:132:5: warning: symbol 'wl1271_cmd_cal_p2g' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:153:5: warning: symbol 'wl1271_cmd_cal' was not declared. Should it be static?
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Reviewed-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/wl12xx')
-rw-r--r-- | drivers/net/wireless/wl12xx/wl1271_cmd.c | 8 | ||||
-rw-r--r-- | drivers/net/wireless/wl12xx/wl1271_spi.c | 5 |
2 files changed, 8 insertions, 5 deletions
diff --git a/drivers/net/wireless/wl12xx/wl1271_cmd.c b/drivers/net/wireless/wl12xx/wl1271_cmd.c index 1d64aa47a630..195eee70e36e 100644 --- a/drivers/net/wireless/wl12xx/wl1271_cmd.c +++ b/drivers/net/wireless/wl12xx/wl1271_cmd.c | |||
@@ -81,7 +81,7 @@ out: | |||
81 | return ret; | 81 | return ret; |
82 | } | 82 | } |
83 | 83 | ||
84 | int wl1271_cmd_cal_channel_tune(struct wl1271 *wl) | 84 | static int wl1271_cmd_cal_channel_tune(struct wl1271 *wl) |
85 | { | 85 | { |
86 | struct wl1271_cmd_cal_channel_tune *cmd; | 86 | struct wl1271_cmd_cal_channel_tune *cmd; |
87 | int ret = 0; | 87 | int ret = 0; |
@@ -104,7 +104,7 @@ int wl1271_cmd_cal_channel_tune(struct wl1271 *wl) | |||
104 | return ret; | 104 | return ret; |
105 | } | 105 | } |
106 | 106 | ||
107 | int wl1271_cmd_cal_update_ref_point(struct wl1271 *wl) | 107 | static int wl1271_cmd_cal_update_ref_point(struct wl1271 *wl) |
108 | { | 108 | { |
109 | struct wl1271_cmd_cal_update_ref_point *cmd; | 109 | struct wl1271_cmd_cal_update_ref_point *cmd; |
110 | int ret = 0; | 110 | int ret = 0; |
@@ -129,7 +129,7 @@ int wl1271_cmd_cal_update_ref_point(struct wl1271 *wl) | |||
129 | return ret; | 129 | return ret; |
130 | } | 130 | } |
131 | 131 | ||
132 | int wl1271_cmd_cal_p2g(struct wl1271 *wl) | 132 | static int wl1271_cmd_cal_p2g(struct wl1271 *wl) |
133 | { | 133 | { |
134 | struct wl1271_cmd_cal_p2g *cmd; | 134 | struct wl1271_cmd_cal_p2g *cmd; |
135 | int ret = 0; | 135 | int ret = 0; |
@@ -150,7 +150,7 @@ int wl1271_cmd_cal_p2g(struct wl1271 *wl) | |||
150 | return ret; | 150 | return ret; |
151 | } | 151 | } |
152 | 152 | ||
153 | int wl1271_cmd_cal(struct wl1271 *wl) | 153 | static int wl1271_cmd_cal(struct wl1271 *wl) |
154 | { | 154 | { |
155 | /* | 155 | /* |
156 | * FIXME: we must make sure that we're not sleeping when calibration | 156 | * FIXME: we must make sure that we're not sleeping when calibration |
diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c index 3c5aa584574b..02978a16e732 100644 --- a/drivers/net/wireless/wl12xx/wl1271_spi.c +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c | |||
@@ -196,7 +196,9 @@ int wl1271_set_partition(struct wl1271 *wl, | |||
196 | 196 | ||
197 | #define WL1271_BUSY_WORD_TIMEOUT 1000 | 197 | #define WL1271_BUSY_WORD_TIMEOUT 1000 |
198 | 198 | ||
199 | void wl1271_spi_read_busy(struct wl1271 *wl, void *buf, size_t len) | 199 | /* FIXME: Check busy words, removed due to SPI bug */ |
200 | #if 0 | ||
201 | static void wl1271_spi_read_busy(struct wl1271 *wl, void *buf, size_t len) | ||
200 | { | 202 | { |
201 | struct spi_transfer t[1]; | 203 | struct spi_transfer t[1]; |
202 | struct spi_message m; | 204 | struct spi_message m; |
@@ -256,6 +258,7 @@ void wl1271_spi_read_busy(struct wl1271 *wl, void *buf, size_t len) | |||
256 | memset(buf, 0, len); | 258 | memset(buf, 0, len); |
257 | wl1271_error("SPI read busy-word timeout!\n"); | 259 | wl1271_error("SPI read busy-word timeout!\n"); |
258 | } | 260 | } |
261 | #endif | ||
259 | 262 | ||
260 | void wl1271_spi_raw_read(struct wl1271 *wl, int addr, void *buf, | 263 | void wl1271_spi_raw_read(struct wl1271 *wl, int addr, void *buf, |
261 | size_t len, bool fixed) | 264 | size_t len, bool fixed) |