aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/wl12xx/main.c
diff options
context:
space:
mode:
authorOhad Ben-Cohen <ohad@wizery.com>2011-03-30 10:35:59 -0400
committerLuciano Coelho <coelho@ti.com>2011-04-19 09:49:15 -0400
commitc5745187a4812f2991a58e469a866582a7326d91 (patch)
tree65d45fb7029a7ed72274203276fce21baf4bdf88 /drivers/net/wireless/wl12xx/main.c
parent13026decf7b74d0908df034dc6dc86c2caaec939 (diff)
wl12xx: fix roaming
The wl12xx device normally drops all frames coming from BSSID it is not joined with. This behavior is configured today by the wl12xx driver in response to a handful of ieee80211_bss_change and ieee80211_conf_changed notification flags, such as BSS_CHANGED_ASSOC, BSS_CHANGED_BSSID, IEEE80211_CONF_CHANGE_IDLE, etc.. This breaks when we roam to a new BSSID, where authentication frames are sent before any BSS_CHANGED/CONF_CHANGED flags are received. When this happens the hardware silently drops the authentication responses, and the roaming fails. Ideally this aggressive filtering behavior of the device should be disabled upon a notification from mac80211. Such notification will take place after multi-channel support will be added: mac80211 will likely send a remain-on-channel notification to drivers when entering sensitive states (like authentication), otherwise the firmware might jump to different channels (to serve a different role). Until those notifications materialize, disable the hw BSSID filter when authentication requests are sent, so roaming would work. Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com> Reviewed-by: Luciano Coelho <coelho@ti.com> Signed-off-by: Luciano Coelho <coelho@ti.com>
Diffstat (limited to 'drivers/net/wireless/wl12xx/main.c')
-rw-r--r--drivers/net/wireless/wl12xx/main.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 57d0af6cfa64..0efa7a055109 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -1528,7 +1528,7 @@ static void wl1271_op_remove_interface(struct ieee80211_hw *hw,
1528 cancel_work_sync(&wl->recovery_work); 1528 cancel_work_sync(&wl->recovery_work);
1529} 1529}
1530 1530
1531static void wl1271_configure_filters(struct wl1271 *wl, unsigned int filters) 1531void wl1271_configure_filters(struct wl1271 *wl, unsigned int filters)
1532{ 1532{
1533 wl1271_set_default_filters(wl); 1533 wl1271_set_default_filters(wl);
1534 1534
@@ -1650,7 +1650,7 @@ static int wl1271_unjoin(struct wl1271 *wl)
1650 clear_bit(WL1271_FLAG_JOINED, &wl->flags); 1650 clear_bit(WL1271_FLAG_JOINED, &wl->flags);
1651 memset(wl->bssid, 0, ETH_ALEN); 1651 memset(wl->bssid, 0, ETH_ALEN);
1652 1652
1653 /* stop filterting packets based on bssid */ 1653 /* stop filtering packets based on bssid */
1654 wl1271_configure_filters(wl, FIF_OTHER_BSS); 1654 wl1271_configure_filters(wl, FIF_OTHER_BSS);
1655 1655
1656out: 1656out: