mac80211: redefine usage of the mac80211 workqueue

The mac80211 workqueue exists to enable mac80211 and drivers
to queue their own work on a single threaded workqueue. mac80211
takes care to flush the workqueue during suspend but we never
really had requirements on drivers for how they should use
the workqueue in consideration for suspend.

We extend mac80211 to document how the mac80211 workqueue should
be used, how it should not be used and finally move raw access to
the workqueue to mac80211 only. Drivers and mac80211 use helpers
to queue work onto the mac80211 workqueue:

  * ieee80211_queue_work()
  * ieee80211_queue_delayed_work()

These helpers will now warn if mac80211 already completed its
suspend cycle and someone is trying to queue work. mac80211
flushes the mac80211 workqueue prior to suspend a few times,
but we haven't taken the care to ensure drivers won't add more
work after suspend. To help with this we add a warning when
someone tries to add work and mac80211 already completed the
suspend cycle.

Drivers should ensure they cancel any work or delayed work
in the mac80211 stop() callback.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

2 files changed, 6 insertions, 6 deletions

diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index c9b9dbe584c6..53f57dc52226 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -220,7 +220,7 @@ static void rtl8187_tx_cb(struct urb *urb)
                  * reading a register in the device. We are in interrupt mode
                  * here, thus queue the skb and finish on a work queue. */
                 skb_queue_tail(&priv->b_tx_status.queue, skb);
-                queue_delayed_work(hw->workqueue, &priv->work, 0);
+                ieee80211_queue_delayed_work(hw, &priv->work, 0);
         }
 }
 
diff --git a/drivers/net/wireless/rtl818x/rtl8187_leds.c b/drivers/net/wireless/rtl818x/rtl8187_leds.c
index cf9f899fe0e6..a6cfb7e77994 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_leds.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_leds.c
@@ -108,11 +108,11 @@ static void rtl8187_led_brightness_set(struct led_classdev *led_dev,
         struct rtl8187_priv *priv = hw->priv;
 
         if (brightness == LED_OFF) {
-                queue_delayed_work(hw->workqueue, &priv->led_off, 0);
+                ieee80211_queue_delayed_work(hw, &priv->led_off, 0);
                 /* The LED is off for 1/20 sec so that it just blinks. */
-                queue_delayed_work(hw->workqueue, &priv->led_on, HZ / 20);
+                ieee80211_queue_delayed_work(hw, &priv->led_on, HZ / 20);
         } else
-                queue_delayed_work(hw->workqueue, &priv->led_on, 0);
+                ieee80211_queue_delayed_work(hw, &priv->led_on, 0);
 }
 
 static int rtl8187_register_led(struct ieee80211_hw *dev,
@@ -193,7 +193,7 @@ void rtl8187_leds_init(struct ieee80211_hw *dev, u16 custid)
         err = rtl8187_register_led(dev, &priv->led_rx, name,
                          ieee80211_get_rx_led_name(dev), ledpin);
         if (!err) {
-                queue_delayed_work(dev->workqueue, &priv->led_on, 0);
+                ieee80211_queue_delayed_work(dev, &priv->led_on, 0);
                 return;
         }
         /* registration of RX LED failed - unregister TX */
@@ -209,7 +209,7 @@ void rtl8187_leds_exit(struct ieee80211_hw *dev)
         struct rtl8187_priv *priv = dev->priv;
 
         /* turn the LED off before exiting */
-        queue_delayed_work(dev->workqueue, &priv->led_off, 0);
+        ieee80211_queue_delayed_work(dev, &priv->led_off, 0);
         cancel_delayed_work_sync(&priv->led_off);
         cancel_delayed_work_sync(&priv->led_on);
         rtl8187_unregister_led(&priv->led_rx);