diff options
author | Gertjan van Wingerde <gwingerde@gmail.com> | 2010-05-11 17:51:40 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2010-05-12 16:41:44 -0400 |
commit | 85b7a8b3871bde7885516fed2a1c8da699913318 (patch) | |
tree | 80c488fc082b06c9278e8e30db0033306404e8a1 /drivers/net/wireless/rt2x00/rt2x00queue.c | |
parent | e01f1ec35ff91c8a3f4a3e48a0c8ab476124b973 (diff) |
rt2x00: Simplify TXD handling of beacons.
The handling of tx descriptors for beacons can be simplified by updating
write_tx_desc implementations of each driver to write directly to the
queue entry descriptor instead of to a provided memory area.
This is also a preparation for further clean ups where descriptors are
properly reserved in the skb instead of fiddling with the skb data
pointer.
Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/rt2x00/rt2x00queue.c')
-rw-r--r-- | drivers/net/wireless/rt2x00/rt2x00queue.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c index 97b2c7650656..891d5f72716e 100644 --- a/drivers/net/wireless/rt2x00/rt2x00queue.c +++ b/drivers/net/wireless/rt2x00/rt2x00queue.c | |||
@@ -552,7 +552,6 @@ int rt2x00queue_update_beacon(struct rt2x00_dev *rt2x00dev, | |||
552 | struct rt2x00_intf *intf = vif_to_intf(vif); | 552 | struct rt2x00_intf *intf = vif_to_intf(vif); |
553 | struct skb_frame_desc *skbdesc; | 553 | struct skb_frame_desc *skbdesc; |
554 | struct txentry_desc txdesc; | 554 | struct txentry_desc txdesc; |
555 | __le32 desc[16]; | ||
556 | 555 | ||
557 | if (unlikely(!intf->beacon)) | 556 | if (unlikely(!intf->beacon)) |
558 | return -ENOBUFS; | 557 | return -ENOBUFS; |
@@ -585,19 +584,10 @@ int rt2x00queue_update_beacon(struct rt2x00_dev *rt2x00dev, | |||
585 | rt2x00queue_create_tx_descriptor(intf->beacon, &txdesc); | 584 | rt2x00queue_create_tx_descriptor(intf->beacon, &txdesc); |
586 | 585 | ||
587 | /* | 586 | /* |
588 | * For the descriptor we use a local array from where the | ||
589 | * driver can move it to the correct location required for | ||
590 | * the hardware. | ||
591 | */ | ||
592 | memset(desc, 0, sizeof(desc)); | ||
593 | |||
594 | /* | ||
595 | * Fill in skb descriptor | 587 | * Fill in skb descriptor |
596 | */ | 588 | */ |
597 | skbdesc = get_skb_frame_desc(intf->beacon->skb); | 589 | skbdesc = get_skb_frame_desc(intf->beacon->skb); |
598 | memset(skbdesc, 0, sizeof(*skbdesc)); | 590 | memset(skbdesc, 0, sizeof(*skbdesc)); |
599 | skbdesc->desc = desc; | ||
600 | skbdesc->desc_len = intf->beacon->queue->desc_size; | ||
601 | skbdesc->entry = intf->beacon; | 591 | skbdesc->entry = intf->beacon; |
602 | 592 | ||
603 | /* | 593 | /* |