diff options
author | Ivo van Doorn <ivdoorn@gmail.com> | 2008-05-10 07:46:08 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-05-21 21:47:34 -0400 |
commit | dec13b6bda600c7e7da993e634562873112af50b (patch) | |
tree | 89cbae38944056d2ce6393d0d9ea919728b78ab8 /drivers/net/wireless/rt2x00/rt2400pci.c | |
parent | 7050ec821c52826b63835dde54ee3d71c7db4262 (diff) |
rt2x00: Remove redundant flags/dev_flags initializations
the rxdesc structure is properly memsetted before passed to
the driver. This means we don't have to reinitialize the flags
and dev_flags fields in the drivers again.
This will prevent problems when the rxdone handler is adding
flags in a earlier status and will make the code look nicer
when we are adding more read attributes in the rxdone handler
in the driver.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/rt2x00/rt2400pci.c')
-rw-r--r-- | drivers/net/wireless/rt2x00/rt2400pci.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c index d3d9b189fd83..a491ba5bb5c3 100644 --- a/drivers/net/wireless/rt2x00/rt2400pci.c +++ b/drivers/net/wireless/rt2x00/rt2400pci.c | |||
@@ -1087,7 +1087,6 @@ static void rt2400pci_fill_rxdone(struct queue_entry *entry, | |||
1087 | rt2x00_desc_read(priv_rx->desc, 2, &word2); | 1087 | rt2x00_desc_read(priv_rx->desc, 2, &word2); |
1088 | rt2x00_desc_read(priv_rx->desc, 3, &word3); | 1088 | rt2x00_desc_read(priv_rx->desc, 3, &word3); |
1089 | 1089 | ||
1090 | rxdesc->flags = 0; | ||
1091 | if (rt2x00_get_field32(word0, RXD_W0_CRC_ERROR)) | 1090 | if (rt2x00_get_field32(word0, RXD_W0_CRC_ERROR)) |
1092 | rxdesc->flags |= RX_FLAG_FAILED_FCS_CRC; | 1091 | rxdesc->flags |= RX_FLAG_FAILED_FCS_CRC; |
1093 | if (rt2x00_get_field32(word0, RXD_W0_PHYSICAL_ERROR)) | 1092 | if (rt2x00_get_field32(word0, RXD_W0_PHYSICAL_ERROR)) |
@@ -1103,7 +1102,7 @@ static void rt2400pci_fill_rxdone(struct queue_entry *entry, | |||
1103 | entry->queue->rt2x00dev->rssi_offset; | 1102 | entry->queue->rt2x00dev->rssi_offset; |
1104 | rxdesc->size = rt2x00_get_field32(word0, RXD_W0_DATABYTE_COUNT); | 1103 | rxdesc->size = rt2x00_get_field32(word0, RXD_W0_DATABYTE_COUNT); |
1105 | 1104 | ||
1106 | rxdesc->dev_flags = RXDONE_SIGNAL_PLCP; | 1105 | rxdesc->dev_flags |= RXDONE_SIGNAL_PLCP; |
1107 | if (rt2x00_get_field32(word0, RXD_W0_MY_BSS)) | 1106 | if (rt2x00_get_field32(word0, RXD_W0_MY_BSS)) |
1108 | rxdesc->dev_flags |= RXDONE_MY_BSS; | 1107 | rxdesc->dev_flags |= RXDONE_MY_BSS; |
1109 | } | 1108 | } |