rt2x00: Move init_txring and init_rxring into rt2x00lib

Prior to enabling the radio rt2x00lib should go through all
rings and for each entry should call the callback function
init_txentry() and init_rxentry().

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 27 insertions, 56 deletions

diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c
index 95db2ccbc9a6..f4d0c779ac78 100644
--- a/drivers/net/wireless/rt2x00/rt2400pci.c
+++ b/drivers/net/wireless/rt2x00/rt2400pci.c
@@ -592,65 +592,43 @@ static void rt2400pci_link_tuner(struct rt2x00_dev *rt2x00dev)
 /*
  * Initialization functions.
  */
-static void rt2400pci_init_rxring(struct rt2x00_dev *rt2x00dev)
+static void rt2400pci_init_rxentry(struct rt2x00_dev *rt2x00dev,
+                                   struct data_entry *entry)
 {
-        struct data_ring *ring = rt2x00dev->rx;
-        __le32 *rxd;
-        unsigned int i;
+        __le32 *rxd = entry->priv;
         u32 word;
 
-        memset(ring->data_addr, 0x00, rt2x00_get_ring_size(ring));
-
-        for (i = 0; i < ring->stats.limit; i++) {
-                rxd = ring->entry[i].priv;
+        rt2x00_desc_read(rxd, 2, &word);
+        rt2x00_set_field32(&word, RXD_W2_BUFFER_LENGTH, entry->ring->data_size);
+        rt2x00_desc_write(rxd, 2, word);
 
-                rt2x00_desc_read(rxd, 2, &word);
-                rt2x00_set_field32(&word, RXD_W2_BUFFER_LENGTH,
-                                   ring->data_size);
-                rt2x00_desc_write(rxd, 2, word);
-
-                rt2x00_desc_read(rxd, 1, &word);
-                rt2x00_set_field32(&word, RXD_W1_BUFFER_ADDRESS,
-                                   ring->entry[i].data_dma);
-                rt2x00_desc_write(rxd, 1, word);
-
-                rt2x00_desc_read(rxd, 0, &word);
-                rt2x00_set_field32(&word, RXD_W0_OWNER_NIC, 1);
-                rt2x00_desc_write(rxd, 0, word);
-        }
+        rt2x00_desc_read(rxd, 1, &word);
+        rt2x00_set_field32(&word, RXD_W1_BUFFER_ADDRESS, entry->data_dma);
+        rt2x00_desc_write(rxd, 1, word);
 
-        rt2x00_ring_index_clear(rt2x00dev->rx);
+        rt2x00_desc_read(rxd, 0, &word);
+        rt2x00_set_field32(&word, RXD_W0_OWNER_NIC, 1);
+        rt2x00_desc_write(rxd, 0, word);
 }
 
-static void rt2400pci_init_txring(struct rt2x00_dev *rt2x00dev, const int queue)
+static void rt2400pci_init_txentry(struct rt2x00_dev *rt2x00dev,
+                                   struct data_entry *entry)
 {
-        struct data_ring *ring = rt2x00lib_get_ring(rt2x00dev, queue);
-        __le32 *txd;
-        unsigned int i;
+        __le32 *txd = entry->priv;
         u32 word;
 
-        memset(ring->data_addr, 0x00, rt2x00_get_ring_size(ring));
-
-        for (i = 0; i < ring->stats.limit; i++) {
-                txd = ring->entry[i].priv;
-
-                rt2x00_desc_read(txd, 1, &word);
-                rt2x00_set_field32(&word, TXD_W1_BUFFER_ADDRESS,
-                                   ring->entry[i].data_dma);
-                rt2x00_desc_write(txd, 1, word);
+        rt2x00_desc_read(txd, 1, &word);
+        rt2x00_set_field32(&word, TXD_W1_BUFFER_ADDRESS, entry->data_dma);
+        rt2x00_desc_write(txd, 1, word);
 
-                rt2x00_desc_read(txd, 2, &word);
-                rt2x00_set_field32(&word, TXD_W2_BUFFER_LENGTH,
-                                   ring->data_size);
-                rt2x00_desc_write(txd, 2, word);
-
-                rt2x00_desc_read(txd, 0, &word);
-                rt2x00_set_field32(&word, TXD_W0_VALID, 0);
-                rt2x00_set_field32(&word, TXD_W0_OWNER_NIC, 0);
-                rt2x00_desc_write(txd, 0, word);
-        }
+        rt2x00_desc_read(txd, 2, &word);
+        rt2x00_set_field32(&word, TXD_W2_BUFFER_LENGTH, entry->ring->data_size);
+        rt2x00_desc_write(txd, 2, word);
 
-        rt2x00_ring_index_clear(ring);
+        rt2x00_desc_read(txd, 0, &word);
+        rt2x00_set_field32(&word, TXD_W0_VALID, 0);
+        rt2x00_set_field32(&word, TXD_W0_OWNER_NIC, 0);
+        rt2x00_desc_write(txd, 0, word);
 }
 
 static int rt2400pci_init_rings(struct rt2x00_dev *rt2x00dev)
@@ -658,15 +636,6 @@ static int rt2400pci_init_rings(struct rt2x00_dev *rt2x00dev)
         u32 reg;
 
         /*
-         * Initialize rings.
-         */
-        rt2400pci_init_rxring(rt2x00dev);
-        rt2400pci_init_txring(rt2x00dev, IEEE80211_TX_QUEUE_DATA0);
-        rt2400pci_init_txring(rt2x00dev, IEEE80211_TX_QUEUE_DATA1);
-        rt2400pci_init_txring(rt2x00dev, IEEE80211_TX_QUEUE_AFTER_BEACON);
-        rt2400pci_init_txring(rt2x00dev, IEEE80211_TX_QUEUE_BEACON);
-
-        /*
          * Initialize registers.
          */
         rt2x00pci_register_read(rt2x00dev, TXCSR2, &reg);
@@ -1569,6 +1538,8 @@ static const struct rt2x00lib_ops rt2400pci_rt2x00_ops = {
         .probe_hw               = rt2400pci_probe_hw,
         .initialize             = rt2x00pci_initialize,
         .uninitialize           = rt2x00pci_uninitialize,
+        .init_rxentry           = rt2400pci_init_rxentry,
+        .init_txentry           = rt2400pci_init_txentry,
         .set_device_state       = rt2400pci_set_device_state,
         .rfkill_poll            = rt2400pci_rfkill_poll,
         .link_stats             = rt2400pci_link_stats,