p54: implement multicast filter

"For best CPU usage and power consumption, having as few
frames as possible percolate through the stack is
desirable. Hence, the hardware should filter as much
as possible."

Note: Not all firmwares include the multicast filter
feature and the stack does not filter them either.
The ARP filter on the other hand was dropped from the
patch since it does not work correctly:

Quote from: Max Filippov <jcmvbkbc@gmail.com>
<http://www.spinics.net/lists/linux-wireless/msg67466.html>
"In the ARP case, when there's no other traffic on p54spi,
all ARP requests are dropped. But if there's some egress
traffic from p54spi, filter seems to work correctly:
only ARP requests that match filter pass through.

In the multicast case filter seems to work correctly, but
it treats broadcast as subject to that filtering too. By
default only 01:00:5e:00:00:01 gets into priv->mc_maclist,
so we miss all broadcasts.

These two filters seem to interfere:
- if we set ARP filter and multicast filter without bc
	=>  we miss all ARPs if there's no egress traffic;
- if we set ARP filter and multicast filter with bc or
	don't set mc filter at all => we get all ARPs.

This effect does not depend on filter setup order."

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Tested-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 31 insertions, 0 deletions

diff --git a/drivers/net/wireless/p54/fwio.c b/drivers/net/wireless/p54/fwio.c
index 2fab7d20ffc2..b6a061cbbdec 100644
--- a/drivers/net/wireless/p54/fwio.c
+++ b/drivers/net/wireless/p54/fwio.c
@@ -727,3 +727,34 @@ int p54_fetch_statistics(struct p54_common *priv)
         p54_tx(priv, skb);
         return 0;
 }
+
+int p54_set_groupfilter(struct p54_common *priv)
+{
+        struct p54_group_address_table *grp;
+        struct sk_buff *skb;
+        bool on = false;
+
+        skb = p54_alloc_skb(priv, P54_HDR_FLAG_CONTROL_OPSET, sizeof(*grp),
+                            P54_CONTROL_TYPE_GROUP_ADDRESS_TABLE, GFP_KERNEL);
+        if (!skb)
+                return -ENOMEM;
+
+        grp = (struct p54_group_address_table *)skb_put(skb, sizeof(*grp));
+
+        on = !(priv->filter_flags & FIF_ALLMULTI) &&
+             (priv->mc_maclist_num > 0 &&
+              priv->mc_maclist_num <= MC_FILTER_ADDRESS_NUM);
+
+        if (on) {
+                grp->filter_enable = cpu_to_le16(1);
+                grp->num_address = cpu_to_le16(priv->mc_maclist_num);
+                memcpy(grp->mac_list, priv->mc_maclist, sizeof(grp->mac_list));
+        } else {
+                grp->filter_enable = cpu_to_le16(0);
+                grp->num_address = cpu_to_le16(0);
+                memset(grp->mac_list, 0, sizeof(grp->mac_list));
+        }
+
+        p54_tx(priv, skb);
+        return 0;
+}