diff options
author | Pavel Roskin <proski@gnu.org> | 2006-05-01 02:13:33 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2006-05-05 17:10:41 -0400 |
commit | 461c078c9cdfc1d24a436a87daed90f18c3b0d0d (patch) | |
tree | 90b08022254282c74cba106e0d94431ad31dc598 /drivers/net/wireless/orinoco_pci.c | |
parent | 95047dd6d00ad00e7f1f632db6b8ecaa704cfc7e (diff) |
[PATCH] orinoco: don't put PCI resource data to the network device
The resource data in the network device is intended for ISA and other
older busses, but not for PCI. Don't put PCI data there. Don't (ab)use
the network device for keeping the IRQ number.
Retire orinoco_pci_setup_netdev(), and print some minimal information to
the kernel log instead, identifying the network device and the driver
mostly to identify problems at startup. Scripts should rely on sysfs.
Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/orinoco_pci.c')
-rw-r--r-- | drivers/net/wireless/orinoco_pci.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/wireless/orinoco_pci.c b/drivers/net/wireless/orinoco_pci.c index df37b95607ff..1c105f40f8d5 100644 --- a/drivers/net/wireless/orinoco_pci.c +++ b/drivers/net/wireless/orinoco_pci.c | |||
@@ -161,7 +161,6 @@ static int orinoco_pci_init_one(struct pci_dev *pdev, | |||
161 | err = -EBUSY; | 161 | err = -EBUSY; |
162 | goto fail_irq; | 162 | goto fail_irq; |
163 | } | 163 | } |
164 | orinoco_pci_setup_netdev(dev, pdev, 0); | ||
165 | 164 | ||
166 | err = orinoco_pci_cor_reset(priv); | 165 | err = orinoco_pci_cor_reset(priv); |
167 | if (err) { | 166 | if (err) { |
@@ -176,6 +175,8 @@ static int orinoco_pci_init_one(struct pci_dev *pdev, | |||
176 | } | 175 | } |
177 | 176 | ||
178 | pci_set_drvdata(pdev, dev); | 177 | pci_set_drvdata(pdev, dev); |
178 | printk(KERN_DEBUG "%s: " DRIVER_NAME " at %s\n", dev->name, | ||
179 | pci_name(pdev)); | ||
179 | 180 | ||
180 | return 0; | 181 | return 0; |
181 | 182 | ||
@@ -204,7 +205,7 @@ static void __devexit orinoco_pci_remove_one(struct pci_dev *pdev) | |||
204 | struct orinoco_private *priv = netdev_priv(dev); | 205 | struct orinoco_private *priv = netdev_priv(dev); |
205 | 206 | ||
206 | unregister_netdev(dev); | 207 | unregister_netdev(dev); |
207 | free_irq(dev->irq, dev); | 208 | free_irq(pdev->irq, dev); |
208 | pci_set_drvdata(pdev, NULL); | 209 | pci_set_drvdata(pdev, NULL); |
209 | free_orinocodev(dev); | 210 | free_orinocodev(dev); |
210 | pci_iounmap(pdev, priv->hw.iobase); | 211 | pci_iounmap(pdev, priv->hw.iobase); |