diff options
author | John W. Linville <linville@tuxdriver.com> | 2010-08-10 13:22:24 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2010-08-16 14:39:48 -0400 |
commit | 13eb670c104e15e06d38f3a210cfaf467a9c66de (patch) | |
tree | 3c863b428ca3b72c8a5c85971d1f4f5c47086be9 /drivers/net/wireless/iwmc3200wifi/rx.c | |
parent | aa0d52c5e7f352ce9725c8940fe2458f2c04e049 (diff) |
iwm3200wifi: remove comparison to WIFI_IF_NTFY_MAX in iwm_ntf_wifi_if_wrapper
drivers/net/wireless/iwmc3200wifi/rx.c: In function 'iwm_ntf_wifi_if_wrapper':
drivers/net/wireless/iwmc3200wifi/rx.c:1198: warning: comparison is always true due to limited range of data type
This is, of course, because the value of WIFI_IF_NTFY_MAX is 0xff and
hdr->oid is a u8. This is obviously an attempt to verify the range on
an input value, but since it has no effect it can simply be removed.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Samuel Ortiz <samuel.ortiz@intel.com>
Diffstat (limited to 'drivers/net/wireless/iwmc3200wifi/rx.c')
-rw-r--r-- | drivers/net/wireless/iwmc3200wifi/rx.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c index c02fcedea9fa..a944893ae3ca 100644 --- a/drivers/net/wireless/iwmc3200wifi/rx.c +++ b/drivers/net/wireless/iwmc3200wifi/rx.c | |||
@@ -1195,11 +1195,8 @@ static int iwm_ntf_wifi_if_wrapper(struct iwm_priv *iwm, u8 *buf, | |||
1195 | IWM_DBG_NTF(iwm, DBG, "WIFI_IF_WRAPPER cmd is delivered to UMAC: " | 1195 | IWM_DBG_NTF(iwm, DBG, "WIFI_IF_WRAPPER cmd is delivered to UMAC: " |
1196 | "oid is 0x%x\n", hdr->oid); | 1196 | "oid is 0x%x\n", hdr->oid); |
1197 | 1197 | ||
1198 | if (hdr->oid <= WIFI_IF_NTFY_MAX) { | 1198 | set_bit(hdr->oid, &iwm->wifi_ntfy[0]); |
1199 | set_bit(hdr->oid, &iwm->wifi_ntfy[0]); | 1199 | wake_up_interruptible(&iwm->wifi_ntfy_queue); |
1200 | wake_up_interruptible(&iwm->wifi_ntfy_queue); | ||
1201 | } else | ||
1202 | return -EINVAL; | ||
1203 | 1200 | ||
1204 | switch (hdr->oid) { | 1201 | switch (hdr->oid) { |
1205 | case UMAC_WIFI_IF_CMD_SET_PROFILE: | 1202 | case UMAC_WIFI_IF_CMD_SET_PROFILE: |