[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

6 files changed, 154 insertions, 99 deletions

diff --git a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
index a4f4c8798a83..b0d28ae0b324 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
@@ -646,6 +646,7 @@ static struct ieee80211_rate *rs_get_rate(void *priv_rate,
         struct sta_info *sta;
         u16 fc, rate_mask;
         struct iwl_priv *priv = (struct iwl_priv *)priv_rate;
+        DECLARE_MAC_BUF(mac);
 
         IWL_DEBUG_RATE("enter\n");
 
@@ -681,8 +682,8 @@ static struct ieee80211_rate *rs_get_rate(void *priv_rate,
                 u8 sta_id = iwl_hw_find_station(priv, hdr->addr1);
 
                 if (sta_id == IWL_INVALID_STATION) {
-                        IWL_DEBUG_RATE("LQ: ADD station " MAC_FMT "\n",
-                                        MAC_ARG(hdr->addr1));
+                        IWL_DEBUG_RATE("LQ: ADD station %s\n",
+                                       print_mac(mac, hdr->addr1));
                         sta_id = iwl_add_station(priv,
                                     hdr->addr1, 0, CMD_ASYNC);
                 }
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index 26f03a0b878d..55f7d89aad8d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -457,13 +457,16 @@ static void iwl3945_rx_reply_rx(struct iwl_priv *priv,
                         }
 
                 case IEEE80211_STYPE_PROBE_REQ:{
+                                DECLARE_MAC_BUF(mac1);
+                                DECLARE_MAC_BUF(mac2);
+                                DECLARE_MAC_BUF(mac3);
                                 if (priv->iw_mode == IEEE80211_IF_TYPE_IBSS)
                                         IWL_DEBUG_DROP
-                                            ("Dropping (non network): " MAC_FMT
-                                             ", " MAC_FMT ", " MAC_FMT "\n",
-                                             MAC_ARG(header->addr1),
-                                             MAC_ARG(header->addr2),
-                                             MAC_ARG(header->addr3));
+                                            ("Dropping (non network): %s"
+                                             ", %s, %s\n",
+                                             print_mac(mac1, header->addr1),
+                                             print_mac(mac2, header->addr2),
+                                             print_mac(mac3, header->addr3));
                                 return;
                         }
                 }
@@ -474,18 +477,22 @@ static void iwl3945_rx_reply_rx(struct iwl_priv *priv,
         case IEEE80211_FTYPE_CTL:
                 break;
 
-        case IEEE80211_FTYPE_DATA:
+        case IEEE80211_FTYPE_DATA: {
+                DECLARE_MAC_BUF(mac1);
+                DECLARE_MAC_BUF(mac2);
+                DECLARE_MAC_BUF(mac3);
+
                 if (unlikely(is_duplicate_packet(priv, header)))
-                        IWL_DEBUG_DROP("Dropping (dup): " MAC_FMT ", "
-                                       MAC_FMT ", " MAC_FMT "\n",
-                                       MAC_ARG(header->addr1),
-                                       MAC_ARG(header->addr2),
-                                       MAC_ARG(header->addr3));
+                        IWL_DEBUG_DROP("Dropping (dup): %s, %s, %s\n",
+                                       print_mac(mac1, header->addr1),
+                                       print_mac(mac2, header->addr2),
+                                       print_mac(mac3, header->addr3));
                 else
                         iwl3945_handle_data_packet(priv, 1, rxb, &stats,
                                                    phy_flags);
                 break;
         }
+        }
 }
 
 int iwl_hw_txq_attach_buf_to_tfd(struct iwl_priv *priv, void *ptr,
@@ -563,6 +570,7 @@ u8 iwl_hw_find_station(struct iwl_priv *priv, const u8 *addr)
         int i;
         int ret = IWL_INVALID_STATION;
         unsigned long flags;
+        DECLARE_MAC_BUF(mac);
 
         spin_lock_irqsave(&priv->sta_lock, flags);
         for (i = IWL_STA_ID; i < priv->hw_setting.max_stations; i++)
@@ -573,8 +581,8 @@ u8 iwl_hw_find_station(struct iwl_priv *priv, const u8 *addr)
                         goto out;
                 }
 
-        IWL_DEBUG_INFO("can not find STA " MAC_FMT " (total %d)\n",
-                       MAC_ARG(addr), priv->num_stations);
+        IWL_DEBUG_INFO("can not find STA %s (total %d)\n",
+                       print_mac(mac, addr), priv->num_stations);
  out:
         spin_unlock_irqrestore(&priv->sta_lock, flags);
         return ret;
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
index f3638607d641..7b74481f5282 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
@@ -1737,10 +1737,11 @@ static struct ieee80211_rate *rs_get_rate(void *priv_rate,
 
         if ((priv->iw_mode == IEEE80211_IF_TYPE_IBSS) && !lq->ibss_sta_added) {
                 u8 sta_id = iwl_hw_find_station(priv, hdr->addr1);
+                DECLARE_MAC_BUF(mac);
 
                 if (sta_id == IWL_INVALID_STATION) {
-                        IWL_DEBUG_RATE("LQ: ADD station " MAC_FMT "\n",
-                                        MAC_ARG(hdr->addr1));
+                        IWL_DEBUG_RATE("LQ: ADD station %s\n",
+                                       print_mac(mac, hdr->addr1));
                         sta_id = iwl_add_station(priv,
                                                  hdr->addr1, 0, CMD_ASYNC);
                 }
@@ -1811,14 +1812,16 @@ static void rs_rate_init(void *priv_rate, void *priv_sta,
         crl->ibss_sta_added = 0;
         if (priv->iw_mode == IEEE80211_IF_TYPE_AP) {
                 u8 sta_id = iwl_hw_find_station(priv, sta->addr);
+                DECLARE_MAC_BUF(mac);
+
                 /* for IBSS the call are from tasklet */
-                IWL_DEBUG_HT("LQ: ADD station " MAC_FMT " \n",
-                             MAC_ARG(sta->addr));
+                IWL_DEBUG_HT("LQ: ADD station %s\n",
+                             print_mac(mac, sta->addr));
 
                 if (sta_id == IWL_INVALID_STATION) {
-                        IWL_DEBUG_RATE("LQ: ADD station " MAC_FMT "\n",
-                                        MAC_ARG(sta->addr));
-                                        sta_id = iwl_add_station(priv,
+                        IWL_DEBUG_RATE("LQ: ADD station %s\n",
+                                       print_mac(mac, sta->addr));
+                        sta_id = iwl_add_station(priv,
                                                  sta->addr, 0, CMD_ASYNC);
                 }
                 if ((sta_id != IWL_INVALID_STATION)) {
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index ba35b3ac7c7e..e624f2a41e0e 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -164,6 +164,7 @@ u8 iwl_hw_find_station(struct iwl_priv *priv, const u8 *addr)
         int start = 0;
         int ret = IWL_INVALID_STATION;
         unsigned long flags;
+        DECLARE_MAC_BUF(mac);
 
         if ((priv->iw_mode == IEEE80211_IF_TYPE_IBSS) ||
             (priv->iw_mode == IEEE80211_IF_TYPE_AP))
@@ -181,8 +182,8 @@ u8 iwl_hw_find_station(struct iwl_priv *priv, const u8 *addr)
                         goto out;
                 }
 
-        IWL_DEBUG_ASSOC("can not find STA " MAC_FMT " total %d\n",
-                        MAC_ARG(addr), priv->num_stations);
+        IWL_DEBUG_ASSOC("can not find STA %s total %d\n",
+                        print_mac(mac, addr), priv->num_stations);
 
  out:
         spin_unlock_irqrestore(&priv->sta_lock, flags);
@@ -3909,12 +3910,15 @@ static void iwl4965_rx_reply_rx(struct iwl_priv *priv,
                 case IEEE80211_STYPE_PROBE_REQ:
                         if ((priv->iw_mode == IEEE80211_IF_TYPE_IBSS) &&
                             !iwl_is_associated(priv)) {
+                                DECLARE_MAC_BUF(mac1);
+                                DECLARE_MAC_BUF(mac2);
+                                DECLARE_MAC_BUF(mac3);
+
                                 IWL_DEBUG_DROP("Dropping (non network): "
-                                               MAC_FMT ", " MAC_FMT ", "
-                                               MAC_FMT "\n",
-                                               MAC_ARG(header->addr1),
-                                               MAC_ARG(header->addr2),
-                                               MAC_ARG(header->addr3));
+                                               "%s, %s, %s\n",
+                                               print_mac(mac1, header->addr1),
+                                               print_mac(mac2, header->addr2),
+                                               print_mac(mac3, header->addr3));
                                 return;
                         }
                 }
@@ -3936,28 +3940,31 @@ static void iwl4965_rx_reply_rx(struct iwl_priv *priv,
 
                 break;
 
-        case IEEE80211_FTYPE_DATA:
+        case IEEE80211_FTYPE_DATA: {
+                DECLARE_MAC_BUF(mac1);
+                DECLARE_MAC_BUF(mac2);
+                DECLARE_MAC_BUF(mac3);
+
                 if (priv->iw_mode == IEEE80211_IF_TYPE_AP)
                         iwl4965_update_ps_mode(priv, fc  & IEEE80211_FCTL_PM,
                                                 header->addr2);
 
                 if (unlikely(!network_packet))
                         IWL_DEBUG_DROP("Dropping (non network): "
-                                       MAC_FMT ", " MAC_FMT ", "
-                                       MAC_FMT "\n",
-                                       MAC_ARG(header->addr1),
-                                       MAC_ARG(header->addr2),
-                                       MAC_ARG(header->addr3));
+                                       "%s, %s, %s\n",
+                                       print_mac(mac1, header->addr1),
+                                       print_mac(mac2, header->addr2),
+                                       print_mac(mac3, header->addr3));
                 else if (unlikely(is_duplicate_packet(priv, header)))
-                        IWL_DEBUG_DROP("Dropping (dup): " MAC_FMT ", "
-                                       MAC_FMT ", " MAC_FMT "\n",
-                                       MAC_ARG(header->addr1),
-                                       MAC_ARG(header->addr2),
-                                       MAC_ARG(header->addr3));
+                        IWL_DEBUG_DROP("Dropping (dup): %s, %s, %s\n",
+                                       print_mac(mac1, header->addr1),
+                                       print_mac(mac2, header->addr2),
+                                       print_mac(mac3, header->addr3));
                 else
                         iwl4965_handle_data_packet(priv, 1, include_phy, rxb,
                                                    &stats);
                 break;
+        }
         default:
                 break;
 
@@ -4106,10 +4113,12 @@ static void iwl4965_rx_reply_compressed_ba(struct iwl_priv *priv,
 
         /* TODO: Need to get this copy more sefely - now good for debug */
 /*
-        IWL_DEBUG_TX_REPLY("REPLY_COMPRESSED_BA [%d]Received from " MAC_FMT ",
-                           sta_id = %d\n",
+        {
+        DECLARE_MAC_BUF(mac);
+        IWL_DEBUG_TX_REPLY("REPLY_COMPRESSED_BA [%d]Received from %s, "
+                           "sta_id = %d\n",
                            agg->wait_for_ba,
-                           MAC_ARG((u8*) &ba_resp->sta_addr_lo32),
+                           print_mac(mac, (u8*) &ba_resp->sta_addr_lo32),
                            ba_resp->sta_id);
         IWL_DEBUG_TX_REPLY("TID = %d, SeqCtl = %d, bitmap = 0x%X%X, scd_flow = "
                            "%d, scd_ssn = %d\n",
@@ -4123,6 +4132,7 @@ static void iwl4965_rx_reply_compressed_ba(struct iwl_priv *priv,
                            agg->start_idx,
                            agg->bitmap1,
                            agg->bitmap0);
+        }
 */
         iwl4965_tx_status_reply_compressed_ba(priv, agg, ba_resp);
         /* releases all the TFDs until the SSN */
@@ -4539,14 +4549,15 @@ int iwl_mac_ht_tx_agg_start(struct ieee80211_hw *hw, u8 *da, u16 tid,
         int ssn = -1;
         unsigned long flags;
         struct iwl_tid_data *tid_data;
+        DECLARE_MAC_BUF(mac);
 
         if (likely(tid < ARRAY_SIZE(default_tid_to_tx_fifo)))
                 tx_fifo = default_tid_to_tx_fifo[tid];
         else
                 return -EINVAL;
 
-        IWL_WARNING("iwl-AGG iwl_mac_ht_tx_agg_start on da=" MAC_FMT
-                    " tid=%d\n", MAC_ARG(da), tid);
+        IWL_WARNING("iwl-AGG iwl_mac_ht_tx_agg_start on da=%s"
+                    " tid=%d\n", print_mac(mac, da), tid);
 
         sta_id = iwl_hw_find_station(priv, da);
         if (sta_id == IWL_INVALID_STATION)
@@ -4577,6 +4588,8 @@ int iwl_mac_ht_tx_agg_stop(struct ieee80211_hw *hw, u8 *da, u16 tid,
         int tx_fifo_id, txq_id, sta_id, ssn = -1;
         struct iwl_tid_data *tid_data;
         int rc;
+        DECLARE_MAC_BUF(mac);
+
         if (!da) {
                 IWL_ERROR("%s: da = NULL\n", __func__);
                 return -EINVAL;
@@ -4602,8 +4615,8 @@ int iwl_mac_ht_tx_agg_stop(struct ieee80211_hw *hw, u8 *da, u16 tid,
                 return rc;
 
         iwl4965_ba_status(priv, tid, BA_STATUS_INITIATOR_DELBA);
-        IWL_DEBUG_INFO("iwl_mac_ht_tx_agg_stop on da=" MAC_FMT " tid=%d\n",
-                    MAC_ARG(da), tid);
+        IWL_DEBUG_INFO("iwl_mac_ht_tx_agg_stop on da=%s tid=%d\n",
+                       print_mac(mac, da), tid);
 
         return 0;
 }
@@ -4613,9 +4626,10 @@ int iwl_mac_ht_rx_agg_start(struct ieee80211_hw *hw, u8 *da,
 {
         struct iwl_priv *priv = hw->priv;
         int sta_id;
+        DECLARE_MAC_BUF(mac);
 
-        IWL_WARNING("iwl-AGG iwl_mac_ht_rx_agg_start on da=" MAC_FMT
-                    " tid=%d\n", MAC_ARG(da), tid);
+        IWL_WARNING("iwl-AGG iwl_mac_ht_rx_agg_start on da=%s"
+                    " tid=%d\n", print_mac(mac, da), tid);
         sta_id = iwl_hw_find_station(priv, da);
         iwl4965_sta_modify_add_ba_tid(priv, sta_id, tid, start_seq_num);
         return 0;
@@ -4626,9 +4640,10 @@ int iwl_mac_ht_rx_agg_stop(struct ieee80211_hw *hw, u8 *da,
 {
         struct iwl_priv *priv = hw->priv;
         int sta_id;
+        DECLARE_MAC_BUF(mac);
 
-        IWL_WARNING("iwl-AGG iwl_mac_ht_rx_agg_stop on da=" MAC_FMT " tid=%d\n",
-                     MAC_ARG(da), tid);
+        IWL_WARNING("iwl-AGG iwl_mac_ht_rx_agg_stop on da=%s tid=%d\n",
+                    print_mac(mac, da), tid);
         sta_id = iwl_hw_find_station(priv, da);
         iwl4965_sta_modify_del_ba_tid(priv, sta_id, tid);
         return 0;
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 474b6402040c..cc405f4a8647 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -460,6 +460,7 @@ u8 iwl_add_station(struct iwl_priv *priv, const u8 *addr, int is_ap, u8 flags)
         int index = IWL_INVALID_STATION;
         struct iwl_station_entry *station;
         unsigned long flags_spin;
+        DECLARE_MAC_BUF(mac);
 
         spin_lock_irqsave(&priv->sta_lock, flags_spin);
         if (is_ap)
@@ -492,7 +493,7 @@ u8 iwl_add_station(struct iwl_priv *priv, const u8 *addr, int is_ap, u8 flags)
                 return index;
         }
 
-        IWL_DEBUG_ASSOC("Add STA ID %d: " MAC_FMT "\n", index, MAC_ARG(addr));
+        IWL_DEBUG_ASSOC("Add STA ID %d: %s\n", index, print_mac(mac, addr));
         station = &priv->stations[index];
         station->used = 1;
         priv->num_stations++;
@@ -1064,6 +1065,7 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
         /* cast away the const for active_rxon in this function */
         struct iwl_rxon_cmd *active_rxon = (void *)&priv->active_rxon;
         int rc = 0;
+        DECLARE_MAC_BUF(mac);
 
         if (!iwl_is_alive(priv))
                 return -1;
@@ -1134,11 +1136,11 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
         IWL_DEBUG_INFO("Sending RXON\n"
                        "* with%s RXON_FILTER_ASSOC_MSK\n"
                        "* channel = %d\n"
-                       "* bssid = " MAC_FMT "\n",
+                       "* bssid = %s\n",
                        ((priv->staging_rxon.filter_flags &
                          RXON_FILTER_ASSOC_MSK) ? "" : "out"),
                        le16_to_cpu(priv->staging_rxon.channel),
-                       MAC_ARG(priv->staging_rxon.bssid_addr));
+                       print_mac(mac, priv->staging_rxon.bssid_addr));
 
         /* Apply the new configuration */
         rc = iwl_send_cmd_pdu(priv, REPLY_RXON,
@@ -2693,7 +2695,9 @@ static int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
 
         /* If this frame is part of a IBSS network, then we use the
          * target specific station id */
-        case IEEE80211_IF_TYPE_IBSS:
+        case IEEE80211_IF_TYPE_IBSS: {
+                DECLARE_MAC_BUF(mac);
+
                 sta_id = iwl_hw_find_station(priv, hdr->addr1);
                 if (sta_id != IWL_INVALID_STATION)
                         return sta_id;
@@ -2703,12 +2707,12 @@ static int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
                 if (sta_id != IWL_INVALID_STATION)
                         return sta_id;
 
-                IWL_DEBUG_DROP("Station " MAC_FMT " not in station map. "
+                IWL_DEBUG_DROP("Station %s not in station map. "
                                "Defaulting to broadcast...\n",
-                               MAC_ARG(hdr->addr1));
+                               print_mac(mac, hdr->addr1));
                 iwl_print_hex_dump(IWL_DL_DROP, (u8 *) hdr, sizeof(*hdr));
                 return priv->hw_setting.bcast_sta_id;
-
+        }
         default:
                 IWL_WARNING("Unkown mode of operation: %d", priv->iw_mode);
                 return priv->hw_setting.bcast_sta_id;
@@ -2781,8 +2785,10 @@ static int iwl_tx_skb(struct iwl_priv *priv,
         hdr_len = ieee80211_get_hdrlen(fc);
         sta_id = iwl_get_sta_id(priv, hdr);
         if (sta_id == IWL_INVALID_STATION) {
-                IWL_DEBUG_DROP("Dropping - INVALID STATION: " MAC_FMT "\n",
-                               MAC_ARG(hdr->addr1));
+                DECLARE_MAC_BUF(mac);
+
+                IWL_DEBUG_DROP("Dropping - INVALID STATION: %s\n",
+                               print_mac(mac, hdr->addr1));
                 goto drop;
         }
 
@@ -4385,6 +4391,8 @@ int iwl_tx_queue_update_write_ptr(struct iwl_priv *priv,
 #ifdef CONFIG_IWLWIFI_DEBUG
 static void iwl_print_rx_config_cmd(struct iwl_rxon_cmd *rxon)
 {
+        DECLARE_MAC_BUF(mac);
+
         IWL_DEBUG_RADIO("RX CONFIG:\n");
         iwl_print_hex_dump(IWL_DL_RADIO, (u8 *) rxon, sizeof(*rxon));
         IWL_DEBUG_RADIO("u16 channel: 0x%x\n", le16_to_cpu(rxon->channel));
@@ -4395,10 +4403,10 @@ static void iwl_print_rx_config_cmd(struct iwl_rxon_cmd *rxon)
         IWL_DEBUG_RADIO("u8 ofdm_basic_rates: 0x%02x\n",
                         rxon->ofdm_basic_rates);
         IWL_DEBUG_RADIO("u8 cck_basic_rates: 0x%02x\n", rxon->cck_basic_rates);
-        IWL_DEBUG_RADIO("u8[6] node_addr: " MAC_FMT "\n",
-                        MAC_ARG(rxon->node_addr));
-        IWL_DEBUG_RADIO("u8[6] bssid_addr: " MAC_FMT "\n",
-                        MAC_ARG(rxon->bssid_addr));
+        IWL_DEBUG_RADIO("u8[6] node_addr: %s\n",
+                        print_mac(mac, rxon->node_addr));
+        IWL_DEBUG_RADIO("u8[6] bssid_addr: %s\n",
+                        print_mac(mac, rxon->bssid_addr));
         IWL_DEBUG_RADIO("u16 assoc_id: 0x%x\n", le16_to_cpu(rxon->assoc_id));
 }
 #endif
@@ -6322,6 +6330,7 @@ static void iwl_down(struct iwl_priv *priv)
 
 static int __iwl_up(struct iwl_priv *priv)
 {
+        DECLARE_MAC_BUF(mac);
         int rc, i;
 
         if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
@@ -6381,8 +6390,8 @@ static int __iwl_up(struct iwl_priv *priv)
 
                 /* MAC Address location in EEPROM same for 3945/4965 */
                 get_eeprom_mac(priv, priv->mac_addr);
-                IWL_DEBUG_INFO("MAC address: " MAC_FMT "\n",
-                               MAC_ARG(priv->mac_addr));
+                IWL_DEBUG_INFO("MAC address: %s\n",
+                               print_mac(mac, priv->mac_addr));
 
                 SET_IEEE80211_PERM_ADDR(priv->hw, priv->mac_addr);
 
@@ -6728,6 +6737,7 @@ static void iwl_bg_post_associate(struct work_struct *data)
 
         int rc = 0;
         struct ieee80211_conf *conf = NULL;
+        DECLARE_MAC_BUF(mac);
 
         if (priv->iw_mode == IEEE80211_IF_TYPE_AP) {
                 IWL_ERROR("%s Should not be called in AP mode\n", __FUNCTION__);
@@ -6735,8 +6745,9 @@ static void iwl_bg_post_associate(struct work_struct *data)
         }
 
 
-        IWL_DEBUG_ASSOC("Associated as %d to: " MAC_FMT "\n",
-                        priv->assoc_id, MAC_ARG(priv->active_rxon.bssid_addr));
+        IWL_DEBUG_ASSOC("Associated as %d to: %s\n",
+                        priv->assoc_id,
+                        print_mac(mac, priv->active_rxon.bssid_addr));
 
         if (test_bit(STATUS_EXIT_PENDING, &priv->status))
                 return;
@@ -6916,11 +6927,12 @@ static int iwl_mac_add_interface(struct ieee80211_hw *hw,
 {
         struct iwl_priv *priv = hw->priv;
         unsigned long flags;
+        DECLARE_MAC_BUF(mac);
 
         IWL_DEBUG_MAC80211("enter: id %d, type %d\n", conf->if_id, conf->type);
         if (conf->mac_addr)
-                IWL_DEBUG_MAC80211("enter: MAC " MAC_FMT "\n",
-                                   MAC_ARG(conf->mac_addr));
+                IWL_DEBUG_MAC80211("enter: MAC %s\n",
+                                   print_mac(mac, conf->mac_addr));
 
         if (priv->interface_id) {
                 IWL_DEBUG_MAC80211("leave - interface_id != 0\n");
@@ -7094,6 +7106,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw, int if_id,
                                     struct ieee80211_if_conf *conf)
 {
         struct iwl_priv *priv = hw->priv;
+        DECLARE_MAC_BUF(mac);
         unsigned long flags;
         int rc;
 
@@ -7111,8 +7124,8 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw, int if_id,
 
         IWL_DEBUG_MAC80211("enter: interface id %d\n", if_id);
         if (conf->bssid)
-                IWL_DEBUG_MAC80211("bssid: " MAC_FMT "\n",
-                                   MAC_ARG(conf->bssid));
+                IWL_DEBUG_MAC80211("bssid: %s\n",
+                                   print_mac(mac, conf->bssid));
 
         if (unlikely(test_bit(STATUS_SCANNING, &priv->status)) &&
             !(priv->hw->flags & IEEE80211_HW_NO_PROBE_FILTERING)) {
@@ -7131,8 +7144,8 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw, int if_id,
                 if (!conf->bssid) {
                         conf->bssid = priv->mac_addr;
                         memcpy(priv->bssid, priv->mac_addr, ETH_ALEN);
-                        IWL_DEBUG_MAC80211("bssid was set to: " MAC_FMT "\n",
-                                           MAC_ARG(conf->bssid));
+                        IWL_DEBUG_MAC80211("bssid was set to: %s\n",
+                                           print_mac(mac, conf->bssid));
                 }
                 if (priv->ibss_beacon)
                         dev_kfree_skb(priv->ibss_beacon);
@@ -7282,8 +7295,10 @@ static int iwl_mac_set_key(struct ieee80211_hw *hw, set_key_cmd cmd,
 
         sta_id = iwl_hw_find_station(priv, addr);
         if (sta_id == IWL_INVALID_STATION) {
-                IWL_DEBUG_MAC80211("leave - " MAC_FMT " not in station map.\n",
-                                   MAC_ARG(addr));
+                DECLARE_MAC_BUF(mac);
+
+                IWL_DEBUG_MAC80211("leave - %s not in station map.\n",
+                                   print_mac(mac, addr));
                 return -EINVAL;
         }
 
diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c b/drivers/net/wireless/iwlwifi/iwl4965-base.c
index b79dabc8c01c..6cea3118b7c1 100644
--- a/drivers/net/wireless/iwlwifi/iwl4965-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl4965-base.c
@@ -459,6 +459,7 @@ u8 iwl_add_station(struct iwl_priv *priv, const u8 *addr, int is_ap, u8 flags)
         int index = IWL_INVALID_STATION;
         struct iwl_station_entry *station;
         unsigned long flags_spin;
+        DECLARE_MAC_BUF(mac);
 
         spin_lock_irqsave(&priv->sta_lock, flags_spin);
         if (is_ap)
@@ -493,7 +494,7 @@ u8 iwl_add_station(struct iwl_priv *priv, const u8 *addr, int is_ap, u8 flags)
         }
 
 
-        IWL_DEBUG_ASSOC("Add STA ID %d: " MAC_FMT "\n", index, MAC_ARG(addr));
+        IWL_DEBUG_ASSOC("Add STA ID %d: %s\n", index, print_mac(mac, addr));
         station = &priv->stations[index];
         station->used = 1;
         priv->num_stations++;
@@ -1083,6 +1084,7 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
 {
         /* cast away the const for active_rxon in this function */
         struct iwl_rxon_cmd *active_rxon = (void *)&priv->active_rxon;
+        DECLARE_MAC_BUF(mac);
         int rc = 0;
 
         if (!iwl_is_alive(priv))
@@ -1160,11 +1162,11 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
         IWL_DEBUG_INFO("Sending RXON\n"
                        "* with%s RXON_FILTER_ASSOC_MSK\n"
                        "* channel = %d\n"
-                       "* bssid = " MAC_FMT "\n",
+                       "* bssid = %s\n",
                        ((priv->staging_rxon.filter_flags &
                          RXON_FILTER_ASSOC_MSK) ? "" : "out"),
                        le16_to_cpu(priv->staging_rxon.channel),
-                       MAC_ARG(priv->staging_rxon.bssid_addr));
+                       print_mac(mac, priv->staging_rxon.bssid_addr));
 
         /* Apply the new configuration */
         rc = iwl_send_cmd_pdu(priv, REPLY_RXON,
@@ -2748,6 +2750,7 @@ static int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
 {
         int sta_id;
         u16 fc = le16_to_cpu(hdr->frame_control);
+        DECLARE_MAC_BUF(mac);
 
         /* If this frame is broadcast or not data then use the broadcast
          * station id */
@@ -2781,9 +2784,9 @@ static int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
                 if (sta_id != IWL_INVALID_STATION)
                         return sta_id;
 
-                IWL_DEBUG_DROP("Station " MAC_FMT " not in station map. "
+                IWL_DEBUG_DROP("Station %s not in station map. "
                                "Defaulting to broadcast...\n",
-                               MAC_ARG(hdr->addr1));
+                               print_mac(mac, hdr->addr1));
                 iwl_print_hex_dump(IWL_DL_DROP, (u8 *) hdr, sizeof(*hdr));
                 return priv->hw_setting.bcast_sta_id;
 
@@ -2859,8 +2862,10 @@ static int iwl_tx_skb(struct iwl_priv *priv,
         hdr_len = ieee80211_get_hdrlen(fc);
         sta_id = iwl_get_sta_id(priv, hdr);
         if (sta_id == IWL_INVALID_STATION) {
-                IWL_DEBUG_DROP("Dropping - INVALID STATION: " MAC_FMT "\n",
-                               MAC_ARG(hdr->addr1));
+                DECLARE_MAC_BUF(mac);
+
+                IWL_DEBUG_DROP("Dropping - INVALID STATION: %s\n",
+                               print_mac(mac, hdr->addr1));
                 goto drop;
         }
 
@@ -4703,6 +4708,8 @@ int iwl_tx_queue_update_write_ptr(struct iwl_priv *priv,
 #ifdef CONFIG_IWLWIFI_DEBUG
 static void iwl_print_rx_config_cmd(struct iwl_rxon_cmd *rxon)
 {
+        DECLARE_MAC_BUF(mac);
+
         IWL_DEBUG_RADIO("RX CONFIG:\n");
         iwl_print_hex_dump(IWL_DL_RADIO, (u8 *) rxon, sizeof(*rxon));
         IWL_DEBUG_RADIO("u16 channel: 0x%x\n", le16_to_cpu(rxon->channel));
@@ -4713,10 +4720,10 @@ static void iwl_print_rx_config_cmd(struct iwl_rxon_cmd *rxon)
         IWL_DEBUG_RADIO("u8 ofdm_basic_rates: 0x%02x\n",
                         rxon->ofdm_basic_rates);
         IWL_DEBUG_RADIO("u8 cck_basic_rates: 0x%02x\n", rxon->cck_basic_rates);
-        IWL_DEBUG_RADIO("u8[6] node_addr: " MAC_FMT "\n",
-                        MAC_ARG(rxon->node_addr));
-        IWL_DEBUG_RADIO("u8[6] bssid_addr: " MAC_FMT "\n",
-                        MAC_ARG(rxon->bssid_addr));
+        IWL_DEBUG_RADIO("u8[6] node_addr: %s\n",
+                        print_mac(mac, rxon->node_addr));
+        IWL_DEBUG_RADIO("u8[6] bssid_addr: %s\n",
+                        print_mac(mac, rxon->bssid_addr));
         IWL_DEBUG_RADIO("u16 assoc_id: 0x%x\n", le16_to_cpu(rxon->assoc_id));
 }
 #endif
@@ -6670,6 +6677,7 @@ static void iwl_down(struct iwl_priv *priv)
 
 static int __iwl_up(struct iwl_priv *priv)
 {
+        DECLARE_MAC_BUF(mac);
         int rc, i;
         u32 hw_rf_kill = 0;
 
@@ -6742,8 +6750,8 @@ static int __iwl_up(struct iwl_priv *priv)
 
                 /* MAC Address location in EEPROM same for 3945/4965 */
                 get_eeprom_mac(priv, priv->mac_addr);
-                IWL_DEBUG_INFO("MAC address: " MAC_FMT "\n",
-                               MAC_ARG(priv->mac_addr));
+                IWL_DEBUG_INFO("MAC address: %s\n",
+                               print_mac(mac, priv->mac_addr));
 
                 SET_IEEE80211_PERM_ADDR(priv->hw, priv->mac_addr);
 
@@ -7096,14 +7104,16 @@ static void iwl_bg_post_associate(struct work_struct *data)
 
         int rc = 0;
         struct ieee80211_conf *conf = NULL;
+        DECLARE_MAC_BUF(mac);
 
         if (priv->iw_mode == IEEE80211_IF_TYPE_AP) {
                 IWL_ERROR("%s Should not be called in AP mode\n", __FUNCTION__);
                 return;
         }
 
-        IWL_DEBUG_ASSOC("Associated as %d to: " MAC_FMT "\n",
-                        priv->assoc_id, MAC_ARG(priv->active_rxon.bssid_addr));
+        IWL_DEBUG_ASSOC("Associated as %d to: %s\n",
+                        priv->assoc_id,
+                        print_mac(mac, priv->active_rxon.bssid_addr));
 
 
         if (test_bit(STATUS_EXIT_PENDING, &priv->status))
@@ -7299,11 +7309,12 @@ static int iwl_mac_add_interface(struct ieee80211_hw *hw,
 {
         struct iwl_priv *priv = hw->priv;
         unsigned long flags;
+        DECLARE_MAC_BUF(mac);
 
         IWL_DEBUG_MAC80211("enter: id %d, type %d\n", conf->if_id, conf->type);
         if (conf->mac_addr)
-                IWL_DEBUG_MAC80211("enter: MAC " MAC_FMT "\n",
-                                   MAC_ARG(conf->mac_addr));
+                IWL_DEBUG_MAC80211("enter: MAC %s\n",
+                                   print_mac(mac, conf->mac_addr));
 
         if (priv->interface_id) {
                 IWL_DEBUG_MAC80211("leave - interface_id != 0\n");
@@ -7494,6 +7505,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw, int if_id,
                                     struct ieee80211_if_conf *conf)
 {
         struct iwl_priv *priv = hw->priv;
+        DECLARE_MAC_BUF(mac);
         unsigned long flags;
         int rc;
 
@@ -7511,8 +7523,8 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw, int if_id,
 
         IWL_DEBUG_MAC80211("enter: interface id %d\n", if_id);
         if (conf->bssid)
-                IWL_DEBUG_MAC80211("bssid: " MAC_FMT "\n",
-                                   MAC_ARG(conf->bssid));
+                IWL_DEBUG_MAC80211("bssid: %s\n",
+                                   print_mac(mac, conf->bssid));
 
         if (unlikely(test_bit(STATUS_SCANNING, &priv->status)) &&
             !(priv->hw->flags & IEEE80211_HW_NO_PROBE_FILTERING)) {
@@ -7531,8 +7543,8 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw, int if_id,
                 if (!conf->bssid) {
                         conf->bssid = priv->mac_addr;
                         memcpy(priv->bssid, priv->mac_addr, ETH_ALEN);
-                        IWL_DEBUG_MAC80211("bssid was set to: " MAC_FMT "\n",
-                                           MAC_ARG(conf->bssid));
+                        IWL_DEBUG_MAC80211("bssid was set to: %s\n",
+                                           print_mac(mac, conf->bssid));
                 }
                 if (priv->ibss_beacon)
                         dev_kfree_skb(priv->ibss_beacon);
@@ -7666,6 +7678,7 @@ static int iwl_mac_set_key(struct ieee80211_hw *hw, set_key_cmd cmd,
                            struct ieee80211_key_conf *key)
 {
         struct iwl_priv *priv = hw->priv;
+        DECLARE_MAC_BUF(mac);
         int rc = 0;
         u8 sta_id;
 
@@ -7682,8 +7695,8 @@ static int iwl_mac_set_key(struct ieee80211_hw *hw, set_key_cmd cmd,
 
         sta_id = iwl_hw_find_station(priv, addr);
         if (sta_id == IWL_INVALID_STATION) {
-                IWL_DEBUG_MAC80211("leave - " MAC_FMT " not in station map.\n",
-                                   MAC_ARG(addr));
+                IWL_DEBUG_MAC80211("leave - %s not in station map.\n",
+                                   print_mac(mac, addr));
                 return -EINVAL;
         }