aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/iwlwifi
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2012-10-24 07:26:15 -0400
committerJohannes Berg <johannes.berg@intel.com>2012-10-29 06:27:33 -0400
commit3e2c159260eed10c44f0dd028c328a40a27ad235 (patch)
tree9f88e68776147de335471a4f44d6f029dacab465 /drivers/net/wireless/iwlwifi
parentf4feb8ac6e666d2ca37cf722166bbfadf2c6adf8 (diff)
iwlwifi: clarify NOCOPY/DUP documentation
Clarify the documentation to indicate that these flags can only be used at the end, i.e. after them a copy TFD (no flags set) is invalid. Reported-by: Inbal Hacohen <inbal.hacohen@intel.com> Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-trans.h5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.h b/drivers/net/wireless/iwlwifi/iwl-trans.h
index 76c52378f8f7..47bbe399c068 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans.h
+++ b/drivers/net/wireless/iwlwifi/iwl-trans.h
@@ -225,10 +225,13 @@ struct iwl_device_cmd {
225 * ring. The transport layer doesn't map the command's buffer to DMA, but 225 * ring. The transport layer doesn't map the command's buffer to DMA, but
226 * rather copies it to an previously allocated DMA buffer. This flag tells 226 * rather copies it to an previously allocated DMA buffer. This flag tells
227 * the transport layer not to copy the command, but to map the existing 227 * the transport layer not to copy the command, but to map the existing
228 * buffer. This can save memcpy and is worth with very big comamnds. 228 * buffer (that is passed in) instead. This saves the memcpy and allows
229 * commands that are bigger than the fixed buffer to be submitted.
230 * Note that a TFD entry after a NOCOPY one cannot be a normal copied one.
229 * @IWL_HCMD_DFL_DUP: Only valid without NOCOPY, duplicate the memory for this 231 * @IWL_HCMD_DFL_DUP: Only valid without NOCOPY, duplicate the memory for this
230 * chunk internally and free it again after the command completes. This 232 * chunk internally and free it again after the command completes. This
231 * can (currently) be used only once per command. 233 * can (currently) be used only once per command.
234 * Note that a TFD entry after a DUP one cannot be a normal copied one.
232 */ 235 */
233enum iwl_hcmd_dataflag { 236enum iwl_hcmd_dataflag {
234 IWL_HCMD_DFL_NOCOPY = BIT(0), 237 IWL_HCMD_DFL_NOCOPY = BIT(0),