iwlwifi: replace IWL_WARNING with IWL_WARN

IWL_WARN doesn't use hidden priv pointer.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 37 insertions, 36 deletions

diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 14864cc6775c..26f53647bf36 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -781,59 +781,59 @@ static int iwl3945_check_rxon_cmd(struct iwl_priv *priv)
                                 (RXON_FLG_TGJ_NARROW_BAND_MSK |
                                  RXON_FLG_RADAR_DETECT_MSK));
                 if (error)
-                        IWL_WARNING("check 24G fields %d | %d\n",
+                        IWL_WARN(priv, "check 24G fields %d | %d\n",
                                     counter++, error);
         } else {
                 error |= (rxon->flags & RXON_FLG_SHORT_SLOT_MSK) ?
                                 0 : le32_to_cpu(RXON_FLG_SHORT_SLOT_MSK);
                 if (error)
-                        IWL_WARNING("check 52 fields %d | %d\n",
+                        IWL_WARN(priv, "check 52 fields %d | %d\n",
                                     counter++, error);
                 error |= le32_to_cpu(rxon->flags & RXON_FLG_CCK_MSK);
                 if (error)
-                        IWL_WARNING("check 52 CCK %d | %d\n",
+                        IWL_WARN(priv, "check 52 CCK %d | %d\n",
                                     counter++, error);
         }
         error |= (rxon->node_addr[0] | rxon->bssid_addr[0]) & 0x1;
         if (error)
-                IWL_WARNING("check mac addr %d | %d\n", counter++, error);
+                IWL_WARN(priv, "check mac addr %d | %d\n", counter++, error);
 
         /* make sure basic rates 6Mbps and 1Mbps are supported */
         error |= (((rxon->ofdm_basic_rates & IWL_RATE_6M_MASK) == 0) &&
                   ((rxon->cck_basic_rates & IWL_RATE_1M_MASK) == 0));
         if (error)
-                IWL_WARNING("check basic rate %d | %d\n", counter++, error);
+                IWL_WARN(priv, "check basic rate %d | %d\n", counter++, error);
 
         error |= (le16_to_cpu(rxon->assoc_id) > 2007);
         if (error)
-                IWL_WARNING("check assoc id %d | %d\n", counter++, error);
+                IWL_WARN(priv, "check assoc id %d | %d\n", counter++, error);
 
         error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK))
                         == (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK));
         if (error)
-                IWL_WARNING("check CCK and short slot %d | %d\n",
+                IWL_WARN(priv, "check CCK and short slot %d | %d\n",
                             counter++, error);
 
         error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK))
                         == (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK));
         if (error)
-                IWL_WARNING("check CCK & auto detect %d | %d\n",
+                IWL_WARN(priv, "check CCK & auto detect %d | %d\n",
                             counter++, error);
 
         error |= ((rxon->flags & (RXON_FLG_AUTO_DETECT_MSK |
                         RXON_FLG_TGG_PROTECT_MSK)) == RXON_FLG_TGG_PROTECT_MSK);
         if (error)
-                IWL_WARNING("check TGG and auto detect %d | %d\n",
+                IWL_WARN(priv, "check TGG and auto detect %d | %d\n",
                             counter++, error);
 
         if ((rxon->flags & RXON_FLG_DIS_DIV_MSK))
                 error |= ((rxon->flags & (RXON_FLG_ANT_B_MSK |
                                 RXON_FLG_ANT_A_MSK)) == 0);
         if (error)
-                IWL_WARNING("check antenna %d %d\n", counter++, error);
+                IWL_WARN(priv, "check antenna %d %d\n", counter++, error);
 
         if (error)
-                IWL_WARNING("Tuning to channel %d\n",
+                IWL_WARN(priv, "Tuning to channel %d\n",
                             le16_to_cpu(rxon->channel));
 
         if (error) {
@@ -1207,7 +1207,7 @@ int iwl3945_send_add_station(struct iwl_priv *priv,
                         break;
                 default:
                         rc = -EIO;
-                        IWL_WARNING("REPLY_ADD_STA failed\n");
+                        IWL_WARN(priv, "REPLY_ADD_STA failed\n");
                         break;
                 }
         }
@@ -1289,7 +1289,7 @@ static void iwl3945_clear_free_frames(struct iwl_priv *priv)
         }
 
         if (priv->frames_count) {
-                IWL_WARNING("%d frames still in use.  Did we lose one?\n",
+                IWL_WARN(priv, "%d frames still in use.  Did we lose one?\n",
                             priv->frames_count);
                 priv->frames_count = 0;
         }
@@ -2187,7 +2187,7 @@ static int iwl3945_set_mode(struct iwl_priv *priv, int mode)
 
         cancel_delayed_work(&priv->scan_check);
         if (iwl3945_scan_cancel_timeout(priv, 100)) {
-                IWL_WARNING("Aborted scan still in progress after 100ms\n");
+                IWL_WARN(priv, "Aborted scan still in progress after 100ms\n");
                 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
                 return -EAGAIN;
         }
@@ -2363,7 +2363,8 @@ static int iwl3945_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
                 return priv->hw_params.bcast_sta_id;
 
         default:
-                IWL_WARNING("Unknown mode of operation: %d\n", priv->iw_mode);
+                IWL_WARN(priv, "Unknown mode of operation: %d\n",
+                        priv->iw_mode);
                 return priv->hw_params.bcast_sta_id;
         }
 }
@@ -2895,7 +2896,7 @@ static void iwl3945_rx_reply_alive(struct iwl_priv *priv,
                 queue_delayed_work(priv->workqueue, pwork,
                                    msecs_to_jiffies(5));
         else
-                IWL_WARNING("uCode did not respond OK.\n");
+                IWL_WARN(priv, "uCode did not respond OK.\n");
 }
 
 static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
@@ -3789,7 +3790,7 @@ static void iwl3945_rx_handle(struct iwl_priv *priv)
                         if (rxb && rxb->skb)
                                 iwl3945_tx_cmd_complete(priv, rxb);
                         else
-                                IWL_WARNING("Claim null rxb?\n");
+                                IWL_WARN(priv, "Claim null rxb?\n");
                 }
 
                 /* For now we just don't re-use anything.  We can tweak this
@@ -3960,7 +3961,7 @@ static void iwl3945_dump_nic_error_log(struct iwl_priv *priv)
 
         rc = iwl_grab_nic_access(priv);
         if (rc) {
-                IWL_WARNING("Can not read from adapter at this time.\n");
+                IWL_WARN(priv, "Can not read from adapter at this time.\n");
                 return;
         }
 
@@ -4063,7 +4064,7 @@ static void iwl3945_dump_nic_event_log(struct iwl_priv *priv)
 
         rc = iwl_grab_nic_access(priv);
         if (rc) {
-                IWL_WARNING("Can not read from adapter at this time.\n");
+                IWL_WARN(priv, "Can not read from adapter at this time.\n");
                 return;
         }
 
@@ -4270,9 +4271,9 @@ static void iwl3945_irq_tasklet(struct iwl_priv *priv)
                 IWL_ERROR("Unhandled INTA bits 0x%08x\n", inta & ~handled);
 
         if (inta & ~CSR_INI_SET_MASK) {
-                IWL_WARNING("Disabled INTA bits 0x%08x were pending\n",
+                IWL_WARN(priv, "Disabled INTA bits 0x%08x were pending\n",
                          inta & ~CSR_INI_SET_MASK);
-                IWL_WARNING("   with FH_INT = 0x%08x\n", inta_fh);
+                IWL_WARN(priv, "   with FH_INT = 0x%08x\n", inta_fh);
         }
 
         /* Re-enable all interrupts */
@@ -4323,7 +4324,7 @@ static irqreturn_t iwl3945_isr(int irq, void *data)
 
         if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
                 /* Hardware disappeared */
-                IWL_WARNING("HARDWARE GONE?? INTA == 0x%08x\n", inta);
+                IWL_WARN(priv, "HARDWARE GONE?? INTA == 0x%08x\n", inta);
                 goto unplugged;
         }
 
@@ -4490,7 +4491,7 @@ static int iwl3945_init_channel_map(struct iwl_priv *priv)
         }
 
         if (priv->eeprom39.version < 0x2f) {
-                IWL_WARNING("Unsupported EEPROM version: 0x%04X\n",
+                IWL_WARN(priv, "Unsupported EEPROM version: 0x%04X\n",
                             priv->eeprom39.version);
                 return -EINVAL;
         }
@@ -5583,7 +5584,7 @@ static void iwl3945_alive_start(struct iwl_priv *priv)
 
         rc = iwl_grab_nic_access(priv);
         if (rc) {
-                IWL_WARNING("Can not read RFKILL status from adapter\n");
+                IWL_WARN(priv, "Can not read RFKILL status from adapter\n");
                 return;
         }
 
@@ -5783,12 +5784,12 @@ static int __iwl3945_up(struct iwl_priv *priv)
         int rc, i;
 
         if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
-                IWL_WARNING("Exit pending; will not bring the NIC up\n");
+                IWL_WARN(priv, "Exit pending; will not bring the NIC up\n");
                 return -EIO;
         }
 
         if (test_bit(STATUS_RF_KILL_SW, &priv->status)) {
-                IWL_WARNING("Radio disabled by SW RF kill (module "
+                IWL_WARN(priv, "Radio disabled by SW RF kill (module "
                             "parameter)\n");
                 return -ENODEV;
         }
@@ -5805,7 +5806,7 @@ static int __iwl3945_up(struct iwl_priv *priv)
         else {
                 set_bit(STATUS_RF_KILL_HW, &priv->status);
                 if (!test_bit(STATUS_IN_SUSPEND, &priv->status)) {
-                        IWL_WARNING("Radio disabled by HW RF Kill switch\n");
+                        IWL_WARN(priv, "Radio disabled by HW RF Kill switch\n");
                         return -ENODEV;
                 }
         }
@@ -5929,7 +5930,7 @@ static void iwl3945_bg_rf_kill(struct work_struct *work)
                         IWL_DEBUG_RF_KILL("Can not turn radio back on - "
                                           "disabled by SW switch\n");
                 else
-                        IWL_WARNING("Radio Frequency Kill Switch is On:\n"
+                        IWL_WARN(priv, "Radio Frequency Kill Switch is On:\n"
                                     "Kill switch must be turned off for "
                                     "wireless networking to work.\n");
         }
@@ -5982,7 +5983,7 @@ static void iwl3945_bg_request_scan(struct work_struct *data)
         mutex_lock(&priv->mutex);
 
         if (!iwl3945_is_ready(priv)) {
-                IWL_WARNING("request scan called when driver not ready.\n");
+                IWL_WARN(priv, "request scan called when driver not ready.\n");
                 goto done;
         }
 
@@ -6107,7 +6108,7 @@ static void iwl3945_bg_request_scan(struct work_struct *data)
                 scan->good_CRC_th = IWL_GOOD_CRC_TH;
                 band = IEEE80211_BAND_5GHZ;
         } else {
-                IWL_WARNING("Invalid scan band count\n");
+                IWL_WARN(priv, "Invalid scan band count\n");
                 goto done;
         }
 
@@ -6228,7 +6229,7 @@ static void iwl3945_post_associate(struct iwl_priv *priv)
         rc = iwl3945_send_cmd_pdu(priv, REPLY_RXON_TIMING,
                               sizeof(priv->rxon_timing), &priv->rxon_timing);
         if (rc)
-                IWL_WARNING("REPLY_RXON_TIMING failed - "
+                IWL_WARN(priv, "REPLY_RXON_TIMING failed - "
                             "Attempting to continue.\n");
 
         priv->staging39_rxon.filter_flags |= RXON_FILTER_ASSOC_MSK;
@@ -6608,7 +6609,7 @@ static void iwl3945_config_ap(struct iwl_priv *priv)
                 rc = iwl3945_send_cmd_pdu(priv, REPLY_RXON_TIMING,
                                 sizeof(priv->rxon_timing), &priv->rxon_timing);
                 if (rc)
-                        IWL_WARNING("REPLY_RXON_TIMING failed - "
+                        IWL_WARN(priv, "REPLY_RXON_TIMING failed - "
                                         "Attempting to continue.\n");
 
                 /* FIXME: what should be the assoc_id for AP? */
@@ -6709,7 +6710,7 @@ static int iwl3945_mac_config_interface(struct ieee80211_hw *hw,
                 /* If there is currently a HW scan going on in the background
                  * then we need to cancel it else the RXON below will fail. */
                 if (iwl3945_scan_cancel_timeout(priv, 100)) {
-                        IWL_WARNING("Aborted scan still in progress "
+                        IWL_WARN(priv, "Aborted scan still in progress "
                                     "after 100ms\n");
                         IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
                         mutex_unlock(&priv->mutex);
@@ -7260,7 +7261,7 @@ static ssize_t store_flags(struct device *d,
         if (le32_to_cpu(priv->staging39_rxon.flags) != flags) {
                 /* Cancel any currently running scans... */
                 if (iwl3945_scan_cancel_timeout(priv, 100))
-                        IWL_WARNING("Could not cancel scan.\n");
+                        IWL_WARN(priv, "Could not cancel scan.\n");
                 else {
                         IWL_DEBUG_INFO("Committing rxon.flags = 0x%04X\n",
                                        flags);
@@ -7295,7 +7296,7 @@ static ssize_t store_filter_flags(struct device *d,
         if (le32_to_cpu(priv->staging39_rxon.filter_flags) != filter_flags) {
                 /* Cancel any currently running scans... */
                 if (iwl3945_scan_cancel_timeout(priv, 100))
-                        IWL_WARNING("Could not cancel scan.\n");
+                        IWL_WARN(priv, "Could not cancel scan.\n");
                 else {
                         IWL_DEBUG_INFO("Committing rxon.filter_flags = "
                                        "0x%04X\n", filter_flags);
@@ -8104,7 +8105,7 @@ static int iwl3945_rfkill_soft_rf_kill(void *data, enum rfkill_state state)
                 iwl3945_radio_kill_sw(priv, 1);
                 break;
         default:
-                IWL_WARNING("we received unexpected RFKILL state %d\n", state);
+                IWL_WARN(priv, "received unexpected RFKILL state %d\n", state);
                 break;
         }
 out_unlock: