iwlagn: clean up & autodetect statistics

There's no need to keep both normal and BT statistics
versions around all the time in memory when we only
use a subset of both. So keep only the subsets that
we need in memory, depending on the debug config).

Also, in doing so, we can remove all the calls to
iwl_bt_statistics() in the driver as we'll just
access the copied statistics now.

Finally, also remove this call from the one place
where it might still be needed and automatically
detect what kind of statistics the device is sending
based on their size. This way, we don't need to keep
track of which devices do what any more, which is
good since this is subject to change based on the
ucode version (as some ucode even for non-BT devices
will in fact use BT statistics).

Warn upon encountering a statistics command from the
ucode that isn't known, so we will find such issues
earlier in the future.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Don Fry <donald.h.fry@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>

1 files changed, 2 insertions, 15 deletions

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 23b89c2e71da..20499b764430 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -1705,10 +1705,6 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
         else
                 priv->cmd_queue = IWL_DEFAULT_CMD_QUEUE_NUM;
 
-        if (ucode_capa.flags & IWL_UCODE_TLV_FLAGS_BTSTATS ||
-            (priv->cfg->bt_params && priv->cfg->bt_params->bt_statistics))
-                priv->bt_statistics = true;
-
         /* Copy images into buffers for card's bus-master reads ... */
 
         /* Runtime instructions (first block of data in file) */
@@ -2626,17 +2622,8 @@ static void iwl_bg_run_time_calib_work(struct work_struct *work)
         }
 
         if (priv->start_calib) {
-                if (iwl_bt_statistics(priv)) {
-                        iwl_chain_noise_calibration(priv,
-                                        (void *)&priv->_agn.statistics_bt);
-                        iwl_sensitivity_calibration(priv,
-                                        (void *)&priv->_agn.statistics_bt);
-                } else {
-                        iwl_chain_noise_calibration(priv,
-                                        (void *)&priv->_agn.statistics);
-                        iwl_sensitivity_calibration(priv,
-                                        (void *)&priv->_agn.statistics);
-                }
+                iwl_chain_noise_calibration(priv);
+                iwl_sensitivity_calibration(priv);
         }
 
         mutex_unlock(&priv->mutex);