aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/iwlwifi/iwl-5000.c
diff options
context:
space:
mode:
authorWinkler, Tomas <tomas.winkler@intel.com>2008-12-18 21:37:33 -0500
committerJohn W. Linville <linville@tuxdriver.com>2009-01-29 15:59:17 -0500
commit15b1687cb4f45b87ddbe4dfc7759ff5bb69497d2 (patch)
treec4e3e70b0d9b7ba877e52cd0a5116c4411bbf8e1 /drivers/net/wireless/iwlwifi/iwl-5000.c
parent39aadf8c29ad959e823efca15381bea9d0770b1e (diff)
iwlwifi: replace IWL_ERROR with IWL_ERR
IWL_ERR doesn't use hidden priv pointer. Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Zhu Yi <yi.zhu@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/iwl-5000.c')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-5000.c29
1 files changed, 16 insertions, 13 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
index 448bdb65bffe..76d86fe2b41d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-5000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
@@ -289,7 +289,7 @@ static u32 eeprom_indirect_address(const struct iwl_priv *priv, u32 address)
289 offset = iwl_eeprom_query16(priv, EEPROM_5000_LINK_OTHERS); 289 offset = iwl_eeprom_query16(priv, EEPROM_5000_LINK_OTHERS);
290 break; 290 break;
291 default: 291 default:
292 IWL_ERROR("illegal indirect type: 0x%X\n", 292 IWL_ERR(priv, "illegal indirect type: 0x%X\n",
293 address & INDIRECT_TYPE_MSK); 293 address & INDIRECT_TYPE_MSK);
294 break; 294 break;
295 } 295 }
@@ -384,7 +384,8 @@ static void iwl5000_chain_noise_reset(struct iwl_priv *priv)
384 ret = iwl_send_cmd_pdu(priv, REPLY_PHY_CALIBRATION_CMD, 384 ret = iwl_send_cmd_pdu(priv, REPLY_PHY_CALIBRATION_CMD,
385 sizeof(cmd), &cmd); 385 sizeof(cmd), &cmd);
386 if (ret) 386 if (ret)
387 IWL_ERROR("Could not send REPLY_PHY_CALIBRATION_CMD\n"); 387 IWL_ERR(priv,
388 "Could not send REPLY_PHY_CALIBRATION_CMD\n");
388 data->state = IWL_CHAIN_NOISE_ACCUMULATE; 389 data->state = IWL_CHAIN_NOISE_ACCUMULATE;
389 IWL_DEBUG_CALIB("Run chain_noise_calibrate\n"); 390 IWL_DEBUG_CALIB("Run chain_noise_calibrate\n");
390 } 391 }
@@ -507,7 +508,7 @@ static void iwl5000_rx_calib_result(struct iwl_priv *priv,
507 index = IWL_CALIB_BASE_BAND; 508 index = IWL_CALIB_BASE_BAND;
508 break; 509 break;
509 default: 510 default:
510 IWL_ERROR("Unknown calibration notification %d\n", 511 IWL_ERR(priv, "Unknown calibration notification %d\n",
511 hdr->op_code); 512 hdr->op_code);
512 return; 513 return;
513 } 514 }
@@ -589,12 +590,12 @@ static int iwl5000_load_given_ucode(struct iwl_priv *priv,
589 ret = wait_event_interruptible_timeout(priv->wait_command_queue, 590 ret = wait_event_interruptible_timeout(priv->wait_command_queue,
590 priv->ucode_write_complete, 5 * HZ); 591 priv->ucode_write_complete, 5 * HZ);
591 if (ret == -ERESTARTSYS) { 592 if (ret == -ERESTARTSYS) {
592 IWL_ERROR("Could not load the INST uCode section due " 593 IWL_ERR(priv, "Could not load the INST uCode section due "
593 "to interrupt\n"); 594 "to interrupt\n");
594 return ret; 595 return ret;
595 } 596 }
596 if (!ret) { 597 if (!ret) {
597 IWL_ERROR("Could not load the INST uCode section\n"); 598 IWL_ERR(priv, "Could not load the INST uCode section\n");
598 return -ETIMEDOUT; 599 return -ETIMEDOUT;
599 } 600 }
600 601
@@ -610,11 +611,11 @@ static int iwl5000_load_given_ucode(struct iwl_priv *priv,
610 ret = wait_event_interruptible_timeout(priv->wait_command_queue, 611 ret = wait_event_interruptible_timeout(priv->wait_command_queue,
611 priv->ucode_write_complete, 5 * HZ); 612 priv->ucode_write_complete, 5 * HZ);
612 if (ret == -ERESTARTSYS) { 613 if (ret == -ERESTARTSYS) {
613 IWL_ERROR("Could not load the INST uCode section due " 614 IWL_ERR(priv, "Could not load the INST uCode section due "
614 "to interrupt\n"); 615 "to interrupt\n");
615 return ret; 616 return ret;
616 } else if (!ret) { 617 } else if (!ret) {
617 IWL_ERROR("Could not load the DATA uCode section\n"); 618 IWL_ERR(priv, "Could not load the DATA uCode section\n");
618 return -ETIMEDOUT; 619 return -ETIMEDOUT;
619 } else 620 } else
620 ret = 0; 621 ret = 0;
@@ -826,8 +827,9 @@ static int iwl5000_hw_set_hw_params(struct iwl_priv *priv)
826{ 827{
827 if ((priv->cfg->mod_params->num_of_queues > IWL50_NUM_QUEUES) || 828 if ((priv->cfg->mod_params->num_of_queues > IWL50_NUM_QUEUES) ||
828 (priv->cfg->mod_params->num_of_queues < IWL_MIN_NUM_QUEUES)) { 829 (priv->cfg->mod_params->num_of_queues < IWL_MIN_NUM_QUEUES)) {
829 IWL_ERROR("invalid queues_num, should be between %d and %d\n", 830 IWL_ERR(priv,
830 IWL_MIN_NUM_QUEUES, IWL50_NUM_QUEUES); 831 "invalid queues_num, should be between %d and %d\n",
832 IWL_MIN_NUM_QUEUES, IWL50_NUM_QUEUES);
831 return -EINVAL; 833 return -EINVAL;
832 } 834 }
833 835
@@ -1201,8 +1203,9 @@ static int iwl5000_tx_status_reply_tx(struct iwl_priv *priv,
1201 1203
1202 sc = le16_to_cpu(hdr->seq_ctrl); 1204 sc = le16_to_cpu(hdr->seq_ctrl);
1203 if (idx != (SEQ_TO_SN(sc) & 0xff)) { 1205 if (idx != (SEQ_TO_SN(sc) & 0xff)) {
1204 IWL_ERROR("BUG_ON idx doesn't match seq control" 1206 IWL_ERR(priv,
1205 " idx=%d, seq_idx=%d, seq=%d\n", 1207 "BUG_ON idx doesn't match seq control"
1208 " idx=%d, seq_idx=%d, seq=%d\n",
1206 idx, SEQ_TO_SN(sc), 1209 idx, SEQ_TO_SN(sc),
1207 hdr->seq_ctrl); 1210 hdr->seq_ctrl);
1208 return -1; 1211 return -1;
@@ -1258,7 +1261,7 @@ static void iwl5000_rx_reply_tx(struct iwl_priv *priv,
1258 int freed; 1261 int freed;
1259 1262
1260 if ((index >= txq->q.n_bd) || (iwl_queue_used(&txq->q, index) == 0)) { 1263 if ((index >= txq->q.n_bd) || (iwl_queue_used(&txq->q, index) == 0)) {
1261 IWL_ERROR("Read index for DMA queue txq_id (%d) index %d " 1264 IWL_ERR(priv, "Read index for DMA queue txq_id (%d) index %d "
1262 "is out of range [0-%d] %d %d\n", txq_id, 1265 "is out of range [0-%d] %d %d\n", txq_id,
1263 index, txq->q.n_bd, txq->q.write_ptr, 1266 index, txq->q.n_bd, txq->q.write_ptr,
1264 txq->q.read_ptr); 1267 txq->q.read_ptr);
@@ -1332,7 +1335,7 @@ static void iwl5000_rx_reply_tx(struct iwl_priv *priv,
1332 iwl_txq_check_empty(priv, sta_id, tid, txq_id); 1335 iwl_txq_check_empty(priv, sta_id, tid, txq_id);
1333 1336
1334 if (iwl_check_bits(status, TX_ABORT_REQUIRED_MSK)) 1337 if (iwl_check_bits(status, TX_ABORT_REQUIRED_MSK))
1335 IWL_ERROR("TODO: Implement Tx ABORT REQUIRED!!!\n"); 1338 IWL_ERR(priv, "TODO: Implement Tx ABORT REQUIRED!!!\n");
1336} 1339}
1337 1340
1338/* Currently 5000 is the superset of everything */ 1341/* Currently 5000 is the superset of everything */