cfg80211 API for channels/bitrates, mac80211 and driver conversion

This patch creates new cfg80211 wiphy API for channel and bitrate
registration and converts mac80211 and drivers to the new API. The
old mac80211 API is completely ripped out. All drivers (except ath5k)
are updated to the new API, in many cases I expect that optimisations
can be done.

Along with the regulatory code I've also ripped out the
IEEE80211_HW_DEFAULT_REG_DOMAIN_CONFIGURED flag, I believe it to be
unnecessary if the hardware simply gives us whatever channels it wants
to support and we then enable/disable them as required, which is pretty
much required for travelling.

Additionally, the patch adds proper "basic" rate handling for STA
mode interface, AP mode interface will have to have new API added
to allow userspace to set the basic rate set, currently it'll be
empty... However, the basic rate handling will need to be moved to
the BSS conf stuff.

I do expect there to be bugs in this, especially wrt. transmit
power handling where I'm basically clueless about how it should work.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 43 insertions, 39 deletions

diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
index 660671f17a3b..48a6a85355ec 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
@@ -139,7 +139,7 @@ struct iwl4965_lq_sta {
         u8 valid_antenna;
         u8 is_green;
         u8 is_dup;
-        u8 phymode;
+        enum ieee80211_band band;
         u8 ibss_sta_added;
 
         /* The following are bitmaps of rates; IWL_RATE_6M_MASK, etc. */
@@ -563,7 +563,8 @@ static void rs_mcs_from_tbl(struct iwl4965_rate *mcs_rate,
  * fill "search" or "active" tx mode table.
  */
 static int rs_get_tbl_info_from_mcs(const struct iwl4965_rate *mcs_rate,
-                                    int phymode, struct iwl4965_scale_tbl_info *tbl,
+                                    enum ieee80211_band band,
+                                    struct iwl4965_scale_tbl_info *tbl,
                                     int *rate_idx)
 {
         int index;
@@ -588,7 +589,7 @@ static int rs_get_tbl_info_from_mcs(const struct iwl4965_rate *mcs_rate,
                         tbl->lq_type = LQ_NONE;
                 else {
 
-                        if (phymode == MODE_IEEE80211A)
+                        if (band == IEEE80211_BAND_5GHZ)
                                 tbl->lq_type = LQ_A;
                         else
                                 tbl->lq_type = LQ_G;
@@ -766,7 +767,7 @@ static void rs_get_lower_rate(struct iwl4965_lq_sta *lq_sta,
         if (!is_legacy(tbl->lq_type) && (!ht_possible || !scale_index)) {
                 switch_to_legacy = 1;
                 scale_index = rs_ht_to_legacy[scale_index];
-                if (lq_sta->phymode == MODE_IEEE80211A)
+                if (lq_sta->band == IEEE80211_BAND_5GHZ)
                         tbl->lq_type = LQ_A;
                 else
                         tbl->lq_type = LQ_G;
@@ -784,7 +785,7 @@ static void rs_get_lower_rate(struct iwl4965_lq_sta *lq_sta,
         /* Mask with station rate restriction */
         if (is_legacy(tbl->lq_type)) {
                 /* supp_rates has no CCK bits in A mode */
-                if (lq_sta->phymode == (u8) MODE_IEEE80211A)
+                if (lq_sta->band == IEEE80211_BAND_5GHZ)
                         rate_mask  = (u16)(rate_mask &
                            (lq_sta->supp_rates << IWL_FIRST_OFDM_RATE));
                 else
@@ -883,9 +884,9 @@ static void rs_tx_status(void *priv_rate, struct net_device *dev,
         search_win = (struct iwl4965_rate_scale_data *)
             &(search_tbl->win[0]);
 
-        tx_mcs.rate_n_flags = tx_resp->control.tx_rate;
+        tx_mcs.rate_n_flags = tx_resp->control.tx_rate->hw_value;
 
-        rs_get_tbl_info_from_mcs(&tx_mcs, priv->phymode,
+        rs_get_tbl_info_from_mcs(&tx_mcs, priv->band,
                                   &tbl_type, &rs_index);
         if ((rs_index < 0) || (rs_index >= IWL_RATE_COUNT)) {
                 IWL_DEBUG_RATE("bad rate index at: %d rate 0x%X\n",
@@ -918,7 +919,7 @@ static void rs_tx_status(void *priv_rate, struct net_device *dev,
                  * Each tx attempt steps one entry deeper in the rate table. */
                 tx_mcs.rate_n_flags =
                     le32_to_cpu(table->rs_table[index].rate_n_flags);
-                rs_get_tbl_info_from_mcs(&tx_mcs, priv->phymode,
+                rs_get_tbl_info_from_mcs(&tx_mcs, priv->band,
                                           &tbl_type, &rs_index);
 
                 /* If type matches "search" table,
@@ -959,12 +960,12 @@ static void rs_tx_status(void *priv_rate, struct net_device *dev,
          * else look up the rate that was, finally, successful.
          */
         if (!tx_resp->retry_count)
-                tx_mcs.rate_n_flags = tx_resp->control.tx_rate;
+                tx_mcs.rate_n_flags = tx_resp->control.tx_rate->hw_value;
         else
                 tx_mcs.rate_n_flags =
                         le32_to_cpu(table->rs_table[index].rate_n_flags);
 
-        rs_get_tbl_info_from_mcs(&tx_mcs, priv->phymode,
+        rs_get_tbl_info_from_mcs(&tx_mcs, priv->band,
                                   &tbl_type, &rs_index);
 
         /* Update frame history window with "success" if Tx got ACKed ... */
@@ -1801,7 +1802,7 @@ static void rs_rate_scale_perform(struct iwl4965_priv *priv,
         is_green = lq_sta->is_green;
 
         /* current tx rate */
-        index = sta->last_txrate;
+        index = sta->last_txrate_idx;
 
         IWL_DEBUG_RATE("Rate scale index %d for type %d\n", index,
                        tbl->lq_type);
@@ -1814,7 +1815,7 @@ static void rs_rate_scale_perform(struct iwl4965_priv *priv,
 
         /* mask with station rate restriction */
         if (is_legacy(tbl->lq_type)) {
-                if (lq_sta->phymode == (u8) MODE_IEEE80211A)
+                if (lq_sta->band == IEEE80211_BAND_5GHZ)
                         /* supp_rates has no CCK bits in A mode */
                         rate_scale_index_msk = (u16) (rate_mask &
                                 (lq_sta->supp_rates << IWL_FIRST_OFDM_RATE));
@@ -2134,15 +2135,15 @@ static void rs_rate_scale_perform(struct iwl4965_priv *priv,
 out:
         rs_mcs_from_tbl(&tbl->current_rate, tbl, index, is_green);
         i = index;
-        sta->last_txrate = i;
+        sta->last_txrate_idx = i;
 
-        /* sta->txrate is an index to A mode rates which start
+        /* sta->txrate_idx is an index to A mode rates which start
          * at IWL_FIRST_OFDM_RATE
          */
-        if (lq_sta->phymode == (u8) MODE_IEEE80211A)
-                sta->txrate = i - IWL_FIRST_OFDM_RATE;
+        if (lq_sta->band == IEEE80211_BAND_5GHZ)
+                sta->txrate_idx = i - IWL_FIRST_OFDM_RATE;
         else
-                sta->txrate = i;
+                sta->txrate_idx = i;
 
         return;
 }
@@ -2164,7 +2165,7 @@ static void rs_initialize_lq(struct iwl4965_priv *priv,
                 goto out;
 
         lq_sta = (struct iwl4965_lq_sta *)sta->rate_ctrl_priv;
-        i = sta->last_txrate;
+        i = sta->last_txrate_idx;
 
         if ((lq_sta->lq.sta_id == 0xff) &&
             (priv->iw_mode == IEEE80211_IF_TYPE_IBSS))
@@ -2188,7 +2189,7 @@ static void rs_initialize_lq(struct iwl4965_priv *priv,
                 mcs_rate.rate_n_flags |= RATE_MCS_CCK_MSK;
 
         tbl->antenna_type = ANT_AUX;
-        rs_get_tbl_info_from_mcs(&mcs_rate, priv->phymode, tbl, &rate_idx);
+        rs_get_tbl_info_from_mcs(&mcs_rate, priv->band, tbl, &rate_idx);
         if (!rs_is_ant_connected(priv->valid_antenna, tbl->antenna_type))
             rs_toggle_antenna(&mcs_rate, tbl);
 
@@ -2202,7 +2203,8 @@ static void rs_initialize_lq(struct iwl4965_priv *priv,
 }
 
 static void rs_get_rate(void *priv_rate, struct net_device *dev,
-                        struct ieee80211_hw_mode *mode, struct sk_buff *skb,
+                        struct ieee80211_supported_band *sband,
+                        struct sk_buff *skb,
                         struct rate_selection *sel)
 {
 
@@ -2224,14 +2226,14 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
         fc = le16_to_cpu(hdr->frame_control);
         if (!ieee80211_is_data(fc) || is_multicast_ether_addr(hdr->addr1) ||
             !sta || !sta->rate_ctrl_priv) {
-                sel->rate = rate_lowest(local, local->oper_hw_mode, sta);
+                sel->rate = rate_lowest(local, sband, sta);
                 if (sta)
                         sta_info_put(sta);
                 return;
         }
 
         lq_sta = (struct iwl4965_lq_sta *)sta->rate_ctrl_priv;
-        i = sta->last_txrate;
+        i = sta->last_txrate_idx;
 
         if ((priv->iw_mode == IEEE80211_IF_TYPE_IBSS) &&
             !lq_sta->ibss_sta_added) {
@@ -2256,7 +2258,7 @@ static void rs_get_rate(void *priv_rate, struct net_device *dev,
 
  done:
         if ((i < 0) || (i > IWL_RATE_COUNT)) {
-                sel->rate = rate_lowest(local, local->oper_hw_mode, sta);
+                sel->rate = rate_lowest(local, sband, sta);
                 return;
         }
         sta_info_put(sta);
@@ -2291,13 +2293,15 @@ static void rs_rate_init(void *priv_rate, void *priv_sta,
 {
         int i, j;
         struct ieee80211_conf *conf = &local->hw.conf;
-        struct ieee80211_hw_mode *mode = local->oper_hw_mode;
+        struct ieee80211_supported_band *sband;
         struct iwl4965_priv *priv = (struct iwl4965_priv *)priv_rate;
         struct iwl4965_lq_sta *lq_sta = priv_sta;
 
+        sband = local->hw.wiphy->bands[local->hw.conf.channel->band];
+
         lq_sta->flush_timer = 0;
-        lq_sta->supp_rates = sta->supp_rates;
-        sta->txrate = 3;
+        lq_sta->supp_rates = sta->supp_rates[sband->band];
+        sta->txrate_idx = 3;
         for (j = 0; j < LQ_SIZE; j++)
                 for (i = 0; i < IWL_RATE_COUNT; i++)
                         rs_rate_scale_clear_window(&(lq_sta->lq_info[j].win[i]));
@@ -2332,15 +2336,15 @@ static void rs_rate_init(void *priv_rate, void *priv_sta,
         }
 
         /* Find highest tx rate supported by hardware and destination station */
-        for (i = 0; i < mode->num_rates; i++) {
-                if ((sta->supp_rates & BIT(i)) &&
-                    (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
-                        sta->txrate = i;
-        }
-        sta->last_txrate = sta->txrate;
+        for (i = 0; i < sband->n_bitrates; i++)
+                if (sta->supp_rates[sband->band] & BIT(i))
+                        sta->txrate_idx = i;
+
+        sta->last_txrate_idx = sta->txrate_idx;
+        /* WTF is with this bogus comment? A doesn't have cck rates */
         /* For MODE_IEEE80211A, cck rates are at end of rate table */
-        if (local->hw.conf.phymode == MODE_IEEE80211A)
-                sta->last_txrate += IWL_FIRST_OFDM_RATE;
+        if (local->hw.conf.channel->band == IEEE80211_BAND_5GHZ)
+                sta->last_txrate_idx += IWL_FIRST_OFDM_RATE;
 
         lq_sta->is_dup = 0;
         lq_sta->valid_antenna = priv->valid_antenna;
@@ -2349,7 +2353,7 @@ static void rs_rate_init(void *priv_rate, void *priv_sta,
         lq_sta->active_rate = priv->active_rate;
         lq_sta->active_rate &= ~(0x1000);
         lq_sta->active_rate_basic = priv->active_rate_basic;
-        lq_sta->phymode = priv->phymode;
+        lq_sta->band = priv->band;
 #ifdef CONFIG_IWL4965_HT
         /*
          * active_siso_rate mask includes 9 MBits (bit 5), and CCK (bits 0-3),
@@ -2401,7 +2405,7 @@ static void rs_fill_link_cmd(struct iwl4965_lq_sta *lq_sta,
         rs_dbgfs_set_mcs(lq_sta, tx_mcs, index);
 
         /* Interpret rate_n_flags */
-        rs_get_tbl_info_from_mcs(tx_mcs, lq_sta->phymode,
+        rs_get_tbl_info_from_mcs(tx_mcs, lq_sta->band,
                                   &tbl_type, &rate_idx);
 
         /* How many times should we repeat the initial rate? */
@@ -2455,7 +2459,7 @@ static void rs_fill_link_cmd(struct iwl4965_lq_sta *lq_sta,
                         index++;
                 }
 
-                rs_get_tbl_info_from_mcs(&new_rate, lq_sta->phymode, &tbl_type,
+                rs_get_tbl_info_from_mcs(&new_rate, lq_sta->band, &tbl_type,
                                                 &rate_idx);
 
                 /* Indicate to uCode which entries might be MIMO.
@@ -2542,7 +2546,7 @@ static void rs_dbgfs_set_mcs(struct iwl4965_lq_sta *lq_sta,
 {
         u32 base_rate;
 
-        if (lq_sta->phymode == (u8) MODE_IEEE80211A)
+        if (lq_sta->band == IEEE80211_BAND_5GHZ)
                 base_rate = 0x800D;
         else
                 base_rate = 0x820A;
@@ -2802,7 +2806,7 @@ int iwl4965_fill_rs_info(struct ieee80211_hw *hw, char *buf, u8 sta_id)
 
         cnt += sprintf(&buf[cnt], "\nrate scale type %d antenna %d "
                          "active_search %d rate index %d\n", lq_type, antenna,
-                         lq_sta->search_better_tbl, sta->last_txrate);
+                         lq_sta->search_better_tbl, sta->last_txrate_idx);
 
         sta_info_put(sta);
         return cnt;