diff options
author | Eugene Teo <eugene.teo@eugeneteo.net> | 2006-03-19 22:21:46 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2006-03-23 16:16:57 -0500 |
commit | 8abceaf1cf44b9d95bcc366fa277b33e292141c4 (patch) | |
tree | 42d669e650bf3891c76f9aefa5f749c60e81a242 /drivers/net/wireless/hostap | |
parent | 54b85f489bdfafc9306dfcc21e0d2687c34c3b34 (diff) |
[PATCH] hostap: Fix double free in prism2_config() error path
The Coverity checker (CID: 930) spotted this double free on error path
(allocation failure). Do not free these here since generic error path
will take care of this.
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Jouni Malinen <jkmaline@cc.hut.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/hostap')
-rw-r--r-- | drivers/net/wireless/hostap/hostap_cs.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/wireless/hostap/hostap_cs.c b/drivers/net/wireless/hostap/hostap_cs.c index f8f4503475f9..d335b250923a 100644 --- a/drivers/net/wireless/hostap/hostap_cs.c +++ b/drivers/net/wireless/hostap/hostap_cs.c | |||
@@ -585,8 +585,6 @@ static int prism2_config(dev_link_t *link) | |||
585 | parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL); | 585 | parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL); |
586 | hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL); | 586 | hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL); |
587 | if (parse == NULL || hw_priv == NULL) { | 587 | if (parse == NULL || hw_priv == NULL) { |
588 | kfree(parse); | ||
589 | kfree(hw_priv); | ||
590 | ret = -ENOMEM; | 588 | ret = -ENOMEM; |
591 | goto failed; | 589 | goto failed; |
592 | } | 590 | } |