aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/brcm80211
diff options
context:
space:
mode:
authorHante Meuleman <meuleman@broadcom.com>2012-09-19 16:21:09 -0400
committerJohn W. Linville <linville@tuxdriver.com>2012-09-24 15:02:05 -0400
commit30c52bcf5c294d736b2fccdf7afd93b3af7a95bc (patch)
treee0ee85603cbd6db5f03ae18143d1b84f60edab83 /drivers/net/wireless/brcm80211
parente58060723c91a2345318fe809fc99945776a7a25 (diff)
brcmfmac: fix debug printout of event data.
Some events result in printing of the buffer when debug is enabled. This printing was not very efficient. Changed to macro so it comes out nice and clean without filling log buffer. Reviewed-by: Arend Van Spriel <arend@broadcom.com> Signed-off-by: Hante Meuleman <meuleman@broadcom.com> Signed-off-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/brcm80211')
-rw-r--r--drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c13
-rw-r--r--drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h2
2 files changed, 6 insertions, 9 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
index c45270a2a1d9..fbecde73f904 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
@@ -433,13 +433,7 @@ brcmf_c_show_host_event(struct brcmf_event_msg *event, void *event_data)
433 } 433 }
434 434
435 /* show any appended data */ 435 /* show any appended data */
436 if (datalen) { 436 brcmf_dbg_hex_dump(datalen, event_data, datalen, "Received data");
437 buf = (unsigned char *) event_data;
438 brcmf_dbg(EVENT, " data (%d) : ", datalen);
439 for (i = 0; i < datalen; i++)
440 brcmf_dbg(EVENT, " 0x%02x ", *buf++);
441 brcmf_dbg(EVENT, "\n");
442 }
443} 437}
444#endif /* DEBUG */ 438#endif /* DEBUG */
445 439
@@ -530,8 +524,9 @@ brcmf_c_host_event(struct brcmf_pub *drvr, int *ifidx, void *pktdata,
530 } 524 }
531 525
532#ifdef DEBUG 526#ifdef DEBUG
533 brcmf_c_show_host_event(event, event_data); 527 if (BRCMF_EVENT_ON())
534#endif /* DEBUG */ 528 brcmf_c_show_host_event(event, event_data);
529#endif /* DEBUG */
535 530
536 return 0; 531 return 0;
537} 532}
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h b/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h
index b784920532d3..fb508c2256dd 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h
@@ -55,6 +55,7 @@ do { \
55#define BRCMF_HDRS_ON() (brcmf_msg_level & BRCMF_HDRS_VAL) 55#define BRCMF_HDRS_ON() (brcmf_msg_level & BRCMF_HDRS_VAL)
56#define BRCMF_BYTES_ON() (brcmf_msg_level & BRCMF_BYTES_VAL) 56#define BRCMF_BYTES_ON() (brcmf_msg_level & BRCMF_BYTES_VAL)
57#define BRCMF_GLOM_ON() (brcmf_msg_level & BRCMF_GLOM_VAL) 57#define BRCMF_GLOM_ON() (brcmf_msg_level & BRCMF_GLOM_VAL)
58#define BRCMF_EVENT_ON() (brcmf_msg_level & BRCMF_EVENT_VAL)
58 59
59#else /* (defined DEBUG) || (defined DEBUG) */ 60#else /* (defined DEBUG) || (defined DEBUG) */
60 61
@@ -65,6 +66,7 @@ do { \
65#define BRCMF_HDRS_ON() 0 66#define BRCMF_HDRS_ON() 0
66#define BRCMF_BYTES_ON() 0 67#define BRCMF_BYTES_ON() 0
67#define BRCMF_GLOM_ON() 0 68#define BRCMF_GLOM_ON() 0
69#define BRCMF_EVENT_ON() 0
68 70
69#endif /* defined(DEBUG) */ 71#endif /* defined(DEBUG) */
70 72