diff options
author | Arend van Spriel <arend@broadcom.com> | 2015-01-25 14:31:43 -0500 |
---|---|---|
committer | Kalle Valo <kvalo@codeaurora.org> | 2015-01-29 03:00:19 -0500 |
commit | 4165fe9a9287aa9c8e7e4152c21ee179d49d129e (patch) | |
tree | 56f5a0b9200202954125c3cadb1e8a7c2ffba6b1 /drivers/net/wireless/brcm80211 | |
parent | 7f52c81d02a27943e0c45103d7d10f629b0b58ae (diff) |
brcmfmac: fix nvram processing
The nvram file can hold a key=value combination in which the value
may have spaces, ie. 'RAW1=80 02 fe ff'. The parsing functionality
did not deal with this so it gives an error message:
[621746.311635] brcmfmac: brcmf_nvram_handle_key
warning: ln=90:col=11: '=' expected, skip invalid key entry
because RAW1=80 is being considerd as key=value pair and it expects
'=' sign after '02' for next key=value pair. This entry can be
completely ignored as firmware does not need it.
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Daniel (Deognyoun) Kim <dekim@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/brcm80211')
-rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/firmware.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/brcm80211/brcmfmac/firmware.c index 1ff787d1a36b..9cb99152ad17 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/firmware.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/firmware.c | |||
@@ -103,7 +103,11 @@ static enum nvram_parser_state brcmf_nvram_handle_key(struct nvram_parser *nvp) | |||
103 | 103 | ||
104 | c = nvp->fwnv->data[nvp->pos]; | 104 | c = nvp->fwnv->data[nvp->pos]; |
105 | if (c == '=') { | 105 | if (c == '=') { |
106 | st = VALUE; | 106 | /* ignore RAW1 by treating as comment */ |
107 | if (strncmp(&nvp->fwnv->data[nvp->entry], "RAW1", 4) == 0) | ||
108 | st = COMMENT; | ||
109 | else | ||
110 | st = VALUE; | ||
107 | } else if (!is_nvram_char(c)) { | 111 | } else if (!is_nvram_char(c)) { |
108 | brcmf_dbg(INFO, "warning: ln=%d:col=%d: '=' expected, skip invalid key entry\n", | 112 | brcmf_dbg(INFO, "warning: ln=%d:col=%d: '=' expected, skip invalid key entry\n", |
109 | nvp->line, nvp->column); | 113 | nvp->line, nvp->column); |