diff options
author | Joe Perches <joe@perches.com> | 2012-06-04 08:44:17 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-06-06 12:31:33 -0400 |
commit | 2c208890c6d4e16076c6664137703ec813e8fa6c (patch) | |
tree | dd25049d7fdaf305679acc08f4b36fbcdbdb0213 /drivers/net/wireless/b43legacy | |
parent | 6469933605a3ecdfa66b98160cde98ecd256cb3f (diff) |
wireless: Remove casts to same type
Adding casts of objects to the same type is unnecessary
and confusing for a human reader.
For example, this cast:
int y;
int *p = (int *)&y;
I used the coccinelle script below to find and remove these
unnecessary casts. I manually removed the conversions this
script produces of casts with __force, __iomem and __user.
@@
type T;
T *p;
@@
- (T *)p
+ p
Neatened the mwifiex_deauthenticate_infra function which
was doing odd things with array pointers and not using
is_zero_ether_addr.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wireless/b43legacy')
-rw-r--r-- | drivers/net/wireless/b43legacy/dma.c | 2 | ||||
-rw-r--r-- | drivers/net/wireless/b43legacy/xmit.c | 6 |
2 files changed, 3 insertions, 5 deletions
diff --git a/drivers/net/wireless/b43legacy/dma.c b/drivers/net/wireless/b43legacy/dma.c index f1f8bd09bd87..ff50cb4290e4 100644 --- a/drivers/net/wireless/b43legacy/dma.c +++ b/drivers/net/wireless/b43legacy/dma.c | |||
@@ -52,7 +52,7 @@ struct b43legacy_dmadesc32 *op32_idx2desc(struct b43legacy_dmaring *ring, | |||
52 | desc = ring->descbase; | 52 | desc = ring->descbase; |
53 | desc = &(desc[slot]); | 53 | desc = &(desc[slot]); |
54 | 54 | ||
55 | return (struct b43legacy_dmadesc32 *)desc; | 55 | return desc; |
56 | } | 56 | } |
57 | 57 | ||
58 | static void op32_fill_descriptor(struct b43legacy_dmaring *ring, | 58 | static void op32_fill_descriptor(struct b43legacy_dmaring *ring, |
diff --git a/drivers/net/wireless/b43legacy/xmit.c b/drivers/net/wireless/b43legacy/xmit.c index a8012f2749ee..b8ffea6f5c64 100644 --- a/drivers/net/wireless/b43legacy/xmit.c +++ b/drivers/net/wireless/b43legacy/xmit.c | |||
@@ -269,8 +269,7 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev, | |||
269 | b43legacy_generate_plcp_hdr((struct b43legacy_plcp_hdr4 *) | 269 | b43legacy_generate_plcp_hdr((struct b43legacy_plcp_hdr4 *) |
270 | (&txhdr->plcp), plcp_fragment_len, | 270 | (&txhdr->plcp), plcp_fragment_len, |
271 | rate); | 271 | rate); |
272 | b43legacy_generate_plcp_hdr((struct b43legacy_plcp_hdr4 *) | 272 | b43legacy_generate_plcp_hdr(&txhdr->plcp_fb, plcp_fragment_len, |
273 | (&txhdr->plcp_fb), plcp_fragment_len, | ||
274 | rate_fb->hw_value); | 273 | rate_fb->hw_value); |
275 | 274 | ||
276 | /* PHY TX Control word */ | 275 | /* PHY TX Control word */ |
@@ -340,8 +339,7 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev, | |||
340 | b43legacy_generate_plcp_hdr((struct b43legacy_plcp_hdr4 *) | 339 | b43legacy_generate_plcp_hdr((struct b43legacy_plcp_hdr4 *) |
341 | (&txhdr->rts_plcp), | 340 | (&txhdr->rts_plcp), |
342 | len, rts_rate); | 341 | len, rts_rate); |
343 | b43legacy_generate_plcp_hdr((struct b43legacy_plcp_hdr4 *) | 342 | b43legacy_generate_plcp_hdr(&txhdr->rts_plcp_fb, |
344 | (&txhdr->rts_plcp_fb), | ||
345 | len, rts_rate_fb); | 343 | len, rts_rate_fb); |
346 | hdr = (struct ieee80211_hdr *)(&txhdr->rts_frame); | 344 | hdr = (struct ieee80211_hdr *)(&txhdr->rts_frame); |
347 | txhdr->rts_dur_fb = hdr->duration_id; | 345 | txhdr->rts_dur_fb = hdr->duration_id; |