aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/b43legacy/main.c
diff options
context:
space:
mode:
authorMichael Buesch <mb@bu3sch.de>2008-01-09 14:15:31 -0500
committerDavid S. Miller <davem@davemloft.net>2008-01-28 18:10:42 -0500
commitbfe6a50156ab0c33729378fae7038bce3c6c5184 (patch)
tree4d29fdaa77eef7772eadab31033227e49e67c911 /drivers/net/wireless/b43legacy/main.c
parenta8bdf29c6cd117644d27677962fe832b33036c77 (diff)
b43legacy: Remove the PHY spinlock
This fixes a sparse warning about weird locking. The spinlock is not needed, so simply remove it. This also adds some sanity checks to the PHY and radio locking to protect against recursive locking. Signed-off-by: Michael Buesch <mb@bu3sch.de> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/b43legacy/main.c')
-rw-r--r--drivers/net/wireless/b43legacy/main.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
index 2d5735ddad8c..4ed4243feeaa 100644
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -2847,8 +2847,6 @@ static void setup_struct_phy_for_init(struct b43legacy_wldev *dev,
2847 memset(phy->minlowsig, 0xFF, sizeof(phy->minlowsig)); 2847 memset(phy->minlowsig, 0xFF, sizeof(phy->minlowsig));
2848 memset(phy->minlowsigpos, 0, sizeof(phy->minlowsigpos)); 2848 memset(phy->minlowsigpos, 0, sizeof(phy->minlowsigpos));
2849 2849
2850 /* Flags */
2851 phy->locked = 0;
2852 /* Assume the radio is enabled. If it's not enabled, the state will 2850 /* Assume the radio is enabled. If it's not enabled, the state will
2853 * immediately get fixed on the first periodic work run. */ 2851 * immediately get fixed on the first periodic work run. */
2854 dev->radio_hw_enable = 1; 2852 dev->radio_hw_enable = 1;
@@ -2881,7 +2879,6 @@ static void setup_struct_phy_for_init(struct b43legacy_wldev *dev,
2881 phy->lofcal = 0xFFFF; 2879 phy->lofcal = 0xFFFF;
2882 phy->initval = 0xFFFF; 2880 phy->initval = 0xFFFF;
2883 2881
2884 spin_lock_init(&phy->lock);
2885 phy->interfmode = B43legacy_INTERFMODE_NONE; 2882 phy->interfmode = B43legacy_INTERFMODE_NONE;
2886 phy->channel = 0xFF; 2883 phy->channel = 0xFF;
2887} 2884}
@@ -3013,7 +3010,6 @@ static void prepare_phy_data_for_init(struct b43legacy_wldev *dev)
3013 3010
3014 /* Flags */ 3011 /* Flags */
3015 phy->calibrated = 0; 3012 phy->calibrated = 0;
3016 phy->locked = 0;
3017 3013
3018 if (phy->_lo_pairs) 3014 if (phy->_lo_pairs)
3019 memset(phy->_lo_pairs, 0, 3015 memset(phy->_lo_pairs, 0,