diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2009-06-02 07:01:37 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-06-03 14:06:13 -0400 |
commit | 19d337dff95cbf76edd3ad95c0cee2732c3e1ec5 (patch) | |
tree | 33326eeb09cb9664cc8427a5dc7cd2b08b5a57c3 /drivers/net/wireless/b43/rfkill.h | |
parent | 0f6399c4c525b518644a9b09f8d6fb125a418c4d (diff) |
rfkill: rewrite
This patch completely rewrites the rfkill core to address
the following deficiencies:
* all rfkill drivers need to implement polling where necessary
rather than having one central implementation
* updating the rfkill state cannot be done from arbitrary
contexts, forcing drivers to use schedule_work and requiring
lots of code
* rfkill drivers need to keep track of soft/hard blocked
internally -- the core should do this
* the rfkill API has many unexpected quirks, for example being
asymmetric wrt. alloc/free and register/unregister
* rfkill can call back into a driver from within a function the
driver called -- this is prone to deadlocks and generally
should be avoided
* rfkill-input pointlessly is a separate module
* drivers need to #ifdef rfkill functions (unless they want to
depend on or select RFKILL) -- rfkill should provide inlines
that do nothing if it isn't compiled in
* the rfkill structure is not opaque -- drivers need to initialise
it correctly (lots of sanity checking code required) -- instead
force drivers to pass the right variables to rfkill_alloc()
* the documentation is hard to read because it always assumes the
reader is completely clueless and contains way TOO MANY CAPS
* the rfkill code needlessly uses a lot of locks and atomic
operations in locked sections
* fix LED trigger to actually change the LED when the radio state
changes -- this wasn't done before
Tested-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> [thinkpad]
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/b43/rfkill.h')
-rw-r--r-- | drivers/net/wireless/b43/rfkill.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/wireless/b43/rfkill.h b/drivers/net/wireless/b43/rfkill.h index adacf936d815..da497e01bbb1 100644 --- a/drivers/net/wireless/b43/rfkill.h +++ b/drivers/net/wireless/b43/rfkill.h | |||
@@ -7,14 +7,11 @@ struct b43_wldev; | |||
7 | #ifdef CONFIG_B43_RFKILL | 7 | #ifdef CONFIG_B43_RFKILL |
8 | 8 | ||
9 | #include <linux/rfkill.h> | 9 | #include <linux/rfkill.h> |
10 | #include <linux/input-polldev.h> | ||
11 | 10 | ||
12 | 11 | ||
13 | struct b43_rfkill { | 12 | struct b43_rfkill { |
14 | /* The RFKILL subsystem data structure */ | 13 | /* The RFKILL subsystem data structure */ |
15 | struct rfkill *rfkill; | 14 | struct rfkill *rfkill; |
16 | /* The poll device for the RFKILL input button */ | ||
17 | struct input_polled_dev *poll_dev; | ||
18 | /* Did initialization succeed? Used for freeing. */ | 15 | /* Did initialization succeed? Used for freeing. */ |
19 | bool registered; | 16 | bool registered; |
20 | /* The unique name of this rfkill switch */ | 17 | /* The unique name of this rfkill switch */ |
@@ -26,7 +23,7 @@ struct b43_rfkill { | |||
26 | void b43_rfkill_init(struct b43_wldev *dev); | 23 | void b43_rfkill_init(struct b43_wldev *dev); |
27 | void b43_rfkill_exit(struct b43_wldev *dev); | 24 | void b43_rfkill_exit(struct b43_wldev *dev); |
28 | 25 | ||
29 | char * b43_rfkill_led_name(struct b43_wldev *dev); | 26 | const char *b43_rfkill_led_name(struct b43_wldev *dev); |
30 | 27 | ||
31 | 28 | ||
32 | #else /* CONFIG_B43_RFKILL */ | 29 | #else /* CONFIG_B43_RFKILL */ |