b43: Fix and update LP-PHY code

-Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*)
 in the channel tune routines.
-Fix some typos & spec errors found by MMIO tracing.
-Optimize b43_phy_write & b43_phy_mask/set/maskset to use
 only the minimal number of MMIO accesses. (Write is possible
 using a single 32-bit MMIO write, while set/mask/maskset can
 be done in 3 16-bit MMIOs).
-Set the default channel back to 1, as the bug forcing us to use
 channel 7 is now fixed.

With this, the device comes up, scans, associates, transmits,
receives, monitors and injects on all channels - in other words,
it's fully functional. Sensitivity and TX power are still sub-optimal,
due to the lack of calibration (that's next on my list).

Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 50 insertions, 41 deletions

diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 5306f2c66b34..1a57d3390e92 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -44,7 +44,7 @@ static inline u16 channel2freq_lp(u8 channel)
 static unsigned int b43_lpphy_op_get_default_chan(struct b43_wldev *dev)
 {
         if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ)
-                return 7; //FIXME temporary - channel 1 is broken
+                return 1;
         return 36;
 }
 
@@ -182,8 +182,8 @@ static void lpphy_adjust_gain_table(struct b43_wldev *dev, u32 freq)
         temp[1] = temp[0] + 0x1000;
         temp[2] = temp[0] + 0x2000;
 
-        b43_lptab_write_bulk(dev, B43_LPTAB16(12, 0), 3, temp);
         b43_lptab_write_bulk(dev, B43_LPTAB16(13, 0), 3, temp);
+        b43_lptab_write_bulk(dev, B43_LPTAB16(12, 0), 3, temp);
 }
 
 static void lpphy_table_init(struct b43_wldev *dev)
@@ -223,8 +223,8 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
         b43_phy_maskset(dev, B43_LPPHY_VERYLOWGAINDB, 0xFF00, 0x0006);
         b43_phy_mask(dev, B43_LPPHY_RX_RADIO_CTL, 0xFFFE);
         b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFFE0, 0x0005);
-        b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFC10, 0x0180);
-        b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0x83FF, 0x3800);
+        b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFC1F, 0x0180);
+        b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0x83FF, 0x3C00);
         b43_phy_maskset(dev, B43_LPPHY_GAINDIRECTMISMATCH, 0xFFF0, 0x0005);
         b43_phy_maskset(dev, B43_LPPHY_GAIN_MISMATCH_LIMIT, 0xFFC0, 0x001A);
         b43_phy_maskset(dev, B43_LPPHY_CRS_ED_THRESH, 0xFF00, 0x00B3);
@@ -237,7 +237,7 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
                 /* TODO:
                  * Set the LDO voltage to 0x0028 - FIXME: What is this?
                  * Call sb_pmu_set_ldo_voltage with 4 and the LDO voltage
-                 *      as arguments
+                 *      as arguments
                  * Call sb_pmu_paref_ldo_enable with argument TRUE
                  */
                 if (dev->phy.rev == 0) {
@@ -340,11 +340,11 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
         if (dev->phy.rev == 1) {
                 tmp = b43_phy_read(dev, B43_LPPHY_CLIPCTRTHRESH);
                 tmp2 = (tmp & 0x03E0) >> 5;
-                tmp2 |= tmp << 5;
+                tmp2 |= tmp2 << 5;
                 b43_phy_write(dev, B43_LPPHY_4C3, tmp2);
-                tmp = b43_phy_read(dev, B43_LPPHY_OFDMSYNCTHRESH0);
+                tmp = b43_phy_read(dev, B43_LPPHY_GAINDIRECTMISMATCH);
                 tmp2 = (tmp & 0x1F00) >> 8;
-                tmp2 |= tmp << 5;
+                tmp2 |= tmp2 << 5;
                 b43_phy_write(dev, B43_LPPHY_4C4, tmp2);
                 tmp = b43_phy_read(dev, B43_LPPHY_VERYLOWGAINDB);
                 tmp2 = tmp & 0x00FF;
@@ -761,7 +761,7 @@ static void lpphy_disable_crs(struct b43_wldev *dev, bool user)
         b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x3);
         b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFB);
         b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x4);
-        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFF7);
+        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFF7);
         b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x8);
         b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x10);
         b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x10);
@@ -956,7 +956,7 @@ static void lpphy_run_ddfs(struct b43_wldev *dev, int i_on, int q_on,
         b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS, 0xFF9F, scale_idx << 5);
         b43_phy_mask(dev, B43_LPPHY_AFE_DDFS, 0xFFFB);
         b43_phy_set(dev, B43_LPPHY_AFE_DDFS, 0x2);
-        b43_phy_set(dev, B43_LPPHY_AFE_DDFS, 0x20);
+        b43_phy_set(dev, B43_LPPHY_LP_PHY_CTL, 0x20);
 }
 
 static bool lpphy_rx_iq_est(struct b43_wldev *dev, u16 samples, u8 time,
@@ -968,7 +968,7 @@ static bool lpphy_rx_iq_est(struct b43_wldev *dev, u16 samples, u8 time,
         b43_phy_write(dev, B43_LPPHY_IQ_NUM_SMPLS_ADDR, samples);
         b43_phy_maskset(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFF00, time);
         b43_phy_mask(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFEFF);
-        b43_phy_set(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFDFF);
+        b43_phy_set(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0x200);
 
         for (i = 0; i < 500; i++) {
                 if (!(b43_phy_read(dev,
@@ -1135,9 +1135,9 @@ static void lpphy_set_tx_power_control(struct b43_wldev *dev,
         }
         if (dev->phy.rev >= 2) {
                 if (mode == B43_LPPHY_TXPCTL_HW)
-                        b43_phy_maskset(dev, B43_PHY_OFDM(0xD0), 0xFD, 0x2);
+                        b43_phy_set(dev, B43_PHY_OFDM(0xD0), 0x2);
                 else
-                        b43_phy_maskset(dev, B43_PHY_OFDM(0xD0), 0xFD, 0);
+                        b43_phy_mask(dev, B43_PHY_OFDM(0xD0), 0xFFFD);
         }
         lpphy_write_tx_pctl_mode_to_hardware(dev);
 }
@@ -1169,7 +1169,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
         err = b43_lpphy_op_switch_channel(dev, 7);
         if (err) {
                 b43dbg(dev->wl,
-                       "RC calib: Failed to switch to channel 7, error = %d",
+                       "RC calib: Failed to switch to channel 7, error = %d\n",
                        err);
         }
         old_txg_ovr = !!(b43_phy_read(dev, B43_LPPHY_AFE_CTL_OVR) & 0x40);
@@ -1500,8 +1500,15 @@ static u16 b43_lpphy_op_read(struct b43_wldev *dev, u16 reg)
 
 static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
 {
+        b43_write32(dev, B43_MMIO_PHY_CONTROL, ((u32)value << 16) | reg);
+}
+
+static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
+                                 u16 set)
+{
         b43_write16(dev, B43_MMIO_PHY_CONTROL, reg);
-        b43_write16(dev, B43_MMIO_PHY_DATA, value);
+        b43_write16(dev, B43_MMIO_PHY_DATA,
+                    (b43_read16(dev, B43_MMIO_PHY_DATA) & mask) | set);
 }
 
 static u16 b43_lpphy_op_radio_read(struct b43_wldev *dev, u16 reg)
@@ -1920,8 +1927,8 @@ static void lpphy_b2062_reset_pll_bias(struct b43_wldev *dev)
 
 static void lpphy_b2062_vco_calib(struct b43_wldev *dev)
 {
-        b43_phy_write(dev, B2062_S_RFPLL_CTL21, 0x42);
-        b43_phy_write(dev, B2062_S_RFPLL_CTL21, 0x62);
+        b43_radio_write(dev, B2062_S_RFPLL_CTL21, 0x42);
+        b43_radio_write(dev, B2062_S_RFPLL_CTL21, 0x62);
         udelay(200);
 }
 
@@ -1980,7 +1987,7 @@ static int lpphy_b2062_tune(struct b43_wldev *dev,
         tmp6 = tmp5 / tmp4;
         tmp7 = tmp5 % tmp4;
         b43_radio_write(dev, B2062_S_RFPLL_CTL29, tmp6 + ((2 * tmp7) / tmp4));
-        tmp8 = b43_phy_read(dev, B2062_S_RFPLL_CTL19);
+        tmp8 = b43_radio_read(dev, B2062_S_RFPLL_CTL19);
         tmp9 = ((2 * tmp3 * (tmp8 + 1)) + (3 * tmp1)) / (6 * tmp1);
         b43_radio_write(dev, B2062_S_RFPLL_CTL23, (tmp9 >> 8) + 16);
         b43_radio_write(dev, B2062_S_RFPLL_CTL24, tmp9 & 0xFF);
@@ -2019,17 +2026,17 @@ static void lpphy_b2063_vco_calib(struct b43_wldev *dev)
 {
         u16 tmp;
 
-        b43_phy_mask(dev, B2063_PLL_SP1, ~0x40);
-        tmp = b43_phy_read(dev, B2063_PLL_JTAG_CALNRST) & 0xF8;
-        b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp);
+        b43_radio_mask(dev, B2063_PLL_SP1, ~0x40);
+        tmp = b43_radio_read(dev, B2063_PLL_JTAG_CALNRST) & 0xF8;
+        b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp);
         udelay(1);
-        b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x4);
+        b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x4);
         udelay(1);
-        b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x6);
+        b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x6);
         udelay(1);
-        b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x7);
+        b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x7);
         udelay(300);
-        b43_phy_set(dev, B2063_PLL_SP1, 0x40);
+        b43_radio_set(dev, B2063_PLL_SP1, 0x40);
 }
 
 static int lpphy_b2063_tune(struct b43_wldev *dev,
@@ -2124,31 +2131,31 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
                 scale = 0;
                 tmp5 = ((tmp4 + (tmp3 >> 1)) / tmp3) - 8;
         }
-        b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFC0, tmp5);
-        b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFBF, scale << 6);
+        b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFC0, tmp5);
+        b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFBF, scale << 6);
 
         tmp6 = lpphy_qdiv_roundup(100 * val1, val3, 16);
         tmp6 *= (tmp5 * 8) * (scale + 1);
         if (tmp6 > 150)
                 tmp6 = 0;
 
-        b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFE0, tmp6);
-        b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFDF, scale << 5);
+        b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFE0, tmp6);
+        b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFDF, scale << 5);
 
-        b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFFFB, 0x4);
+        b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFFFB, 0x4);
         if (crystal_freq > 26000000)
-                b43_phy_set(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0x2);
+                b43_radio_set(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0x2);
         else
-                b43_phy_mask(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFD);
+                b43_radio_mask(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFD);
 
         if (val1 == 45)
-                b43_phy_set(dev, B2063_PLL_JTAG_PLL_VCO1, 0x2);
+                b43_radio_set(dev, B2063_PLL_JTAG_PLL_VCO1, 0x2);
         else
-                b43_phy_mask(dev, B2063_PLL_JTAG_PLL_VCO1, 0xFD);
+                b43_radio_mask(dev, B2063_PLL_JTAG_PLL_VCO1, 0xFD);
 
-        b43_phy_set(dev, B2063_PLL_SP2, 0x3);
+        b43_radio_set(dev, B2063_PLL_SP2, 0x3);
         udelay(1);
-        b43_phy_mask(dev, B2063_PLL_SP2, 0xFFFC);
+        b43_radio_mask(dev, B2063_PLL_SP2, 0xFFFC);
         lpphy_b2063_vco_calib(dev);
         b43_radio_write(dev, B2063_COMM15, old_comm15);
 
@@ -2158,10 +2165,9 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
 static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
                                        unsigned int new_channel)
 {
+        struct b43_phy_lp *lpphy = dev->phy.lp;
         int err;
 
-        b43_write16(dev, B43_MMIO_CHANNEL, new_channel);
-
         if (dev->phy.radio_ver == 0x2063) {
                 err = lpphy_b2063_tune(dev, new_channel);
                 if (err)
@@ -2174,6 +2180,9 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
                 lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel));
         }
 
+        lpphy->channel = new_channel;
+        b43_write16(dev, B43_MMIO_CHANNEL, new_channel);
+
         return 0;
 }
 
@@ -2185,10 +2194,9 @@ static int b43_lpphy_op_init(struct b43_wldev *dev)
         lpphy_baseband_init(dev);
         lpphy_radio_init(dev);
         lpphy_calibrate_rc(dev);
-        err = b43_lpphy_op_switch_channel(dev,
-                                b43_lpphy_op_get_default_chan(dev));
+        err = b43_lpphy_op_switch_channel(dev, 7);
         if (err) {
-                b43dbg(dev->wl, "Switch to init channel failed, error = %d.\n",
+                b43dbg(dev->wl, "Switch to channel 7 failed, error = %d.\n",
                        err);
         }
         lpphy_tx_pctl_init(dev);
@@ -2222,6 +2230,7 @@ const struct b43_phy_operations b43_phyops_lp = {
         .init                   = b43_lpphy_op_init,
         .phy_read               = b43_lpphy_op_read,
         .phy_write              = b43_lpphy_op_write,
+        .phy_maskset            = b43_lpphy_op_maskset,
         .radio_read             = b43_lpphy_op_radio_read,
         .radio_write            = b43_lpphy_op_radio_write,
         .software_rfkill        = b43_lpphy_op_software_rfkill,