diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2011-12-19 08:56:45 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-12-19 22:27:29 -0500 |
commit | 3db1cd5c05f35fb43eb134df6f321de4e63141f2 (patch) | |
tree | 960039f3f4f0a524b37e94434624da154859bc64 /drivers/net/wireless/b43/leds.c | |
parent | a8e510f682fe6d7671c11887e07c55f86caaf3c1 (diff) |
net: fix assignment of 0/1 to bool variables.
DaveM said:
Please, this kind of stuff rots forever and not using bool properly
drives me crazy.
Joe Perches <joe@perches.com> gave me the spatch script:
@@
bool b;
@@
-b = 0
+b = false
@@
bool b;
@@
-b = 1
+b = true
I merely installed coccinelle, read the documentation and took credit.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wireless/b43/leds.c')
-rw-r--r-- | drivers/net/wireless/b43/leds.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/wireless/b43/leds.c b/drivers/net/wireless/b43/leds.c index a38c1c6446ad..d79ab2a227e1 100644 --- a/drivers/net/wireless/b43/leds.c +++ b/drivers/net/wireless/b43/leds.c | |||
@@ -74,7 +74,7 @@ static void b43_led_update(struct b43_wldev *dev, | |||
74 | if (radio_enabled) | 74 | if (radio_enabled) |
75 | turn_on = atomic_read(&led->state) != LED_OFF; | 75 | turn_on = atomic_read(&led->state) != LED_OFF; |
76 | else | 76 | else |
77 | turn_on = 0; | 77 | turn_on = false; |
78 | if (turn_on == led->hw_state) | 78 | if (turn_on == led->hw_state) |
79 | return; | 79 | return; |
80 | led->hw_state = turn_on; | 80 | led->hw_state = turn_on; |
@@ -225,11 +225,11 @@ static void b43_led_get_sprominfo(struct b43_wldev *dev, | |||
225 | if (sprom[led_index] == 0xFF) { | 225 | if (sprom[led_index] == 0xFF) { |
226 | /* There is no LED information in the SPROM | 226 | /* There is no LED information in the SPROM |
227 | * for this LED. Hardcode it here. */ | 227 | * for this LED. Hardcode it here. */ |
228 | *activelow = 0; | 228 | *activelow = false; |
229 | switch (led_index) { | 229 | switch (led_index) { |
230 | case 0: | 230 | case 0: |
231 | *behaviour = B43_LED_ACTIVITY; | 231 | *behaviour = B43_LED_ACTIVITY; |
232 | *activelow = 1; | 232 | *activelow = true; |
233 | if (dev->dev->board_vendor == PCI_VENDOR_ID_COMPAQ) | 233 | if (dev->dev->board_vendor == PCI_VENDOR_ID_COMPAQ) |
234 | *behaviour = B43_LED_RADIO_ALL; | 234 | *behaviour = B43_LED_RADIO_ALL; |
235 | break; | 235 | break; |
@@ -267,11 +267,11 @@ void b43_leds_init(struct b43_wldev *dev) | |||
267 | if (led->wl) { | 267 | if (led->wl) { |
268 | if (dev->phy.radio_on && b43_is_hw_radio_enabled(dev)) { | 268 | if (dev->phy.radio_on && b43_is_hw_radio_enabled(dev)) { |
269 | b43_led_turn_on(dev, led->index, led->activelow); | 269 | b43_led_turn_on(dev, led->index, led->activelow); |
270 | led->hw_state = 1; | 270 | led->hw_state = true; |
271 | atomic_set(&led->state, 1); | 271 | atomic_set(&led->state, 1); |
272 | } else { | 272 | } else { |
273 | b43_led_turn_off(dev, led->index, led->activelow); | 273 | b43_led_turn_off(dev, led->index, led->activelow); |
274 | led->hw_state = 0; | 274 | led->hw_state = false; |
275 | atomic_set(&led->state, 0); | 275 | atomic_set(&led->state, 0); |
276 | } | 276 | } |
277 | } | 277 | } |
@@ -280,19 +280,19 @@ void b43_leds_init(struct b43_wldev *dev) | |||
280 | led = &dev->wl->leds.led_tx; | 280 | led = &dev->wl->leds.led_tx; |
281 | if (led->wl) { | 281 | if (led->wl) { |
282 | b43_led_turn_off(dev, led->index, led->activelow); | 282 | b43_led_turn_off(dev, led->index, led->activelow); |
283 | led->hw_state = 0; | 283 | led->hw_state = false; |
284 | atomic_set(&led->state, 0); | 284 | atomic_set(&led->state, 0); |
285 | } | 285 | } |
286 | led = &dev->wl->leds.led_rx; | 286 | led = &dev->wl->leds.led_rx; |
287 | if (led->wl) { | 287 | if (led->wl) { |
288 | b43_led_turn_off(dev, led->index, led->activelow); | 288 | b43_led_turn_off(dev, led->index, led->activelow); |
289 | led->hw_state = 0; | 289 | led->hw_state = false; |
290 | atomic_set(&led->state, 0); | 290 | atomic_set(&led->state, 0); |
291 | } | 291 | } |
292 | led = &dev->wl->leds.led_assoc; | 292 | led = &dev->wl->leds.led_assoc; |
293 | if (led->wl) { | 293 | if (led->wl) { |
294 | b43_led_turn_off(dev, led->index, led->activelow); | 294 | b43_led_turn_off(dev, led->index, led->activelow); |
295 | led->hw_state = 0; | 295 | led->hw_state = false; |
296 | atomic_set(&led->state, 0); | 296 | atomic_set(&led->state, 0); |
297 | } | 297 | } |
298 | 298 | ||