diff options
author | Michael Buesch <mb@bu3sch.de> | 2009-01-25 09:49:59 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-01-29 16:01:47 -0500 |
commit | 060210f938d8aa0b9d795588a2274cd67ba9d6a4 (patch) | |
tree | 74eceabb2bb5b945862f49e567bf862d243ff13a /drivers/net/wireless/b43/b43.h | |
parent | 08e87a833f5e77ff33b64c9ac27cb7fb9ecd4a48 (diff) |
b43: Dynamically control log verbosity
Dynamically control the log verbosity with a module parameter.
This enables us to dynamically enable debugging messages (or disable
info, warn, error messages) via module parameter or /sys/module/b43/parameters/verbose.
This increases the module size by about 3k. But in practice it reduces the
module size for the user, because some distributions ship the b43 module
with CONFIG_B43_DEBUG set, which increases the module by about 15k.
So with this patch applied, distributions should really _disable_ CONFIG_B43_DEBUG.
There is no reason to keep it in a production-release kernel.
So we have a net reduction in size by about 12k.
This patch also adds a printk of the wireless core revision, so people
don't have to enable SSB debugging to get the wireless core revision.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/b43/b43.h')
-rw-r--r-- | drivers/net/wireless/b43/b43.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/wireless/b43/b43.h b/drivers/net/wireless/b43/b43.h index 9e0da212f8ce..e9d60f0910be 100644 --- a/drivers/net/wireless/b43/b43.h +++ b/drivers/net/wireless/b43/b43.h | |||
@@ -878,12 +878,9 @@ void b43err(struct b43_wl *wl, const char *fmt, ...) | |||
878 | __attribute__ ((format(printf, 2, 3))); | 878 | __attribute__ ((format(printf, 2, 3))); |
879 | void b43warn(struct b43_wl *wl, const char *fmt, ...) | 879 | void b43warn(struct b43_wl *wl, const char *fmt, ...) |
880 | __attribute__ ((format(printf, 2, 3))); | 880 | __attribute__ ((format(printf, 2, 3))); |
881 | #if B43_DEBUG | ||
882 | void b43dbg(struct b43_wl *wl, const char *fmt, ...) | 881 | void b43dbg(struct b43_wl *wl, const char *fmt, ...) |
883 | __attribute__ ((format(printf, 2, 3))); | 882 | __attribute__ ((format(printf, 2, 3))); |
884 | #else /* DEBUG */ | 883 | |
885 | # define b43dbg(wl, fmt...) do { /* nothing */ } while (0) | ||
886 | #endif /* DEBUG */ | ||
887 | 884 | ||
888 | /* A WARN_ON variant that vanishes when b43 debugging is disabled. | 885 | /* A WARN_ON variant that vanishes when b43 debugging is disabled. |
889 | * This _also_ evaluates the arg with debugging disabled. */ | 886 | * This _also_ evaluates the arg with debugging disabled. */ |