diff options
author | Jesper Juhl <jj@chaosbits.net> | 2012-04-11 16:41:36 -0400 |
---|---|---|
committer | Kalle Valo <kvalo@qca.qualcomm.com> | 2012-04-13 07:42:15 -0400 |
commit | ae9a3405fd28ce05dc3d0b51d541fd5ec742b3b4 (patch) | |
tree | 7d6a5f2c899149a9b9af2e19611b3bfaebb8def0 /drivers/net/wireless/ath | |
parent | 6146ca69031e3ad697d801e7e242b554d7969de1 (diff) |
ath6kl: fix memory leak in ath6kl_fwlog_block_read()
If, in
drivers/net/wireless/ath/ath6kl/debug.c::ath6kl_fwlog_block_read(),
the call to wait_for_completion_interruptible() returns -ERESTARTSYS
then we'll return without freeing the (as yet unused) memory we
allocated for 'buf' - thus leaking it.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Diffstat (limited to 'drivers/net/wireless/ath')
-rw-r--r-- | drivers/net/wireless/ath/ath6kl/debug.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c index 2bcd45095eb9..496382f472de 100644 --- a/drivers/net/wireless/ath/ath6kl/debug.c +++ b/drivers/net/wireless/ath/ath6kl/debug.c | |||
@@ -407,8 +407,10 @@ static ssize_t ath6kl_fwlog_block_read(struct file *file, | |||
407 | 407 | ||
408 | ret = wait_for_completion_interruptible( | 408 | ret = wait_for_completion_interruptible( |
409 | &ar->debug.fwlog_completion); | 409 | &ar->debug.fwlog_completion); |
410 | if (ret == -ERESTARTSYS) | 410 | if (ret == -ERESTARTSYS) { |
411 | vfree(buf); | ||
411 | return ret; | 412 | return ret; |
413 | } | ||
412 | 414 | ||
413 | spin_lock(&ar->debug.fwlog_queue.lock); | 415 | spin_lock(&ar->debug.fwlog_queue.lock); |
414 | } | 416 | } |