aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/ath9k
diff options
context:
space:
mode:
authorGabor Juhos <juhosg@openwrt.org>2009-01-14 14:17:11 -0500
committerJohn W. Linville <linville@tuxdriver.com>2009-01-29 16:00:34 -0500
commit9950688263dcd74560582f590d270728f4e92ed0 (patch)
tree51d73e7b3ca3224db65c42c33a495b2268c4844a /drivers/net/wireless/ath9k
parent1975ef2039c63f58e6c80861a24236bcd0483aa9 (diff)
ath9k: fix null pointer dereference in ani monitor code
In 'ath9k_ani_reset' the 'ahp->ah_curani' will be initialized only if 'DO_ANI(ah)' true. In 'ath9k_hw_ani_monitor' we are using 'ahp->ah_curani' unconditionally, and it will cause a NULL pointer dereference on AR9100. Changes-licensed-under: ISC Signed-off-by: Gabor Juhos <juhosg@openwrt.org> Signed-off-by: Imre Kaloz <kaloz@openwrt.org> Tested-by: Pavel Roskin <proski@gnu.org> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/ath9k')
-rw-r--r--drivers/net/wireless/ath9k/ani.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/wireless/ath9k/ani.c b/drivers/net/wireless/ath9k/ani.c
index 4dd086073ad9..42197fff2a47 100644
--- a/drivers/net/wireless/ath9k/ani.c
+++ b/drivers/net/wireless/ath9k/ani.c
@@ -551,6 +551,9 @@ void ath9k_hw_ani_monitor(struct ath_hal *ah,
551 struct ar5416AniState *aniState; 551 struct ar5416AniState *aniState;
552 int32_t listenTime; 552 int32_t listenTime;
553 553
554 if (!DO_ANI(ah))
555 return;
556
554 aniState = ahp->ah_curani; 557 aniState = ahp->ah_curani;
555 ahp->ah_stats.ast_nodestats = *stats; 558 ahp->ah_stats.ast_nodestats = *stats;
556 559
@@ -610,9 +613,6 @@ void ath9k_hw_ani_monitor(struct ath_hal *ah,
610 aniState->cckPhyErrCount = cckPhyErrCnt; 613 aniState->cckPhyErrCount = cckPhyErrCnt;
611 } 614 }
612 615
613 if (!DO_ANI(ah))
614 return;
615
616 if (aniState->listenTime > 5 * ahp->ah_aniPeriod) { 616 if (aniState->listenTime > 5 * ahp->ah_aniPeriod) {
617 if (aniState->ofdmPhyErrCount <= aniState->listenTime * 617 if (aniState->ofdmPhyErrCount <= aniState->listenTime *
618 aniState->ofdmTrigLow / 1000 && 618 aniState->ofdmTrigLow / 1000 &&