ath6kl: Fix htc_packet leak in ath6kl_htc_rx_fetch()

It is found during the code review. As the leak would happen only
in failure case, the imapct is not easily visible.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c
index 7bc988438ead..4a03dacd9208 100644
--- a/drivers/net/wireless/ath/ath6kl/htc.c
+++ b/drivers/net/wireless/ath/ath6kl/htc.c
@@ -1715,12 +1715,10 @@ static int ath6kl_htc_rx_fetch(struct htc_target *target,
                         packet = list_first_entry(rx_pktq, struct htc_packet,
                                                    list);
 
-                        list_del(&packet->list);
-
                         /* fully synchronous */
                         packet->completion = NULL;
 
-                        if (!list_empty(rx_pktq))
+                        if (!list_is_singular(rx_pktq))
                                 /*
                                  * look_aheads in all packet
                                  * except the last one in the
@@ -1735,7 +1733,7 @@ static int ath6kl_htc_rx_fetch(struct htc_target *target,
                         if (status)
                                 return status;
 
-                        list_add_tail(&packet->list, comp_pktq);
+                        list_move_tail(&packet->list, comp_pktq);
                 }
         }