[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 12 insertions, 20 deletions

diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 7d717c4d9845..95d3cd1c49a7 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2821,6 +2821,7 @@ static struct net_device *_init_airo_card( unsigned short irq, int port,
         struct net_device *dev;
         struct airo_info *ai;
         int i, rc;
+        DECLARE_MAC_BUF(mac);
 
         /* Create the network device object. */
         dev = alloc_netdev(sizeof(*ai), "", ether_setup);
@@ -2923,9 +2924,8 @@ static struct net_device *_init_airo_card( unsigned short irq, int port,
                 goto err_out_reg;
 
         set_bit(FLAG_REGISTERED,&ai->flags);
-        airo_print_info(dev->name, "MAC enabled %x:%x:%x:%x:%x:%x",
-                dev->dev_addr[0], dev->dev_addr[1], dev->dev_addr[2],
-                dev->dev_addr[3], dev->dev_addr[4], dev->dev_addr[5] );
+        airo_print_info(dev->name, "MAC enabled %s",
+                        print_mac(mac, dev->dev_addr));
 
         /* Allocate the transmit buffers */
         if (probe && !test_bit(FLAG_MPI,&ai->flags))
@@ -2982,6 +2982,7 @@ int reset_airo_card( struct net_device *dev )
 {
         int i;
         struct airo_info *ai = dev->priv;
+        DECLARE_MAC_BUF(mac);
 
         if (reset_card (dev, 1))
                 return -1;
@@ -2990,9 +2991,8 @@ int reset_airo_card( struct net_device *dev )
                 airo_print_err(dev->name, "MAC could not be enabled");
                 return -1;
         }
-        airo_print_info(dev->name, "MAC enabled %x:%x:%x:%x:%x:%x",
-                        dev->dev_addr[0], dev->dev_addr[1], dev->dev_addr[2],
-                        dev->dev_addr[3], dev->dev_addr[4], dev->dev_addr[5]);
+        airo_print_info(dev->name, "MAC enabled %s",
+                        print_mac(mac, dev->dev_addr));
         /* Allocate the transmit buffers if needed */
         if (!test_bit(FLAG_MPI,&ai->flags))
                 for( i = 0; i < MAX_FIDS; i++ )
@@ -5426,6 +5426,7 @@ static int proc_APList_open( struct inode *inode, struct file *file ) {
         int i;
         char *ptr;
         APListRid APList_rid;
+        DECLARE_MAC_BUF(mac);
 
         if ((file->private_data = kzalloc(sizeof(struct proc_data ), GFP_KERNEL)) == NULL)
                 return -ENOMEM;
@@ -5449,13 +5450,8 @@ static int proc_APList_open( struct inode *inode, struct file *file ) {
 // We end when we find a zero MAC
                 if ( !*(int*)APList_rid.ap[i] &&
                      !*(int*)&APList_rid.ap[i][2]) break;
-                ptr += sprintf(ptr, "%02x:%02x:%02x:%02x:%02x:%02x\n",
-                               (int)APList_rid.ap[i][0],
-                               (int)APList_rid.ap[i][1],
-                               (int)APList_rid.ap[i][2],
-                               (int)APList_rid.ap[i][3],
-                               (int)APList_rid.ap[i][4],
-                               (int)APList_rid.ap[i][5]);
+                ptr += sprintf(ptr, "%s\n",
+                               print_mac(mac, APList_rid.ap[i]));
         }
         if (i==0) ptr += sprintf(ptr, "Not using specific APs\n");
 
@@ -5474,6 +5470,7 @@ static int proc_BSSList_open( struct inode *inode, struct file *file ) {
         int rc;
         /* If doLoseSync is not 1, we won't do a Lose Sync */
         int doLoseSync = -1;
+        DECLARE_MAC_BUF(mac);
 
         if ((file->private_data = kzalloc(sizeof(struct proc_data ), GFP_KERNEL)) == NULL)
                 return -ENOMEM;
@@ -5510,13 +5507,8 @@ static int proc_BSSList_open( struct inode *inode, struct file *file ) {
            we have to add a spin lock... */
         rc = readBSSListRid(ai, doLoseSync, &BSSList_rid);
         while(rc == 0 && BSSList_rid.index != 0xffff) {
-                ptr += sprintf(ptr, "%02x:%02x:%02x:%02x:%02x:%02x %*s rssi = %d",
-                                (int)BSSList_rid.bssid[0],
-                                (int)BSSList_rid.bssid[1],
-                                (int)BSSList_rid.bssid[2],
-                                (int)BSSList_rid.bssid[3],
-                                (int)BSSList_rid.bssid[4],
-                                (int)BSSList_rid.bssid[5],
+                ptr += sprintf(ptr, "%s %*s rssi = %d",
+                               print_mac(mac, BSSList_rid.bssid),
                                 (int)BSSList_rid.ssidLen,
                                 BSSList_rid.ssid,
                                 (int)BSSList_rid.dBm);