diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-08-22 16:49:33 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-08-24 13:30:26 -0400 |
commit | 9213bb8325747d00b6d9d5aea6ccde6a72c8a1fa (patch) | |
tree | e983cee7389fc296678438ed5a39aba18ee4ce9c /drivers/net/wimax/i2400m | |
parent | 8f4cccbbd92f2ad0ddbbc498ef7cee2a1c3defe9 (diff) |
wimax/i2400m: use is_zero_ether_addr() instead of memcmp()
Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wimax/i2400m')
-rw-r--r-- | drivers/net/wimax/i2400m/driver.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c index 025426132754..9c34d2fccfac 100644 --- a/drivers/net/wimax/i2400m/driver.c +++ b/drivers/net/wimax/i2400m/driver.c | |||
@@ -222,7 +222,6 @@ int i2400m_check_mac_addr(struct i2400m *i2400m) | |||
222 | struct sk_buff *skb; | 222 | struct sk_buff *skb; |
223 | const struct i2400m_tlv_detailed_device_info *ddi; | 223 | const struct i2400m_tlv_detailed_device_info *ddi; |
224 | struct net_device *net_dev = i2400m->wimax_dev.net_dev; | 224 | struct net_device *net_dev = i2400m->wimax_dev.net_dev; |
225 | const unsigned char zeromac[ETH_ALEN] = { 0 }; | ||
226 | 225 | ||
227 | d_fnstart(3, dev, "(i2400m %p)\n", i2400m); | 226 | d_fnstart(3, dev, "(i2400m %p)\n", i2400m); |
228 | skb = i2400m_get_device_info(i2400m); | 227 | skb = i2400m_get_device_info(i2400m); |
@@ -244,7 +243,7 @@ int i2400m_check_mac_addr(struct i2400m *i2400m) | |||
244 | "to that of boot mode's\n"); | 243 | "to that of boot mode's\n"); |
245 | dev_warn(dev, "device reports %pM\n", ddi->mac_address); | 244 | dev_warn(dev, "device reports %pM\n", ddi->mac_address); |
246 | dev_warn(dev, "boot mode reported %pM\n", net_dev->perm_addr); | 245 | dev_warn(dev, "boot mode reported %pM\n", net_dev->perm_addr); |
247 | if (!memcmp(zeromac, ddi->mac_address, sizeof(zeromac))) | 246 | if (is_zero_ether_addr(ddi->mac_address)) |
248 | dev_err(dev, "device reports an invalid MAC address, " | 247 | dev_err(dev, "device reports an invalid MAC address, " |
249 | "not updating\n"); | 248 | "not updating\n"); |
250 | else { | 249 | else { |