wimax/i2400m: do bootmode buffer management in i2400m_setup/release()

After the introduction of i2400m->bus_setup/release, there is no more
race condition where the bootmode buffers are needed before
i2400m_setup() is called.

Before, the SDIO driver would setup RX before calling i2400m_setup()
and thus need those buffers; now RX setup is done in
i2400m->bus_setup(), which is called by i2400m_setup().

Thus, all the bootmode buffer management can now be done completely
inside i2400m_setup()/i2400m_release(), removing complexity from the
bus-specific drivers.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>

1 files changed, 0 insertions, 14 deletions

diff --git a/drivers/net/wimax/i2400m/sdio.c b/drivers/net/wimax/i2400m/sdio.c
index 6e39665ecd89..14e66f06f235 100644
--- a/drivers/net/wimax/i2400m/sdio.c
+++ b/drivers/net/wimax/i2400m/sdio.c
@@ -519,18 +519,6 @@ int i2400ms_probe(struct sdio_func *func,
         i2400m->bus_bm_mac_addr_impaired = 1;
         i2400m->bus_bm_pokes_table = &i2400ms_pokes[0];
 
-        /*
-         * Before we are enabling the device interrupt register, make
-         * sure the buffer used during bootmode operation is setup so
-         * when the first D2H data interrupt comes, the memory is
-         * available for copying the D2H data.
-         */
-        result = i2400m_bm_buf_alloc(i2400m);
-        if (result < 0) {
-                dev_err(dev, "cannot allocate SDIO bootmode buffer\n");
-                goto error_bootmode_buf_setup;
-        }
-
         result = i2400m_setup(i2400m, I2400M_BRI_NO_REBOOT);
         if (result < 0) {
                 dev_err(dev, "cannot setup device: %d\n", result);
@@ -548,8 +536,6 @@ int i2400ms_probe(struct sdio_func *func,
 error_debugfs_add:
         i2400m_release(i2400m);
 error_setup:
-        i2400m_bm_buf_free(i2400m);
-error_bootmode_buf_setup:
         sdio_set_drvdata(func, NULL);
         free_netdev(net_dev);
 error_alloc_netdev: