diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-05-19 20:44:49 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-05-21 17:16:24 -0400 |
commit | aff4b9743225d1c8a4cfa51b186bc3ad789dc8f9 (patch) | |
tree | 6467edb59f19b2c50bce9e6040854152186ae854 /drivers/net/wimax/i2400m/driver.c | |
parent | 5fe821a9dee241fa450703ab7015d970ee0cfb8d (diff) |
wimax/i2400m: make return of 0 explicit
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret = e
return
- ret
+ 0
;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wimax/i2400m/driver.c')
-rw-r--r-- | drivers/net/wimax/i2400m/driver.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c index 9c34d2fccfac..9c78090e72f8 100644 --- a/drivers/net/wimax/i2400m/driver.c +++ b/drivers/net/wimax/i2400m/driver.c | |||
@@ -500,26 +500,23 @@ int i2400m_pm_notifier(struct notifier_block *notifier, | |||
500 | */ | 500 | */ |
501 | int i2400m_pre_reset(struct i2400m *i2400m) | 501 | int i2400m_pre_reset(struct i2400m *i2400m) |
502 | { | 502 | { |
503 | int result; | ||
504 | struct device *dev = i2400m_dev(i2400m); | 503 | struct device *dev = i2400m_dev(i2400m); |
505 | 504 | ||
506 | d_fnstart(3, dev, "(i2400m %p)\n", i2400m); | 505 | d_fnstart(3, dev, "(i2400m %p)\n", i2400m); |
507 | d_printf(1, dev, "pre-reset shut down\n"); | 506 | d_printf(1, dev, "pre-reset shut down\n"); |
508 | 507 | ||
509 | result = 0; | ||
510 | mutex_lock(&i2400m->init_mutex); | 508 | mutex_lock(&i2400m->init_mutex); |
511 | if (i2400m->updown) { | 509 | if (i2400m->updown) { |
512 | netif_tx_disable(i2400m->wimax_dev.net_dev); | 510 | netif_tx_disable(i2400m->wimax_dev.net_dev); |
513 | __i2400m_dev_stop(i2400m); | 511 | __i2400m_dev_stop(i2400m); |
514 | result = 0; | ||
515 | /* down't set updown to zero -- this way | 512 | /* down't set updown to zero -- this way |
516 | * post_reset can restore properly */ | 513 | * post_reset can restore properly */ |
517 | } | 514 | } |
518 | mutex_unlock(&i2400m->init_mutex); | 515 | mutex_unlock(&i2400m->init_mutex); |
519 | if (i2400m->bus_release) | 516 | if (i2400m->bus_release) |
520 | i2400m->bus_release(i2400m); | 517 | i2400m->bus_release(i2400m); |
521 | d_fnend(3, dev, "(i2400m %p) = %d\n", i2400m, result); | 518 | d_fnend(3, dev, "(i2400m %p) = 0\n", i2400m); |
522 | return result; | 519 | return 0; |
523 | } | 520 | } |
524 | EXPORT_SYMBOL_GPL(i2400m_pre_reset); | 521 | EXPORT_SYMBOL_GPL(i2400m_pre_reset); |
525 | 522 | ||