wimax/i2400m: allow control of the base-station idle mode timeout

For power saving reasons, WiMAX links can be put in idle mode while
connected after a certain time of the link not being used for tx or
rx. In this mode, the device pages the base-station regularly and when
data is ready to be transmitted, the link is revived.

This patch allows the user to control the time the device has to be
idle before it decides to go to idle mode from a sysfs
interace.

It also updates the initialization code to acknowledge the module
variable 'idle_mode_disabled' when the firmware is a newer version
(upcoming 1.4 vs 2.6.29's v1.3).

The method for setting the idle mode timeout in the older firmwares is
much more limited and can be only done at initialization time. Thus,
the sysfs file will return -ENOSYS on older ones.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 10 insertions, 0 deletions

diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c
index 69a816e7c5db..f988771bfae0 100644
--- a/drivers/net/wimax/i2400m/driver.c
+++ b/drivers/net/wimax/i2400m/driver.c
@@ -662,6 +662,11 @@ int i2400m_setup(struct i2400m *i2400m, enum i2400m_bri bm_flags)
         wimax_state_change(wimax_dev, WIMAX_ST_UNINITIALIZED);
 
         /* Now setup all that requires a registered net and wimax device. */
+        result = sysfs_create_group(&net_dev->dev.kobj, &i2400m_dev_attr_group);
+        if (result < 0) {
+                dev_err(dev, "cannot setup i2400m's sysfs: %d\n", result);
+                goto error_sysfs_setup;
+        }
         result = i2400m_debugfs_add(i2400m);
         if (result < 0) {
                 dev_err(dev, "cannot setup i2400m's debugfs: %d\n", result);
@@ -671,6 +676,9 @@ int i2400m_setup(struct i2400m *i2400m, enum i2400m_bri bm_flags)
         return result;
 
 error_debugfs_setup:
+        sysfs_remove_group(&i2400m->wimax_dev.net_dev->dev.kobj,
+                           &i2400m_dev_attr_group);
+error_sysfs_setup:
         wimax_dev_rm(&i2400m->wimax_dev);
 error_wimax_dev_add:
         i2400m_dev_stop(i2400m);
@@ -702,6 +710,8 @@ void i2400m_release(struct i2400m *i2400m)
         netif_stop_queue(i2400m->wimax_dev.net_dev);
 
         i2400m_debugfs_rm(i2400m);
+        sysfs_remove_group(&i2400m->wimax_dev.net_dev->dev.kobj,
+                           &i2400m_dev_attr_group);
         wimax_dev_rm(&i2400m->wimax_dev);
         i2400m_dev_stop(i2400m);
         unregister_netdev(i2400m->wimax_dev.net_dev);