vxge: Fix a receive stall due to driver being out of synch with chip.

- Fix a receive stall due to driver being out of synch with chip. In a corner
case scenario the adapter's ring controller may return a RxD with transfer code
of 0xC, while the host ownership bit is still set to the adapter. The driver
needs to assume that this case where (host_ownership == 1 or adapter) and
(transfer_code == 0xC) is valid, that is, this RxD has been returned by the
receive ring controller but no frame data is associated with the rxd.

- Restore the transfer code field of each newly replenished RxD to 0x0.

- Code cleanup. Removed usage of magic numbers.

Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 11 insertions, 7 deletions

diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-traffic.c
index 2c012f4ce465..c8b3997e9eeb 100644
--- a/drivers/net/vxge/vxge-traffic.c
+++ b/drivers/net/vxge/vxge-traffic.c
@@ -878,7 +878,7 @@ void vxge_hw_ring_rxd_post_post(struct __vxge_hw_ring *ring, void *rxdh)
 
         channel = &ring->channel;
 
-        rxdp->control_0 |= VXGE_HW_RING_RXD_LIST_OWN_ADAPTER;
+        rxdp->control_0 = VXGE_HW_RING_RXD_LIST_OWN_ADAPTER;
 
         if (ring->stats->common_stats.usage_cnt > 0)
                 ring->stats->common_stats.usage_cnt--;
@@ -902,7 +902,7 @@ void vxge_hw_ring_rxd_post(struct __vxge_hw_ring *ring, void *rxdh)
         channel = &ring->channel;
 
         wmb();
-        rxdp->control_0 |= VXGE_HW_RING_RXD_LIST_OWN_ADAPTER;
+        rxdp->control_0 = VXGE_HW_RING_RXD_LIST_OWN_ADAPTER;
 
         vxge_hw_channel_dtr_post(channel, rxdh);
 
@@ -966,6 +966,7 @@ enum vxge_hw_status vxge_hw_ring_rxd_next_completed(
         struct __vxge_hw_channel *channel;
         struct vxge_hw_ring_rxd_1 *rxdp;
         enum vxge_hw_status status = VXGE_HW_OK;
+        u64 control_0, own;
 
         channel = &ring->channel;
 
@@ -977,8 +978,12 @@ enum vxge_hw_status vxge_hw_ring_rxd_next_completed(
                 goto exit;
         }
 
+        control_0 = rxdp->control_0;
+        own = control_0 & VXGE_HW_RING_RXD_LIST_OWN_ADAPTER;
+        *t_code = (u8)VXGE_HW_RING_RXD_T_CODE_GET(control_0);
+
         /* check whether it is not the end */
-        if (!(rxdp->control_0 & VXGE_HW_RING_RXD_LIST_OWN_ADAPTER)) {
+        if (!own || ((*t_code == VXGE_HW_RING_T_CODE_FRM_DROP) && own)) {
 
                 vxge_assert(((struct vxge_hw_ring_rxd_1 *)rxdp)->host_control !=
                                 0);
@@ -986,8 +991,6 @@ enum vxge_hw_status vxge_hw_ring_rxd_next_completed(
                 ++ring->cmpl_cnt;
                 vxge_hw_channel_dtr_complete(channel);
 
-                *t_code = (u8)VXGE_HW_RING_RXD_T_CODE_GET(rxdp->control_0);
-
                 vxge_assert(*t_code != VXGE_HW_RING_RXD_T_CODE_UNUSED);
 
                 ring->stats->common_stats.usage_cnt++;
@@ -1035,12 +1038,13 @@ enum vxge_hw_status vxge_hw_ring_handle_tcode(
          * such as unknown UPV6 header), Drop it !!!
          */
 
-        if (t_code == 0 || t_code == 5) {
+        if (t_code ==  VXGE_HW_RING_T_CODE_OK ||
+                t_code == VXGE_HW_RING_T_CODE_L3_PKT_ERR) {
                 status = VXGE_HW_OK;
                 goto exit;
         }
 
-        if (t_code > 0xF) {
+        if (t_code > VXGE_HW_RING_T_CODE_MULTI_ERR) {
                 status = VXGE_HW_ERR_INVALID_TCODE;
                 goto exit;
         }