diff options
author | Anthony Liguori <aliguori@us.ibm.com> | 2008-04-07 16:33:16 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-07 16:56:33 -0400 |
commit | 6ea0a4679d6a11c66cfeb26d15244fb6f9b52d14 (patch) | |
tree | 1f6f8034ef903af7ed63cffd8b5d9821e3048843 /drivers/net/virtio_net.c | |
parent | 099c736a470c8080a166e7a089f1e48e15f9947c (diff) |
virtio_net: remove overzealous printk
The 'disable_cb' is really just a hint and as such, it's possible for more
work to get queued up while callbacks are disabled. Under stress with an
SMP guest, this printk triggers very frequently. There is no race here, this
is how things are designed to work so let's just remove the printk.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/net/virtio_net.c')
-rw-r--r-- | drivers/net/virtio_net.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b58472cf76f8..d1a200ff5fd2 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c | |||
@@ -284,7 +284,6 @@ again: | |||
284 | /* Activate callback for using skbs: if this returns false it | 284 | /* Activate callback for using skbs: if this returns false it |
285 | * means some were used in the meantime. */ | 285 | * means some were used in the meantime. */ |
286 | if (unlikely(!vi->svq->vq_ops->enable_cb(vi->svq))) { | 286 | if (unlikely(!vi->svq->vq_ops->enable_cb(vi->svq))) { |
287 | printk("Unlikely: restart svq race\n"); | ||
288 | vi->svq->vq_ops->disable_cb(vi->svq); | 287 | vi->svq->vq_ops->disable_cb(vi->svq); |
289 | netif_start_queue(dev); | 288 | netif_start_queue(dev); |
290 | goto again; | 289 | goto again; |