diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-15 07:23:15 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-05-17 20:44:48 -0400 |
commit | 5476b8b22589fe118f3c228d71406455002b79b1 (patch) | |
tree | 01a42f9d6949f9bf2b97a5ca667ad67842eee797 /drivers/net/usb | |
parent | 99bf236612801351834b441314379bc5304d62ce (diff) |
drivers/net/usb: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
-rw-r--r-- | drivers/net/usb/dm9601.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index 47634b617107..02b622e3b9fb 100644 --- a/drivers/net/usb/dm9601.c +++ b/drivers/net/usb/dm9601.c | |||
@@ -93,10 +93,9 @@ static int dm_write(struct usbnet *dev, u8 reg, u16 length, void *data) | |||
93 | netdev_dbg(dev->net, "dm_write() reg=0x%02x, length=%d\n", reg, length); | 93 | netdev_dbg(dev->net, "dm_write() reg=0x%02x, length=%d\n", reg, length); |
94 | 94 | ||
95 | if (data) { | 95 | if (data) { |
96 | buf = kmalloc(length, GFP_KERNEL); | 96 | buf = kmemdup(data, length, GFP_KERNEL); |
97 | if (!buf) | 97 | if (!buf) |
98 | goto out; | 98 | goto out; |
99 | memcpy(buf, data, length); | ||
100 | } | 99 | } |
101 | 100 | ||
102 | err = usb_control_msg(dev->udev, | 101 | err = usb_control_msg(dev->udev, |