diff options
author | Mariusz Kozlowski <m.kozlowski@tuxland.pl> | 2007-09-15 16:14:05 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:50:27 -0400 |
commit | acb2cc8b20d6cb9e65c1e442d59a2449d8774157 (patch) | |
tree | 54deabaa1238049d0d0a342b7c1b08ad71155c91 /drivers/net/usb | |
parent | bf1e9a080d7766bd65b8d8eb837ecde8b03dcc31 (diff) |
[PATCH] drivers/net: remove superfluous memset
This patch covers something like this:
dev = alloc_*dev(...
...
priv = netdev_priv(dev);
memset(priv, 0, sizeof(*priv));
The memset() here is superfluous. alloc_netdev() uses kzalloc()
to allocate needed memory so there is no need to zero the priv region
twice.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
-rw-r--r-- | drivers/net/usb/pegasus.c | 1 | ||||
-rw-r--r-- | drivers/net/usb/rtl8150.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 04cba6bf3d54..06838928ef47 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c | |||
@@ -1306,7 +1306,6 @@ static int pegasus_probe(struct usb_interface *intf, | |||
1306 | } | 1306 | } |
1307 | 1307 | ||
1308 | pegasus = netdev_priv(net); | 1308 | pegasus = netdev_priv(net); |
1309 | memset(pegasus, 0, sizeof (struct pegasus)); | ||
1310 | pegasus->dev_index = dev_index; | 1309 | pegasus->dev_index = dev_index; |
1311 | init_waitqueue_head(&pegasus->ctrl_wait); | 1310 | init_waitqueue_head(&pegasus->ctrl_wait); |
1312 | 1311 | ||
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index fa598f0340cf..3b3a57ea2676 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c | |||
@@ -905,7 +905,6 @@ static int rtl8150_probe(struct usb_interface *intf, | |||
905 | } | 905 | } |
906 | 906 | ||
907 | dev = netdev_priv(netdev); | 907 | dev = netdev_priv(netdev); |
908 | memset(dev, 0, sizeof(rtl8150_t)); | ||
909 | 908 | ||
910 | dev->intr_buff = kmalloc(INTBUFSIZE, GFP_KERNEL); | 909 | dev->intr_buff = kmalloc(INTBUFSIZE, GFP_KERNEL); |
911 | if (!dev->intr_buff) { | 910 | if (!dev->intr_buff) { |