net: cdc_ncm: remove redundant "disconnected" flag

Calling netif_carrier_{on,off} is sufficient.  There is no need
to duplicate the carrier state in a driver specific flag.

Acked-by: Enrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>

2 files changed, 2 insertions, 30 deletions

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 1d1ff2fa8ae1..783c4ed96395 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1364,11 +1364,10 @@ static void cdc_ncm_status(struct usbnet *dev, struct urb *urb)
                  * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be
                  * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE.
                  */
-                ctx->connected = le16_to_cpu(event->wValue);
                 netif_info(dev, link, dev->net,
                            "network connection: %sconnected\n",
-                           ctx->connected ? "" : "dis");
-                usbnet_link_change(dev, ctx->connected, 0);
+                           !!event->wValue ? "" : "dis");
+                usbnet_link_change(dev, !!event->wValue, 0);
                 break;
 
         case USB_CDC_NOTIFY_SPEED_CHANGE:
@@ -1388,23 +1387,11 @@ static void cdc_ncm_status(struct usbnet *dev, struct urb *urb)
         }
 }
 
-static int cdc_ncm_check_connect(struct usbnet *dev)
-{
-        struct cdc_ncm_ctx *ctx;
-
-        ctx = (struct cdc_ncm_ctx *)dev->data[0];
-        if (ctx == NULL)
-                return 1;       /* disconnected */
-
-        return !ctx->connected;
-}
-
 static const struct driver_info cdc_ncm_info = {
         .description = "CDC NCM",
         .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET,
         .bind = cdc_ncm_bind,
         .unbind = cdc_ncm_unbind,
-        .check_connect = cdc_ncm_check_connect,
         .manage_power = usbnet_manage_power,
         .status = cdc_ncm_status,
         .rx_fixup = cdc_ncm_rx_fixup,
@@ -1418,7 +1405,6 @@ static const struct driver_info wwan_info = {
                         | FLAG_WWAN,
         .bind = cdc_ncm_bind,
         .unbind = cdc_ncm_unbind,
-        .check_connect = cdc_ncm_check_connect,
         .manage_power = usbnet_manage_power,
         .status = cdc_ncm_status,
         .rx_fixup = cdc_ncm_rx_fixup,
@@ -1432,7 +1418,6 @@ static const struct driver_info wwan_noarp_info = {
                         | FLAG_WWAN | FLAG_NOARP,
         .bind = cdc_ncm_bind,
         .unbind = cdc_ncm_unbind,
-        .check_connect = cdc_ncm_check_connect,
         .manage_power = usbnet_manage_power,
         .status = cdc_ncm_status,
         .rx_fixup = cdc_ncm_rx_fixup,
diff --git a/drivers/net/usb/huawei_cdc_ncm.c b/drivers/net/usb/huawei_cdc_ncm.c
index 312178d7b698..f9822bc75425 100644
--- a/drivers/net/usb/huawei_cdc_ncm.c
+++ b/drivers/net/usb/huawei_cdc_ncm.c
@@ -172,24 +172,11 @@ err:
         return ret;
 }
 
-static int huawei_cdc_ncm_check_connect(struct usbnet *usbnet_dev)
-{
-        struct cdc_ncm_ctx *ctx;
-
-        ctx = (struct cdc_ncm_ctx *)usbnet_dev->data[0];
-
-        if (ctx == NULL)
-                return 1; /* disconnected */
-
-        return !ctx->connected;
-}
-
 static const struct driver_info huawei_cdc_ncm_info = {
         .description = "Huawei CDC NCM device",
         .flags = FLAG_NO_SETINT | FLAG_MULTI_PACKET | FLAG_WWAN,
         .bind = huawei_cdc_ncm_bind,
         .unbind = huawei_cdc_ncm_unbind,
-        .check_connect = huawei_cdc_ncm_check_connect,
         .manage_power = huawei_cdc_ncm_manage_power,
         .rx_fixup = cdc_ncm_rx_fixup,
         .tx_fixup = cdc_ncm_tx_fixup,