diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-14 12:37:34 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-10-17 17:41:08 -0400 |
commit | 4dc8994806a812044e48514af60d4b4e0315f237 (patch) | |
tree | e54fb492393827103fc13db5163e18ce01b68290 /drivers/net/usb/rtl8150.c | |
parent | aa82661baf8a48379355ffa8bf162b07cf487600 (diff) |
USB: remove warn() macro from usb net drivers
USB should not be having it's own printk macros, so remove warn() and
use the system-wide standard of dev_warn() wherever possible. In the
few places that will not work out, use a basic printk().
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/net/usb/rtl8150.c')
-rw-r--r-- | drivers/net/usb/rtl8150.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index df56a518691c..7726b5e86764 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c | |||
@@ -221,7 +221,7 @@ static void ctrl_callback(struct urb *urb) | |||
221 | case -ENOENT: | 221 | case -ENOENT: |
222 | break; | 222 | break; |
223 | default: | 223 | default: |
224 | warn("ctrl urb status %d", urb->status); | 224 | dev_warn(&urb->dev->dev, "ctrl urb status %d\n", urb->status); |
225 | } | 225 | } |
226 | dev = urb->context; | 226 | dev = urb->context; |
227 | clear_bit(RX_REG_SET, &dev->flags); | 227 | clear_bit(RX_REG_SET, &dev->flags); |
@@ -441,10 +441,10 @@ static void read_bulk_callback(struct urb *urb) | |||
441 | case -ENOENT: | 441 | case -ENOENT: |
442 | return; /* the urb is in unlink state */ | 442 | return; /* the urb is in unlink state */ |
443 | case -ETIME: | 443 | case -ETIME: |
444 | warn("may be reset is needed?.."); | 444 | dev_warn(&urb->dev->dev, "may be reset is needed?..\n"); |
445 | goto goon; | 445 | goto goon; |
446 | default: | 446 | default: |
447 | warn("Rx status %d", urb->status); | 447 | dev_warn(&urb->dev->dev, "Rx status %d\n", urb->status); |
448 | goto goon; | 448 | goto goon; |
449 | } | 449 | } |
450 | 450 | ||
@@ -665,7 +665,7 @@ static int enable_net_traffic(rtl8150_t * dev) | |||
665 | u8 cr, tcr, rcr, msr; | 665 | u8 cr, tcr, rcr, msr; |
666 | 666 | ||
667 | if (!rtl8150_reset(dev)) { | 667 | if (!rtl8150_reset(dev)) { |
668 | warn("%s - device reset failed", __FUNCTION__); | 668 | dev_warn(&dev->udev->dev, "device reset failed\n"); |
669 | } | 669 | } |
670 | /* RCR bit7=1 attach Rx info at the end; =0 HW CRC (which is broken) */ | 670 | /* RCR bit7=1 attach Rx info at the end; =0 HW CRC (which is broken) */ |
671 | rcr = 0x9e; | 671 | rcr = 0x9e; |
@@ -699,7 +699,7 @@ static struct net_device_stats *rtl8150_netdev_stats(struct net_device *dev) | |||
699 | static void rtl8150_tx_timeout(struct net_device *netdev) | 699 | static void rtl8150_tx_timeout(struct net_device *netdev) |
700 | { | 700 | { |
701 | rtl8150_t *dev = netdev_priv(netdev); | 701 | rtl8150_t *dev = netdev_priv(netdev); |
702 | warn("%s: Tx timeout.", netdev->name); | 702 | dev_warn(&netdev->dev, "Tx timeout.\n"); |
703 | usb_unlink_urb(dev->tx_urb); | 703 | usb_unlink_urb(dev->tx_urb); |
704 | dev->stats.tx_errors++; | 704 | dev->stats.tx_errors++; |
705 | } | 705 | } |
@@ -740,7 +740,7 @@ static int rtl8150_start_xmit(struct sk_buff *skb, struct net_device *netdev) | |||
740 | if (res == -ENODEV) | 740 | if (res == -ENODEV) |
741 | netif_device_detach(dev->netdev); | 741 | netif_device_detach(dev->netdev); |
742 | else { | 742 | else { |
743 | warn("failed tx_urb %d\n", res); | 743 | dev_warn(&netdev->dev, "failed tx_urb %d\n", res); |
744 | dev->stats.tx_errors++; | 744 | dev->stats.tx_errors++; |
745 | netif_start_queue(netdev); | 745 | netif_start_queue(netdev); |
746 | } | 746 | } |
@@ -783,7 +783,7 @@ static int rtl8150_open(struct net_device *netdev) | |||
783 | if ((res = usb_submit_urb(dev->rx_urb, GFP_KERNEL))) { | 783 | if ((res = usb_submit_urb(dev->rx_urb, GFP_KERNEL))) { |
784 | if (res == -ENODEV) | 784 | if (res == -ENODEV) |
785 | netif_device_detach(dev->netdev); | 785 | netif_device_detach(dev->netdev); |
786 | warn("%s: rx_urb submit failed: %d", __FUNCTION__, res); | 786 | dev_warn(&netdev->dev, "rx_urb submit failed: %d\n", res); |
787 | return res; | 787 | return res; |
788 | } | 788 | } |
789 | usb_fill_int_urb(dev->intr_urb, dev->udev, usb_rcvintpipe(dev->udev, 3), | 789 | usb_fill_int_urb(dev->intr_urb, dev->udev, usb_rcvintpipe(dev->udev, 3), |
@@ -792,7 +792,7 @@ static int rtl8150_open(struct net_device *netdev) | |||
792 | if ((res = usb_submit_urb(dev->intr_urb, GFP_KERNEL))) { | 792 | if ((res = usb_submit_urb(dev->intr_urb, GFP_KERNEL))) { |
793 | if (res == -ENODEV) | 793 | if (res == -ENODEV) |
794 | netif_device_detach(dev->netdev); | 794 | netif_device_detach(dev->netdev); |
795 | warn("%s: intr_urb submit failed: %d", __FUNCTION__, res); | 795 | dev_warn(&netdev->dev, "intr_urb submit failed: %d\n", res); |
796 | usb_kill_urb(dev->rx_urb); | 796 | usb_kill_urb(dev->rx_urb); |
797 | return res; | 797 | return res; |
798 | } | 798 | } |