diff options
author | Joe Perches <joe@perches.com> | 2010-02-17 05:30:23 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-02-17 16:35:40 -0500 |
commit | 60b86755929e1a7e9038c8d860a8491cfdf8d93a (patch) | |
tree | 97062c7136ead4adcdbf2bd3280143da1fabbe20 /drivers/net/usb/int51x1.c | |
parent | 82456b031e3c3b5bf95a7e49bd9b68b146446e76 (diff) |
usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level>
These macros are too similar to the dev_<level> equivalents
but take a usbnet * argument. Convert them to the recently
introduced netdev_<level> macros and remove the old macros.
The old macros had "\n" appended to the format string.
Add the "\n" to the converted uses.
Some existing uses of the dev<foo> macros in cdc_eem.c
probably mistakenly had trailing "\n". No "\n" added there.
Fix net1080 this/other log message inversion.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/int51x1.c')
-rw-r--r-- | drivers/net/usb/int51x1.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/drivers/net/usb/int51x1.c b/drivers/net/usb/int51x1.c index 9ab5c1983a7d..3c228df57062 100644 --- a/drivers/net/usb/int51x1.c +++ b/drivers/net/usb/int51x1.c | |||
@@ -51,7 +51,7 @@ static int int51x1_rx_fixup(struct usbnet *dev, struct sk_buff *skb) | |||
51 | int len; | 51 | int len; |
52 | 52 | ||
53 | if (!(pskb_may_pull(skb, INT51X1_HEADER_SIZE))) { | 53 | if (!(pskb_may_pull(skb, INT51X1_HEADER_SIZE))) { |
54 | deverr(dev, "unexpected tiny rx frame"); | 54 | netdev_err(dev->net, "unexpected tiny rx frame\n"); |
55 | return 0; | 55 | return 0; |
56 | } | 56 | } |
57 | 57 | ||
@@ -138,25 +138,25 @@ static void int51x1_set_multicast(struct net_device *netdev) | |||
138 | if (netdev->flags & IFF_PROMISC) { | 138 | if (netdev->flags & IFF_PROMISC) { |
139 | /* do not expect to see traffic of other PLCs */ | 139 | /* do not expect to see traffic of other PLCs */ |
140 | filter |= PACKET_TYPE_PROMISCUOUS; | 140 | filter |= PACKET_TYPE_PROMISCUOUS; |
141 | devinfo(dev, "promiscuous mode enabled"); | 141 | netdev_info(dev->net, "promiscuous mode enabled\n"); |
142 | } else if (!netdev_mc_empty(netdev) || | 142 | } else if (!netdev_mc_empty(netdev) || |
143 | (netdev->flags & IFF_ALLMULTI)) { | 143 | (netdev->flags & IFF_ALLMULTI)) { |
144 | filter |= PACKET_TYPE_ALL_MULTICAST; | 144 | filter |= PACKET_TYPE_ALL_MULTICAST; |
145 | devdbg(dev, "receive all multicast enabled"); | 145 | netdev_dbg(dev->net, "receive all multicast enabled\n"); |
146 | } else { | 146 | } else { |
147 | /* ~PROMISCUOUS, ~MULTICAST */ | 147 | /* ~PROMISCUOUS, ~MULTICAST */ |
148 | devdbg(dev, "receive own packets only"); | 148 | netdev_dbg(dev->net, "receive own packets only\n"); |
149 | } | 149 | } |
150 | 150 | ||
151 | urb = usb_alloc_urb(0, GFP_ATOMIC); | 151 | urb = usb_alloc_urb(0, GFP_ATOMIC); |
152 | if (!urb) { | 152 | if (!urb) { |
153 | devwarn(dev, "Error allocating URB"); | 153 | netdev_warn(dev->net, "Error allocating URB\n"); |
154 | return; | 154 | return; |
155 | } | 155 | } |
156 | 156 | ||
157 | req = kmalloc(sizeof(*req), GFP_ATOMIC); | 157 | req = kmalloc(sizeof(*req), GFP_ATOMIC); |
158 | if (!req) { | 158 | if (!req) { |
159 | devwarn(dev, "Error allocating control msg"); | 159 | netdev_warn(dev->net, "Error allocating control msg\n"); |
160 | goto out; | 160 | goto out; |
161 | } | 161 | } |
162 | 162 | ||
@@ -173,7 +173,8 @@ static void int51x1_set_multicast(struct net_device *netdev) | |||
173 | 173 | ||
174 | status = usb_submit_urb(urb, GFP_ATOMIC); | 174 | status = usb_submit_urb(urb, GFP_ATOMIC); |
175 | if (status < 0) { | 175 | if (status < 0) { |
176 | devwarn(dev, "Error submitting control msg, sts=%d", status); | 176 | netdev_warn(dev->net, "Error submitting control msg, sts=%d\n", |
177 | status); | ||
177 | goto out1; | 178 | goto out1; |
178 | } | 179 | } |
179 | return; | 180 | return; |