diff options
author | Joe Perches <joe@perches.com> | 2010-02-17 05:30:24 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-02-17 16:35:41 -0500 |
commit | a475f603d23392f386e45cf377b17c30ed3bbb80 (patch) | |
tree | 47e3377f1a1bf402f33dbddc4e14768e2a9881ec /drivers/net/usb/cdc_ether.c | |
parent | 60b86755929e1a7e9038c8d860a8491cfdf8d93a (diff) |
drivers/net/usb: Use netif_<level> logging facilities
Convert from:
if (netif_msg_<foo>(priv))
dev_<level>(dev...
to
netif_<level>(priv, foo, dev...
Also convert a few:
if (i < REG_TIMEOUT) {
etc...
return ret;
}
to
if (i >= REG_TIMEOUT)
goto fail;
etc...
return ret;
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/cdc_ether.c')
-rw-r--r-- | drivers/net/usb/cdc_ether.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 7e5a75269cc5..3486e8ca039a 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c | |||
@@ -339,10 +339,10 @@ EXPORT_SYMBOL_GPL(usbnet_cdc_unbind); | |||
339 | 339 | ||
340 | static void dumpspeed(struct usbnet *dev, __le32 *speeds) | 340 | static void dumpspeed(struct usbnet *dev, __le32 *speeds) |
341 | { | 341 | { |
342 | if (netif_msg_timer(dev)) | 342 | netif_info(dev, timer, dev->net, |
343 | netdev_info(dev->net, "link speeds: %u kbps up, %u kbps down\n", | 343 | "link speeds: %u kbps up, %u kbps down\n", |
344 | __le32_to_cpu(speeds[0]) / 1000, | 344 | __le32_to_cpu(speeds[0]) / 1000, |
345 | __le32_to_cpu(speeds[1]) / 1000); | 345 | __le32_to_cpu(speeds[1]) / 1000); |
346 | } | 346 | } |
347 | 347 | ||
348 | static void cdc_status(struct usbnet *dev, struct urb *urb) | 348 | static void cdc_status(struct usbnet *dev, struct urb *urb) |
@@ -361,18 +361,16 @@ static void cdc_status(struct usbnet *dev, struct urb *urb) | |||
361 | event = urb->transfer_buffer; | 361 | event = urb->transfer_buffer; |
362 | switch (event->bNotificationType) { | 362 | switch (event->bNotificationType) { |
363 | case USB_CDC_NOTIFY_NETWORK_CONNECTION: | 363 | case USB_CDC_NOTIFY_NETWORK_CONNECTION: |
364 | if (netif_msg_timer(dev)) | 364 | netif_dbg(dev, timer, dev->net, "CDC: carrier %s\n", |
365 | netdev_dbg(dev->net, "CDC: carrier %s\n", | 365 | event->wValue ? "on" : "off"); |
366 | event->wValue ? "on" : "off"); | ||
367 | if (event->wValue) | 366 | if (event->wValue) |
368 | netif_carrier_on(dev->net); | 367 | netif_carrier_on(dev->net); |
369 | else | 368 | else |
370 | netif_carrier_off(dev->net); | 369 | netif_carrier_off(dev->net); |
371 | break; | 370 | break; |
372 | case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */ | 371 | case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */ |
373 | if (netif_msg_timer(dev)) | 372 | netif_dbg(dev, timer, dev->net, "CDC: speed change (len %d)\n", |
374 | netdev_dbg(dev->net, "CDC: speed change (len %d)\n", | 373 | urb->actual_length); |
375 | urb->actual_length); | ||
376 | if (urb->actual_length != (sizeof *event + 8)) | 374 | if (urb->actual_length != (sizeof *event + 8)) |
377 | set_bit(EVENT_STS_SPLIT, &dev->flags); | 375 | set_bit(EVENT_STS_SPLIT, &dev->flags); |
378 | else | 376 | else |